From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Clement Leger <cleger@kalray.eu>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Hoan Tran <hoan@os.amperecomputing.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/5] Add pinctrl support for dwapb gpio driver
Date: Wed, 4 Dec 2019 14:24:58 +0200 [thread overview]
Message-ID: <CAHp75VcMm3PPAgfFPLzVwg_RN7_vQfRmufvWiPOkYaErdGiNsw@mail.gmail.com> (raw)
In-Reply-To: <20191204101042.4275-1-cleger@kalray.eu>
On Wed, Dec 4, 2019 at 12:13 PM Clement Leger <cleger@kalray.eu> wrote:
>
> Synopsys DWAPB IP includes support for pin control. This control is basic
> and allows to switch between a hardware and a software function.
> Software function is when driving GPIOs from IP and hardware is controlled
> by external signals.
> This serie export necessary interface to be able to move the driver to
> pinctrl folder and then implement the pinctrl support which is based on the
> digicolor driver. The idea is to avoid hardcoding pins in driver since
> this IP is a generic one available on multiple SoC.
>
This series misses at least GPIO ACPI maintainers to be Cc'ed to for
the certain changes.
Moreover, I would like to see entire series in the future in my mailbox.
I will look at v1 closer anyway.
> Clement Leger (5):
> gpio: export acpi_gpiochip_request_interrupts in gpio/driver.h
> pinctrl: dw: move gpio-dwapb.c to pinctrl folder
> pinctrl: dw: use devm_gpiochip_add_data
> pinctrl: dw: add pinctrl support for dwapb gpio driver
> dt-bindings: pinctrl: dw: move sps,dwapb-gpio.txt to pinctrl
>
> .../bindings/{gpio => pinctrl}/snps-dwapb-gpio.txt | 21 +-
> MAINTAINERS | 6 +-
> drivers/gpio/Kconfig | 8 -
> drivers/gpio/Makefile | 1 -
> drivers/gpio/gpiolib-acpi.h | 4 -
> drivers/pinctrl/Kconfig | 1 +
> drivers/pinctrl/Makefile | 1 +
> drivers/pinctrl/dw/Kconfig | 11 +
> drivers/pinctrl/dw/Makefile | 4 +
> .../gpio-dwapb.c => pinctrl/dw/pinctrl-dwapb.c} | 277 +++++++++++++++++++--
> include/linux/gpio/driver.h | 12 +
> include/linux/platform_data/gpio-dwapb.h | 1 +
> 12 files changed, 310 insertions(+), 37 deletions(-)
> rename Documentation/devicetree/bindings/{gpio => pinctrl}/snps-dwapb-gpio.txt (76%)
> create mode 100644 drivers/pinctrl/dw/Kconfig
> create mode 100644 drivers/pinctrl/dw/Makefile
> rename drivers/{gpio/gpio-dwapb.c => pinctrl/dw/pinctrl-dwapb.c} (77%)
>
> --
> 2.15.0.276.g89ea799
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-12-04 12:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 10:10 [PATCH 0/5] Add pinctrl support for dwapb gpio driver Clement Leger
2019-12-04 12:24 ` Andy Shevchenko [this message]
2019-12-04 13:30 ` Clément Leger
2019-12-04 17:46 ` Andy Shevchenko
2019-12-13 8:59 ` Linus Walleij
2019-12-13 9:04 ` Clément Leger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VcMm3PPAgfFPLzVwg_RN7_vQfRmufvWiPOkYaErdGiNsw@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=cleger@kalray.eu \
--cc=devicetree@vger.kernel.org \
--cc=hoan@os.amperecomputing.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).