From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v1 4/4] pinctrl: intel: Convert capability list to features
Date: Fri, 8 Jan 2021 14:31:23 +0200 [thread overview]
Message-ID: <CAHp75VcPM0UH6iaCdbakgdaxM7CaJax8-kVLMzYvAeFfRYgdng@mail.gmail.com> (raw)
In-Reply-To: <CAHp75Vcckax+HYH1aYDG0tsgiL_1xXLqRW-8Xjq4+-OhLWXaLA@mail.gmail.com>
On Fri, Jan 8, 2021 at 2:22 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Fri, Jan 8, 2021 at 9:09 AM Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
> > On Thu, Jan 07, 2021 at 09:02:00PM +0200, Andy Shevchenko wrote:
...
> I don't see how it could be achieved (offsets can be unordered). If
> there is such an issue it will mean a silicon bug.
Specification says clearly that one register is a must and its value
defines the behaviour.
"The first Capability List register is located at offset 0x004... and
contains a pointer/address to the next Capability List register. The
first Capability List register is no different than others... except
for its “Capability Identification” field is always 0. The total
number of Capability List registers... is 1 at the minimum (to
determine if there is any capability)."
So I prefer to stick with my original variant.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-01-08 12:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 19:01 [PATCH v1 1/4] pinctrl: intel: Split intel_pinctrl_add_padgroups() for better maintenance Andy Shevchenko
2021-01-07 19:01 ` [PATCH v1 2/4] pinctrl: intel: Drop unnecessary check for predefined features Andy Shevchenko
2021-01-08 7:08 ` Mika Westerberg
2021-01-07 19:01 ` [PATCH v1 3/4] pinctrl: intel: Convert revision conditional to switch-case Andy Shevchenko
2021-01-08 7:05 ` Mika Westerberg
2021-01-07 19:02 ` [PATCH v1 4/4] pinctrl: intel: Convert capability list to features Andy Shevchenko
2021-01-08 7:07 ` Mika Westerberg
2021-01-08 12:22 ` Andy Shevchenko
2021-01-08 12:31 ` Andy Shevchenko [this message]
2021-01-08 12:46 ` Mika Westerberg
2021-01-08 12:51 ` Andy Shevchenko
2021-01-08 13:11 ` Mika Westerberg
2021-01-08 13:45 ` Andy Shevchenko
2021-01-08 7:07 ` [PATCH v1 1/4] pinctrl: intel: Split intel_pinctrl_add_padgroups() for better maintenance Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VcPM0UH6iaCdbakgdaxM7CaJax8-kVLMzYvAeFfRYgdng@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).