Linux-GPIO Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] gpio: gpio-crystalcove.c: changed every 'unsigned' to 'unsigned int'
@ 2020-07-21 14:48 Abanoub Sameh
  2020-07-21 16:05 ` Andy Shevchenko
  0 siblings, 1 reply; 5+ messages in thread
From: Abanoub Sameh @ 2020-07-21 14:48 UTC (permalink / raw)
  To: andy.shevchenko
  Cc: linus.walleij, bgolaszewski, linux-gpio, linux-kernel, Abanoub Sameh

Changed 'unsigned' to 'unsigned int'.
This makes the code more uniform, and compliant with the kernel coding style.

Signed-off-by: Abanoub Sameh <abanoubsameh@protonmail.com>
---
 drivers/gpio/gpio-crystalcove.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/gpio/gpio-crystalcove.c b/drivers/gpio/gpio-crystalcove.c
index 14d1f4c933b6..9391722ec107 100644
--- a/drivers/gpio/gpio-crystalcove.c
+++ b/drivers/gpio/gpio-crystalcove.c
@@ -129,7 +129,7 @@ static void crystalcove_update_irq_ctrl(struct crystalcove_gpio *cg, int gpio)
 	regmap_update_bits(cg->regmap, reg, CTLI_INTCNT_BE, cg->intcnt_value);
 }
 
-static int crystalcove_gpio_dir_in(struct gpio_chip *chip, unsigned gpio)
+static int crystalcove_gpio_dir_in(struct gpio_chip *chip, unsigned int gpio)
 {
 	struct crystalcove_gpio *cg = gpiochip_get_data(chip);
 	int reg = to_reg(gpio, CTRL_OUT);
@@ -140,7 +140,7 @@ static int crystalcove_gpio_dir_in(struct gpio_chip *chip, unsigned gpio)
 	return regmap_write(cg->regmap, reg, CTLO_INPUT_SET);
 }
 
-static int crystalcove_gpio_dir_out(struct gpio_chip *chip, unsigned gpio,
+static int crystalcove_gpio_dir_out(struct gpio_chip *chip, unsigned int gpio,
 				    int value)
 {
 	struct crystalcove_gpio *cg = gpiochip_get_data(chip);
@@ -152,7 +152,7 @@ static int crystalcove_gpio_dir_out(struct gpio_chip *chip, unsigned gpio,
 	return regmap_write(cg->regmap, reg, CTLO_OUTPUT_SET | value);
 }
 
-static int crystalcove_gpio_get(struct gpio_chip *chip, unsigned gpio)
+static int crystalcove_gpio_get(struct gpio_chip *chip, unsigned int gpio)
 {
 	struct crystalcove_gpio *cg = gpiochip_get_data(chip);
 	unsigned int val;
@@ -169,7 +169,7 @@ static int crystalcove_gpio_get(struct gpio_chip *chip, unsigned gpio)
 }
 
 static void crystalcove_gpio_set(struct gpio_chip *chip,
-				 unsigned gpio, int value)
+				 unsigned int gpio, int value)
 {
 	struct crystalcove_gpio *cg = gpiochip_get_data(chip);
 	int reg = to_reg(gpio, CTRL_OUT);
@@ -183,7 +183,7 @@ static void crystalcove_gpio_set(struct gpio_chip *chip,
 		regmap_update_bits(cg->regmap, reg, 1, 0);
 }
 
-static int crystalcove_irq_type(struct irq_data *data, unsigned type)
+static int crystalcove_irq_type(struct irq_data *data, unsigned int type)
 {
 	struct crystalcove_gpio *cg =
 		gpiochip_get_data(irq_data_get_irq_chip_data(data));
-- 
2.28.0.rc0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] gpio: gpio-crystalcove.c: changed every 'unsigned' to 'unsigned int'
  2020-07-21 14:48 [PATCH] gpio: gpio-crystalcove.c: changed every 'unsigned' to 'unsigned int' Abanoub Sameh
@ 2020-07-21 16:05 ` Andy Shevchenko
  2020-08-19 17:56   ` Bartosz Golaszewski
  0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2020-07-21 16:05 UTC (permalink / raw)
  To: Abanoub Sameh
  Cc: Linus Walleij, Bartosz Golaszewski, open list:GPIO SUBSYSTEM,
	Linux Kernel Mailing List, Abanoub Sameh

On Tue, Jul 21, 2020 at 5:49 PM Abanoub Sameh <abanoubsameh8@gmail.com> wrote:
>
> Changed 'unsigned' to 'unsigned int'.
> This makes the code more uniform, and compliant with the kernel coding style.

In all patches you wrongly added 'gpio-' and '.c' parts. Also you
missed the version of the patches (I have told you about) and
changelog.

No need to resend, I fixed that this time for you. Be careful in the future.

-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] gpio: gpio-crystalcove.c: changed every 'unsigned' to 'unsigned int'
  2020-07-21 16:05 ` Andy Shevchenko
@ 2020-08-19 17:56   ` Bartosz Golaszewski
  2020-08-19 18:50     ` Andy Shevchenko
  0 siblings, 1 reply; 5+ messages in thread
From: Bartosz Golaszewski @ 2020-08-19 17:56 UTC (permalink / raw)
  To: Andy Shevchenko
  Cc: Abanoub Sameh, Linus Walleij, open list:GPIO SUBSYSTEM,
	Linux Kernel Mailing List, Abanoub Sameh

On Tue, Jul 21, 2020 at 6:05 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Tue, Jul 21, 2020 at 5:49 PM Abanoub Sameh <abanoubsameh8@gmail.com> wrote:
> >
> > Changed 'unsigned' to 'unsigned int'.
> > This makes the code more uniform, and compliant with the kernel coding style.
>
> In all patches you wrongly added 'gpio-' and '.c' parts. Also you
> missed the version of the patches (I have told you about) and
> changelog.
>
> No need to resend, I fixed that this time for you. Be careful in the future.
>
> --
> With Best Regards,
> Andy Shevchenko

Hi Andy,

I was going through pending patches and noticed those from Abanoub:
are you also the maintainer for gpio-crystalcove and gpio-msic? The
MAINTAINERS entry for Intel GPIO drivers doesn't include those - do
you want me to send a patch that adds them?

Bartosz

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] gpio: gpio-crystalcove.c: changed every 'unsigned' to 'unsigned int'
  2020-08-19 17:56   ` Bartosz Golaszewski
@ 2020-08-19 18:50     ` Andy Shevchenko
  2020-08-19 18:52       ` Bartosz Golaszewski
  0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2020-08-19 18:50 UTC (permalink / raw)
  To: Bartosz Golaszewski
  Cc: Abanoub Sameh, Linus Walleij, open list:GPIO SUBSYSTEM,
	Linux Kernel Mailing List, Abanoub Sameh

On Wed, Aug 19, 2020 at 8:56 PM Bartosz Golaszewski
<bgolaszewski@baylibre.com> wrote:
>
> On Tue, Jul 21, 2020 at 6:05 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> >
> > On Tue, Jul 21, 2020 at 5:49 PM Abanoub Sameh <abanoubsameh8@gmail.com> wrote:
> > >
> > > Changed 'unsigned' to 'unsigned int'.
> > > This makes the code more uniform, and compliant with the kernel coding style.
> >
> > In all patches you wrongly added 'gpio-' and '.c' parts. Also you
> > missed the version of the patches (I have told you about) and
> > changelog.
> >
> > No need to resend, I fixed that this time for you. Be careful in the future.

> I was going through pending patches and noticed those from Abanoub:
> are you also the maintainer for gpio-crystalcove and gpio-msic? The
> MAINTAINERS entry for Intel GPIO drivers doesn't include those - do
> you want me to send a patch that adds them?

Hmm...
https://elixir.bootlin.com/linux/latest/source/MAINTAINERS#L8833


-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] gpio: gpio-crystalcove.c: changed every 'unsigned' to 'unsigned int'
  2020-08-19 18:50     ` Andy Shevchenko
@ 2020-08-19 18:52       ` Bartosz Golaszewski
  0 siblings, 0 replies; 5+ messages in thread
From: Bartosz Golaszewski @ 2020-08-19 18:52 UTC (permalink / raw)
  To: Andy Shevchenko
  Cc: Bartosz Golaszewski, Abanoub Sameh, Linus Walleij,
	open list:GPIO SUBSYSTEM, Linux Kernel Mailing List,
	Abanoub Sameh

On Wed, Aug 19, 2020 at 8:50 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Wed, Aug 19, 2020 at 8:56 PM Bartosz Golaszewski
> <bgolaszewski@baylibre.com> wrote:
> >
> > On Tue, Jul 21, 2020 at 6:05 PM Andy Shevchenko
> > <andy.shevchenko@gmail.com> wrote:
> > >
> > > On Tue, Jul 21, 2020 at 5:49 PM Abanoub Sameh <abanoubsameh8@gmail.com> wrote:
> > > >
> > > > Changed 'unsigned' to 'unsigned int'.
> > > > This makes the code more uniform, and compliant with the kernel coding style.
> > >
> > > In all patches you wrongly added 'gpio-' and '.c' parts. Also you
> > > missed the version of the patches (I have told you about) and
> > > changelog.
> > >
> > > No need to resend, I fixed that this time for you. Be careful in the future.
>
> > I was going through pending patches and noticed those from Abanoub:
> > are you also the maintainer for gpio-crystalcove and gpio-msic? The
> > MAINTAINERS entry for Intel GPIO drivers doesn't include those - do
> > you want me to send a patch that adds them?
>
> Hmm...
> https://elixir.bootlin.com/linux/latest/source/MAINTAINERS#L8833
>

Ah, I was grepping with "crystalcove" and didn't find anything.
Strange I missed msic too though. Anyway: nevermind my email.

Bart

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-21 14:48 [PATCH] gpio: gpio-crystalcove.c: changed every 'unsigned' to 'unsigned int' Abanoub Sameh
2020-07-21 16:05 ` Andy Shevchenko
2020-08-19 17:56   ` Bartosz Golaszewski
2020-08-19 18:50     ` Andy Shevchenko
2020-08-19 18:52       ` Bartosz Golaszewski

Linux-GPIO Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-gpio/0 linux-gpio/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-gpio linux-gpio/ https://lore.kernel.org/linux-gpio \
		linux-gpio@vger.kernel.org
	public-inbox-index linux-gpio

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-gpio


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git