Linux-GPIO Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] gpiolib: of: reset name variable in of_gpiochip_add_hog
@ 2020-07-28 13:42 trix
  2020-07-28 18:27 ` Andy Shevchenko
  0 siblings, 1 reply; 2+ messages in thread
From: trix @ 2020-07-28 13:42 UTC (permalink / raw)
  To: linus.walleij, bgolaszewski, frank.rowand, geert+renesas
  Cc: linux-gpio, linux-kernel, Tom Rix

From: Tom Rix <trix@redhat.com>

Clang static analysis reports this error

gpiolib-of.c:664:9: warning: 2nd function call argument
  is an uninitialized value [core.CallAndMessage]
        ret = gpiod_hog(desc, name, lflags, dflags);

name is sometimes set by of_parse_own_gpio
name is always used by gpiod_hog

So it is necessary to reset name so an old value is
not mistakenly used by gpiod_hog.

Fixes: bc21077e084b ("gpio: of: Extract of_gpiochip_add_hog()")

Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/gpio/gpiolib-of.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
index bd31dd3b6a75..277ada41d04a 100644
--- a/drivers/gpio/gpiolib-of.c
+++ b/drivers/gpio/gpiolib-of.c
@@ -657,6 +657,7 @@ static int of_gpiochip_add_hog(struct gpio_chip *chip, struct device_node *hog)
 	int ret;
 
 	for (i = 0;; i++) {
+		name = NULL;
 		desc = of_parse_own_gpio(hog, chip, i, &name, &lflags, &dflags);
 		if (IS_ERR(desc))
 			break;
-- 
2.18.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] gpiolib: of: reset name variable in of_gpiochip_add_hog
  2020-07-28 13:42 [PATCH] gpiolib: of: reset name variable in of_gpiochip_add_hog trix
@ 2020-07-28 18:27 ` Andy Shevchenko
  0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2020-07-28 18:27 UTC (permalink / raw)
  To: trix
  Cc: Linus Walleij, Bartosz Golaszewski, frank.rowand,
	Geert Uytterhoeven, open list:GPIO SUBSYSTEM,
	Linux Kernel Mailing List

On Tue, Jul 28, 2020 at 4:44 PM <trix@redhat.com> wrote:
>
> From: Tom Rix <trix@redhat.com>
>
> Clang static analysis reports this error
>
> gpiolib-of.c:664:9: warning: 2nd function call argument
>   is an uninitialized value [core.CallAndMessage]
>         ret = gpiod_hog(desc, name, lflags, dflags);
>

> name is sometimes set by of_parse_own_gpio
> name is always used by gpiod_hog

It's not clear if it's the output of the analyser.
If so, try to file a bug and fix there how it prints out functions,
should be func().
Otherwise fix in the commit message.

> So it is necessary to reset name so an old value is

the name

> not mistakenly used by gpiod_hog.

gpiod_hog()

> Fixes: bc21077e084b ("gpio: of: Extract of_gpiochip_add_hog()")
>
> Signed-off-by: Tom Rix <trix@redhat.com>

Should be no blank line in between.

> ---
>  drivers/gpio/gpiolib-of.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
> index bd31dd3b6a75..277ada41d04a 100644
> --- a/drivers/gpio/gpiolib-of.c
> +++ b/drivers/gpio/gpiolib-of.c
> @@ -657,6 +657,7 @@ static int of_gpiochip_add_hog(struct gpio_chip *chip, struct device_node *hog)
>         int ret;
>
>         for (i = 0;; i++) {
> +               name = NULL;
>                 desc = of_parse_own_gpio(hog, chip, i, &name, &lflags, &dflags);
>                 if (IS_ERR(desc))
>                         break;
> --
> 2.18.1
>


-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-28 13:42 [PATCH] gpiolib: of: reset name variable in of_gpiochip_add_hog trix
2020-07-28 18:27 ` Andy Shevchenko

Linux-GPIO Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-gpio/0 linux-gpio/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-gpio linux-gpio/ https://lore.kernel.org/linux-gpio \
		linux-gpio@vger.kernel.org
	public-inbox-index linux-gpio

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-gpio


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git