From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0DF4C10DCE for ; Thu, 12 Mar 2020 17:16:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BF1A72067C for ; Thu, 12 Mar 2020 17:16:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gateworks-com.20150623.gappssmtp.com header.i=@gateworks-com.20150623.gappssmtp.com header.b="Ka1odxjc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726523AbgCLRQx (ORCPT ); Thu, 12 Mar 2020 13:16:53 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:40179 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726387AbgCLRQx (ORCPT ); Thu, 12 Mar 2020 13:16:53 -0400 Received: by mail-wm1-f68.google.com with SMTP id e26so7218914wme.5 for ; Thu, 12 Mar 2020 10:16:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gateworks-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rQJ5s9eoNFBhar1wZ/+BMG+x4PEp7qiKoL1BTIgIvvA=; b=Ka1odxjcRRSsZ1+P6Rn0WoEFDUeURVfcilak6U3iuZHIxRHE32ImI96XvKGoiCT0Y7 zOYxfW2tFhqwc83KnA9LRE9Y/bECcG7knYp4dAlJcuSZ+I7KEIaRB3wcsXhJxjfiXysU AfHFRHk0Ue+Vz6LtljNNVf05jOc3/U5XBXJs6yw4uB8pzEy5of9iCcDQ/+jsEKLk1Rdn I1SB61RY0n8txp2+PVnprLtCRZmOpBLDdFcO8eT6UQTFnaNKh8ECGg5RZsdHoMNNnSau dBV330hv6bac+puft7f4osu2jlwoU3uhEYQAeObG+QQQvrgkMs1w3Q2AWx8CLl0tP3ud fSDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rQJ5s9eoNFBhar1wZ/+BMG+x4PEp7qiKoL1BTIgIvvA=; b=G9Vp0geBuF056F0lzX4Krfnky/IrPqaxQXxnoWvRo/0JqdPiGllsig+R1JeEFWlTQG 5E85Y32vVlB+xr0z5RrNBTAxfbjbfXbIULi2W1rYr8l/juOsz+8UExdzuul10Mn/qn4f RnFLElGT+Nz3f1sV5Ru5D3Z4UBZUJYJ061FM8KnLafDa/0Z7d8u2/K51Z92lutmT/FgF HK2gqNN6dJeQdnqRCnhjy5f488bELtxgs95pGYUC+aRyem7LD3mGp15X4f6UqkUU+Kl2 9MRo4kmWSYprTe2bcXGJ6s7J/NzJ7kr8xsisU803uVsK0NknMn+ScuAzTdTKW3ODq2JY eLcg== X-Gm-Message-State: ANhLgQ0Mr1GaJc7dgg8leMoD0uHrznIlunScyI8PlvlFOr4jdgB3xYPi RZqBSFnfEyB0YMpZULFHj41jdm8fq9wvLmt8EnWZ/Q== X-Google-Smtp-Source: ADFU+vu9dcCqLenemNcAbEsZxGNAgsL5dkMGe56iFZ3uiRQSP35P55TvBH1Ty/uEmKNJhGhG9PF3mjvXjiunAlHs0ls= X-Received: by 2002:a05:600c:2188:: with SMTP id e8mr6133594wme.83.1584033411490; Thu, 12 Mar 2020 10:16:51 -0700 (PDT) MIME-Version: 1.0 References: <1583941433-15876-1-git-send-email-tharvey@gateworks.com> In-Reply-To: From: Tim Harvey Date: Thu, 12 Mar 2020 10:16:40 -0700 Message-ID: Subject: Re: [PATCH] gpio: thunderx: fix irq_request_resources To: Linus Walleij , stable@vger.kernel.org Cc: Robert Richter , Lokesh Vutla , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, Mar 12, 2020 at 6:42 AM Linus Walleij wrote: > > On Wed, Mar 11, 2020 at 4:43 PM Tim Harvey wrote: > > > If there are no parent resources do not call irq_chip_request_resources_parent > > at all as this will return an error. > > > > This resolves a regression where devices using a thunderx gpio as an interrupt > > would fail probing. > > > > Fixes: 0d04d0c ("gpio: thunderx: Use the default parent apis for {request,release}_resources") > > Signed-off-by: Tim Harvey > > This patch does not apply to the mainline kernel or v5.6-rc1. > > Please verify: > 1. If the problem is still in v5.6 (we refactored the driver to > use GPIOLIB_IRQCHIP) Linus, Sorry, another issue was keeping me from being able to boot 5.6-rc but that's now understood and I can confirm the issue is not present in v5.6-rc5 > > 2. If not, only propose it for linux-stable v5.5 etc. > Yes, needs to be applied to v5.2, v5.3, v5.4, v5.5. I cc'd stable. If I need to re-submit please let me know. Cc: stable@vger.kernel.org Tim