From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CB63ECDE20 for ; Thu, 12 Sep 2019 09:23:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0D3EB21479 for ; Thu, 12 Sep 2019 09:23:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730637AbfILJXq (ORCPT ); Thu, 12 Sep 2019 05:23:46 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:39781 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730631AbfILJXq (ORCPT ); Thu, 12 Sep 2019 05:23:46 -0400 Received: by mail-qt1-f193.google.com with SMTP id n7so28781728qtb.6; Thu, 12 Sep 2019 02:23:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QXQcfTndnrpIGvk9sB9a9gWQqmEHMhawitV9TbB2g8E=; b=EFC7Pzc2RJMO0kYGJY36B6M/KiGYRXH34bY3unVZ4f8E0v6kvTTDr1MhCuFTowLzj7 tj5RG4fkbt5/xCdfAxg7gFGlN7GA7q4JnDrhVGD7kTU9IeJnx9p7DZsRCD8w476mlLn/ UW/vayWu0r1BQqBEGEajHhBBN4gUlxvedR5iU8vS4Pw/5bUdtz7zDegk4bxTpIjIC9GP 0SqOacOUHywwYNrShU4Fei9l32K+S12f57O9zSrxehjdOhzMZXp7Vl4BSXd737Ue7XXT 4NoGM0rDHwyPCNrlfTa+ehntgy/DTJm+IBYiBJQHz467FTCLxIZvESTTLDefx8a5jUKa dn2w== X-Gm-Message-State: APjAAAVs+OGWqJr76OkTp0nWYIVHgiBhTqOQ/fb5JNQeOQZyaaaHmj/0 2BlOcbBx+7ZGBoFHyCgk2XSpRZYz9ck+A+/GrSA= X-Google-Smtp-Source: APXvYqziwk60aLJSQdoVYvx52qn+2u/NADJ4HuF3YjYBj52OuDv7Y0SaYvYRwH+Wen8XN74tjClsdCK2jrcZk15F5go= X-Received: by 2002:ad4:4529:: with SMTP id l9mr21307225qvu.45.1568280224996; Thu, 12 Sep 2019 02:23:44 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Arnd Bergmann Date: Thu, 12 Sep 2019 11:23:29 +0200 Message-ID: Subject: Re: [PATCH 1/4] arm64: Kconfig: Fix XGENE driver dependencies To: Amit Kucheria Cc: "linux-kernel@vger.kernel.org" , Linux ARM , arm-soc , Bartosz Golaszewski , Catalin Marinas , Kishon Vijay Abraham I , Liam Girdwood , Linus Walleij , Lorenzo Pieralisi , Mark Brown , Michael Turquette , Sebastian Reichel , Stephen Boyd , Will Deacon , linux-clk , "open list:GPIO SUBSYSTEM" , linux-pci , Linux PM list Content-Type: text/plain; charset="UTF-8" Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, Sep 12, 2019 at 12:19 AM Amit Kucheria wrote: > > Push various XGENE drivers behind ARCH_XGENE dependency so that it > doesn't get enabled by default on other platforms. > > Signed-off-by: Amit Kucheria > --- > arch/arm64/Kconfig.platforms | 3 +++ > drivers/clk/Kconfig | 2 +- > drivers/gpio/Kconfig | 1 + > drivers/pci/controller/Kconfig | 1 + > drivers/phy/Kconfig | 1 + > drivers/power/reset/Kconfig | 2 +- > 6 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > index 4778c775de1b..cdf4e452e34c 100644 > --- a/arch/arm64/Kconfig.platforms > +++ b/arch/arm64/Kconfig.platforms > @@ -281,6 +281,9 @@ config ARCH_VULCAN > > config ARCH_XGENE > bool "AppliedMicro X-Gene SOC Family" > + select COMMON_CLK_XGENE > + select PCI_XGENE > + select GPIO_XGENE > help > This enables support for AppliedMicro X-Gene SOC Family I'd rather not 'select' drivers that might be optional, the 'default y' should be sufficient as long as it's in theory possible to have them disabled or as loadable modules. > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > index 801fa1cd0321..9b2790d3f18a 100644 > --- a/drivers/clk/Kconfig > +++ b/drivers/clk/Kconfig > @@ -225,7 +225,7 @@ config CLK_QORIQ > > config COMMON_CLK_XGENE > bool "Clock driver for APM XGene SoC" > - default ARCH_XGENE > + depends on ARCH_XGENE > depends on ARM64 || COMPILE_TEST > ---help--- > Sypport for the APM X-Gene SoC reference, PLL, and device clocks. This breaks compile-testing, and existing defconfigs that don't list the driver. Arnd