From: Vincent Guittot <vincent.guittot@linaro.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Linus Walleij <linus.walleij@linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
virtualization@lists.linux-foundation.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
"Stefano Garzarella --cc virtualization @ lists .
linux-foundation . org" <sgarzare@redhat.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Viresh Kumar <vireshk@kernel.org>,
Stratos Mailing List <stratos-dev@op-lists.linaro.org>,
"Enrico Weigelt, metux IT consult" <info@metux.net>,
Jason Wang <jasowang@redhat.com>
Subject: Re: [Stratos-dev] [PATCH V3 1/3] gpio: Add virtio-gpio driver
Date: Tue, 15 Jun 2021 09:30:09 +0200 [thread overview]
Message-ID: <CAKfTPtCrAxADvpcEqDOXru249ON-yvjMt_ti+8prv5FTiZUZaQ@mail.gmail.com> (raw)
In-Reply-To: <CAK8P3a2SmZcqrJcget=7-p07GsHqAfiDgzjEQOC6NHwaFydgPQ@mail.gmail.com>
On Mon, 14 Jun 2021 at 22:56, Arnd Bergmann <arnd@kernel.org> wrote:
>
> On Mon, Jun 14, 2021 at 3:24 PM Vincent Guittot
> <vincent.guittot@linaro.org> wrote:
> > On Mon, 14 Jun 2021 at 15:00, Arnd Bergmann <arnd@kernel.org> wrote:
> > > On Mon, Jun 14, 2021 at 2:50 PM Vincent Guittot via Stratos-dev <stratos-dev@op-lists.linaro.org> wrote:>
> > >
> > > But this example seem to be completely different from the ones I mentioned:
> > > The scmi node that you have here looks like it shows up under the root of the
> > > device tree, not below the virtio device that implements the scmi transport.
> >
> > I was thinking of something like below:
> >
> > deviceX: deviceX@YYYYYYY {
> > ...
> > gpio = <&virtio_gpio 0>;
> > ...
> > };
> >
> > virtio_mmio@a000000 {
> > dma-coherent;
> > interrupts = <0x0 0x10 0x1>;
> > reg = <0x0 0xa000000 0x0 0x200>;
> > compatible = "virtio,mmio";
> >
> > virtio_gpio: protocol@22 {
> > reg = <0x22>;
> > };
>
> Encoding the device ID as "reg" seems somewhat odd, especially since there
> can only be one child for each virtio device. The other bus types use the
> "compatible" property instead of "reg" for this purpose. This is still
> redundant,
> since the type is also known from the contents, but it seems less unusual.
At least this ensures to match directly the protocol id instead of
mapping a compatible string with the protocol id.
>
> The gpio node in the example is usually called "gpio" or "gpio-controller", and
> it would then need the "gpio-controller" and "#gpio-cells" properties so other
> nodes can refer to it by phandle.
yes, This short example is just to show what I mean.
>
> Arnd
next prev parent reply other threads:[~2021-06-15 7:30 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 12:09 [PATCH V3 0/3] gpio: Add virtio based driver Viresh Kumar
2021-06-10 12:16 ` [PATCH V3 1/3] gpio: Add virtio-gpio driver Viresh Kumar
2021-06-10 13:22 ` Arnd Bergmann
2021-06-10 16:00 ` Enrico Weigelt, metux IT consult
[not found] ` <01000179f6a7715c-cd106846-7770-4088-bb7c-a696bfcbf83e-000000@email.amazonses.com>
2021-06-10 17:03 ` [Stratos-dev] " Jean-Philippe Brucker
2021-06-10 19:41 ` Arnd Bergmann
2021-06-14 10:21 ` Viresh Kumar
2021-06-14 12:31 ` Arnd Bergmann
2021-06-14 12:49 ` Vincent Guittot
[not found] ` <0100017a0a9264cc-57668c56-fdbf-412a-9f82-9bf95f5c653e-000000@email.amazonses.com>
2021-06-14 12:58 ` [Stratos-dev] " Arnd Bergmann
2021-06-14 13:24 ` Vincent Guittot
2021-06-14 20:54 ` Arnd Bergmann
2021-06-15 7:30 ` Vincent Guittot [this message]
2021-06-10 15:54 ` Enrico Weigelt, metux IT consult
2021-06-10 16:57 ` Viresh Kumar
2021-06-10 20:46 ` Linus Walleij
2021-06-11 3:56 ` Viresh Kumar
2021-06-11 7:42 ` Geert Uytterhoeven
2021-06-11 8:01 ` Viresh Kumar
2021-06-11 8:22 ` Geert Uytterhoeven
2021-06-15 11:15 ` Viresh Kumar
2021-06-15 11:37 ` Geert Uytterhoeven
2021-06-15 20:03 ` Linus Walleij
2021-06-16 1:45 ` Viresh Kumar
2021-06-14 8:07 ` Enrico Weigelt, metux IT consult
2021-06-14 8:12 ` Andy Shevchenko
2021-06-14 9:14 ` Viresh Kumar
2021-06-14 9:17 ` Enrico Weigelt, metux IT consult
2021-06-14 9:52 ` Viresh Kumar
2021-06-14 9:12 ` Viresh Kumar
2021-06-14 9:29 ` Enrico Weigelt, metux IT consult
2021-06-14 8:03 ` Enrico Weigelt, metux IT consult
2021-06-14 9:24 ` Viresh Kumar
2021-06-16 3:30 ` Bjorn Andersson
2021-06-16 15:52 ` Enrico Weigelt, metux IT consult
2021-06-18 9:13 ` Linus Walleij
2021-06-21 17:25 ` Bjorn Andersson
2021-06-10 12:16 ` [PATCH V3 2/3] gpio: virtio: Add IRQ support Viresh Kumar
2021-06-10 21:30 ` Linus Walleij
2021-06-14 7:08 ` Viresh Kumar
2021-06-10 12:16 ` [PATCH V3 3/3] MAINTAINERS: Add entry for Virtio-gpio Viresh Kumar
[not found] ` <01000179f5da7763-2ea817c6-e176-423a-952e-de02443f71e2-000000@email.amazonses.com>
2021-06-10 17:40 ` [PATCH V3 1/3] gpio: Add virtio-gpio driver Jean-Philippe Brucker
2021-06-11 3:39 ` Viresh Kumar
[not found] ` <01000179f9276678-ae2bb25f-4c0c-4176-b906-650c585b9753-000000@email.amazonses.com>
2021-06-11 8:34 ` [Stratos-dev] " Arnd Bergmann
2021-06-14 5:26 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKfTPtCrAxADvpcEqDOXru249ON-yvjMt_ti+8prv5FTiZUZaQ@mail.gmail.com \
--to=vincent.guittot@linaro.org \
--cc=arnd@kernel.org \
--cc=bgolaszewski@baylibre.com \
--cc=info@metux.net \
--cc=jasowang@redhat.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
--cc=stratos-dev@op-lists.linaro.org \
--cc=vireshk@kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).