From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E05F8C433E0 for ; Mon, 15 Jun 2020 15:02:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C0730206D7 for ; Mon, 15 Jun 2020 15:02:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592233366; bh=cLE/KDQ7zi8CXnleskZoZ1Ql9hp/DpDm7B2xPgtp8Pc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=Y4BCA4h5eWNArymDCPrTLMlOjm+OwhKHx7EU9JmalNJ9r1fZfZ+LxEBLQNtuWx/jL eIT0yFghnARKI/JI4mhcc+3oVvovuEcI3okZnY36nz/6P6lT7Dy3elePInitROoHEO RXRFklBH6+QGIlC2V2g6DlL70RV+88mCxQBjvXJQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730881AbgFOPCl (ORCPT ); Mon, 15 Jun 2020 11:02:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:48452 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730777AbgFOPCl (ORCPT ); Mon, 15 Jun 2020 11:02:41 -0400 Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com [209.85.210.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 05B542078A; Mon, 15 Jun 2020 15:02:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592233360; bh=cLE/KDQ7zi8CXnleskZoZ1Ql9hp/DpDm7B2xPgtp8Pc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Y/Z6obKYdtRw3N7G0dSci0N/ySSHnfwI0VNvmTCeY5dHarhRxKChHbUr6Buy9daJP D4GTJuhsL/S5ZeAsl+9VS3pxK89gzUu2/ZqmiHMO2Yj5hAnMlh0RuCyELdAW2JFx3u wr/1hQxPWYOL9irTK4WJNpAqnTDfHvZBVpb+ZVVs= Received: by mail-ot1-f42.google.com with SMTP id n5so2708691otj.1; Mon, 15 Jun 2020 08:02:39 -0700 (PDT) X-Gm-Message-State: AOAM532EM5j/AyvpSbbWi9j5UQinstFVaQwmlaCAq06tbrAIz0M03qz2 Bo4HU11cnwS+FjD5wPaNSzFjkcmbzs6dSCGc+Q== X-Google-Smtp-Source: ABdhPJzjxGO9DWEIsfipS4yrm2PPJNlfjEILXBJsHkZzS1HbqK8iCTqz315EJs5dkJCwXWaRJRWjBuWpAO9+qSTHPZY= X-Received: by 2002:a05:6830:3104:: with SMTP id b4mr22220499ots.192.1592233359274; Mon, 15 Jun 2020 08:02:39 -0700 (PDT) MIME-Version: 1.0 References: <20200612144713.502006-1-kieran.bingham+renesas@ideasonboard.com> <20200612144713.502006-2-kieran.bingham+renesas@ideasonboard.com> <20200612221003.GA3901624@bogus> <20200613123207.6ey6y5spfa5ajk4h@uno.localdomain> In-Reply-To: <20200613123207.6ey6y5spfa5ajk4h@uno.localdomain> From: Rob Herring Date: Mon, 15 Jun 2020 09:02:28 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v10 1/4] dt-bindings: media: i2c: Add bindings for Maxim Integrated MAX9286 To: Jacopo Mondi Cc: Kieran Bingham , Laurent Pinchart , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" , Hyun Kwon , Linux Media Mailing List , Linus Walleij , Mauro Carvalho Chehab , Kieran Bingham , Sakari Ailus , =?UTF-8?Q?Niklas_S=C3=B6derlund?= , Laurent Pinchart , Manivannan Sadhasivam , devicetree@vger.kernel.org, =?UTF-8?Q?Niklas_S=C3=B6derlund?= , "open list:MEDIA DRIVERS FOR RENESAS - FCP" , Jacopo Mondi , Hans Verkuil Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Sat, Jun 13, 2020 at 6:28 AM Jacopo Mondi wrote: > > Hi Rob, > > On Fri, Jun 12, 2020 at 04:10:03PM -0600, Rob Herring wrote: > > On Fri, 12 Jun 2020 15:47:10 +0100, Kieran Bingham wrote: > > > From: Laurent Pinchart > > > > > > The MAX9286 deserializes video data received on up to 4 Gigabit > > > Multimedia Serial Links (GMSL) and outputs them on a CSI-2 port using= up > > > to 4 data lanes. > > > > > > Signed-off-by: Laurent Pinchart > > > Signed-off-by: Jacopo Mondi > > > Signed-off-by: Kieran Bingham > > > Reviewed-by: Niklas S=C3=B6derlund > > > Signed-off-by: Niklas S=C3=B6derlund > > > Reviewed-by: Rob Herring > > > > > > --- > > > > > > v7: > > > - Collect Rob's RB tag > > > - Remove redundant maxItems from remote-endpoints > > > - Fix SPDX licence tag > > > > > > v10: > > > [Jacopo] > > > - Fix dt-validation > > > - Fix dt-binding examples with 2 reg entries > > > > > > [Kieran] > > > - Correctly match the hex camera node reg > > > - Add (required) GPIO controller support > > > > > > .../bindings/media/i2c/maxim,max9286.yaml | 366 ++++++++++++++++= ++ > > > 1 file changed, 366 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/media/i2c/maxim= ,max9286.yaml > > > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/me= dia/i2c/maxim,max9286.example.dt.yaml: example-0: i2c@e66d8000:reg:0: [0, 3= 865935872, 0, 64] is too long > > > > > > See https://patchwork.ozlabs.org/patch/1308280 > > > > If you already ran 'make dt_binding_check' and didn't see the above > > error(s), then make sure dt-schema is up to date: > > > > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master= --upgrade > > > > I have updated my dt-schema installation to the latest github master > -------------------------------------------------------------------------= ------ > Successfully installed dtschema-2020.6.dev8+g4d2d86c > > https://github.com/devicetree-org/dt-schema/commit/4d2d86c5cd65cd3944ce0a= aa400866bc36727bea > > $ /usr/bin/dt-validate -V > 2020.6.dev8+g4d2d86c > -------------------------------------------------------------------------= ------ > > But I still cannot reproduce the error. > > However, I see this commit in your next branch > https://github.com/devicetree-org/dt-schema/commit/b72500282cfd2eba6f9df4= d7553f696544b40ee6 > "schemas: Add a schema to check 'reg' sizes " > > Which sounds very likely related to the above reported error. > Was this intentional ? Yes, I can't add the new checks to master until all the in tree schema are fixed yet I want to check submissions with pending checks, so I created the 'next' branch. > I'm not sure how I should handle this. The error reports the i2c node > parents should have both address-cells and size-cells properties set > to 2, but in the example there is not i2c node parent at all :) > Should I add a parent node for the i2c in the example snippet ? The examples have default sizes of 1 cell. If you need something different, the example has to define a parent node to specify it. In your case, I'd just change 'reg' to use 1 cell each. Rob