From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70404C2D0F1 for ; Tue, 31 Mar 2020 14:48:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 47A132078B for ; Tue, 31 Mar 2020 14:48:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585666130; bh=e/7jTSv5Ln/7N2erMxSAhTPfQO0mGgov7i4pB0Kxz8M=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=ASJAq9+KkR1tIcP1Aqm6kX8nu3p1POjKMPLCXCd7WcMK40JhjXdEfUDzvfeEkHDNn f/HvXOObXLTP1M3NM5mHnrw2ALnq9Fxnn4ExDyFoX8FlFQKYhLQKslK+GuuQnUYsLh drBXFyUcsqCdynFakYv8RSur8J6Sf4M9DLIFOb2Y= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730589AbgCaOst (ORCPT ); Tue, 31 Mar 2020 10:48:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:57552 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730574AbgCaOst (ORCPT ); Tue, 31 Mar 2020 10:48:49 -0400 Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 98470214DB; Tue, 31 Mar 2020 14:48:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585666128; bh=e/7jTSv5Ln/7N2erMxSAhTPfQO0mGgov7i4pB0Kxz8M=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=EbrJxT9+qQ4vbmfQodNUZ75MqmrVy3/2NQDxPg4GsBywCzjeqIw2fq6lj3s7435X2 NIM+7Ydop9wv5/4CkHGw9c7dOJtPBA/zSDJDrPe+DungVFsSYeZaSpNvpWfCUq24L2 R+q388+xL8Vgv6ukYJr671hgBiLOn4kma+Cvp9Ro= Received: by mail-qv1-f41.google.com with SMTP id p60so10971550qva.5; Tue, 31 Mar 2020 07:48:48 -0700 (PDT) X-Gm-Message-State: ANhLgQ1vMtCY640U90YBDNmS9RLEHsh5XJbMHUiAIrRTnM79TJ+N1F3y F6fi44rWk2ybm3rFmqdCCAJmx/+EFr9IetQppQ== X-Google-Smtp-Source: ADFU+vsm7QnLg9VC47OO+I8GiU3/k2tefVEY+Sy39Kwt/VBNT1kmLS6ih/sV4b6JI7vayYbVNykmFae5IwQbSwKy9fk= X-Received: by 2002:ad4:4bc3:: with SMTP id l3mr16286378qvw.79.1585666127545; Tue, 31 Mar 2020 07:48:47 -0700 (PDT) MIME-Version: 1.0 References: <20200325220542.19189-1-robh@kernel.org> <20200325220542.19189-2-robh@kernel.org> <20200327202159.GA12749@ravnborg.org> In-Reply-To: <20200327202159.GA12749@ravnborg.org> From: Rob Herring Date: Tue, 31 Mar 2020 08:48:36 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/4] dt-bindings: iio/accel: Drop duplicate adi, adxl345/6 from trivial-devices.yaml To: Sam Ravnborg Cc: devicetree@vger.kernel.org, Neil Armstrong , "open list:IIO SUBSYSTEM AND DRIVERS" , dri-devel , "linux-kernel@vger.kernel.org" , Masahiro Yamada , Guillaume La Roque , Peter Meerwald-Stadler , Lee Jones , linux-clk , Kevin Hilman , Daniel Lezcano , Bartosz Golaszewski , Zhang Rui , Brian Masney , Michael Hennerich , "open list:THERMAL" , linux-arm-msm , Mauro Carvalho Chehab , "open list:GPIO SUBSYSTEM" , Mark Brown , "open list:ARM/Amlogic Meson..." , Thomas Gleixner , Bjorn Andersson , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Stephen Boyd , netdev , Liam Girdwood , Hartmut Knaack , Linux Media Mailing List , "David S. Miller" , Jonathan Cameron Content-Type: text/plain; charset="UTF-8" Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Fri, Mar 27, 2020 at 2:22 PM Sam Ravnborg wrote: > > Hi Rob. > > On Wed, Mar 25, 2020 at 04:05:38PM -0600, Rob Herring wrote: > > The 'adi,adxl345' definition is a duplicate as there's a full binding in: > > Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml > > > > The trivial-devices binding doesn't capture that 'adi,adxl346' has a > > fallback compatible 'adi,adxl345', so let's add it to adi,adxl345.yaml. > > > > Cc: Michael Hennerich > > Cc: Jonathan Cameron > > Cc: Hartmut Knaack > > Cc: Lars-Peter Clausen > > Cc: Peter Meerwald-Stadler > > Cc: linux-iio@vger.kernel.org > > Signed-off-by: Rob Herring > > --- > > .../devicetree/bindings/iio/accel/adi,adxl345.yaml | 10 +++++++--- > > Documentation/devicetree/bindings/trivial-devices.yaml | 4 ---- > > 2 files changed, 7 insertions(+), 7 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml > > index c602b6fe1c0c..d124eba1ce54 100644 > > --- a/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml > > +++ b/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml > > @@ -17,9 +17,13 @@ description: | > > > > properties: > > compatible: > > - enum: > > - - adi,adxl345 > > - - adi,adxl375 > > + oneOf: > > + - items: > > + - const: adi,adxl346 > > + - const: adi,adxl345 > > + - enum: > > + - adi,adxl345 > > + - adi,adxl375 > > I assume it is my schema understanding that is poor. > But I cannot parse the above. > > The mix of items, enum and const confuses me. compatible can be one of 3 possibilities: "adi,adxl346", "adi,adxl345" "adi,adxl345" "adi,adxl375" For a single entry, 'items' can be omitted. > I guess that if I am confused then others may end in the same situation. > Can we improve readability here or amybe add a comment? example-schema.yaml explains this to some extent. I'd rather improve that. Rob