linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Lokesh Vutla <lokeshvutla@ti.com>
Cc: Tero Kristo <t-kristo@ti.com>, Nishanth Menon <nm@ti.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Keerthy <j-keerthy@ti.com>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	Device Tree Mailing List <devicetree@vger.kernel.org>,
	Linux ARM Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 5/6] dt-bindings: pinctrl: k3: Introduce pinmux definitions for J721E
Date: Mon, 26 Aug 2019 06:25:47 -0500	[thread overview]
Message-ID: <CAL_JsqKpWhmKJUEWD-hKzmxLnHG4VVZbFR04BeQevP0zOoHKiw@mail.gmail.com> (raw)
In-Reply-To: <da0286cb-8e4c-e12c-240c-b6de72bdd0ee@ti.com>

On Mon, Aug 26, 2019 at 5:27 AM Lokesh Vutla <lokeshvutla@ti.com> wrote:
>
> Hi Rob,
>
> On 22/08/19 2:32 AM, Rob Herring wrote:
> > On Fri, Aug 09, 2019 at 01:59:46PM +0530, Lokesh Vutla wrote:
> >> Add pinctrl macros for J721E SoC. These macro definitions are
> >> similar to that of AM6, but adding new definitions to avoid
> >> any naming confusions in the soc dts files.
> >>
> >> Acked-by: Nishanth Menon <nm@ti.com>
> >> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> >> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> >> ---
> >>  include/dt-bindings/pinctrl/k3.h | 3 +++
> >>  1 file changed, 3 insertions(+)
> >>
> >> diff --git a/include/dt-bindings/pinctrl/k3.h b/include/dt-bindings/pinctrl/k3.h
> >> index 45e11b6170ca..499de6216581 100644
> >> --- a/include/dt-bindings/pinctrl/k3.h
> >> +++ b/include/dt-bindings/pinctrl/k3.h
> >> @@ -32,4 +32,7 @@
> >>  #define AM65X_IOPAD(pa, val, muxmode)               (((pa) & 0x1fff)) ((val) | (muxmode))
> >>  #define AM65X_WKUP_IOPAD(pa, val, muxmode)  (((pa) & 0x1fff)) ((val) | (muxmode))
> >>
> >> +#define J721E_IOPAD(pa, val, muxmode)               (((pa) & 0x1fff)) ((val) | (muxmode))
> >> +#define J721E_WKUP_IOPAD(pa, val, muxmode)  (((pa) & 0x1fff)) ((val) | (muxmode))
> >
> > checkpatch reports a parentheses error:         (((pa) & 0x1fff) ((val) | (muxmode)))
>
> This was left intentionally as this macro is giving out two entries in DT like
> below:
>
>         pinctrl-single,pins = <
>                 J721E_IOPAD(0x0, PIN_INPUT, 7)
>         >;
>
> comes out as
>
>         pinctrl-single,pins = <
>                 0x0 (PIN_INPUT | 7)
>         >;
>
> If parenthesis are added for the whole macro, the following build error occurs:
>   DTC     arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dtb
> Error: arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts:41.24-25 syntax error
> FATAL ERROR: Unable to parse input tree

Okay, NM.

Acked-by: Rob Herring <robh@kernel.org>

  reply	other threads:[~2019-08-26 11:26 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-09  8:29 [PATCH 0/6] arm64: dts: ti: k3-j721e: Add gpio nodes Lokesh Vutla
2019-08-09  8:29 ` [PATCH 1/6] dt-bindings: gpio: davinci: Add new compatible for J721E SoCs Lokesh Vutla
2019-08-09 10:55   ` Keerthy
2019-08-15  7:46   ` Linus Walleij
2019-08-09  8:29 ` [PATCH 2/6] arm64: dts: ti: k3-j721e: Add gpio nodes in main domain Lokesh Vutla
2019-08-09 14:53   ` Keerthy
2019-08-09  8:29 ` [PATCH 3/6] arm64: dts: ti: k3-j721e: Add gpio nodes in wakeup domain Lokesh Vutla
2019-08-09 14:54   ` Keerthy
2019-08-09  8:29 ` [PATCH 4/6] arm64: dts: ti: k3-j721e-common-proc-board: Disable unused gpio modules Lokesh Vutla
2019-08-09 14:55   ` Keerthy
2019-08-09  8:29 ` [PATCH 5/6] dt-bindings: pinctrl: k3: Introduce pinmux definitions for J721E Lokesh Vutla
2019-08-21 21:02   ` Rob Herring
2019-08-26 10:26     ` Lokesh Vutla
2019-08-26 11:25       ` Rob Herring [this message]
2019-08-09  8:29 ` [PATCH 6/6] arm64: dts: k3-j721e: Add gpio-keys on common processor board Lokesh Vutla
2019-08-09 14:56   ` Keerthy
2019-08-20 12:49 ` [PATCH 0/6] arm64: dts: ti: k3-j721e: Add gpio nodes Lokesh Vutla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAL_JsqKpWhmKJUEWD-hKzmxLnHG4VVZbFR04BeQevP0zOoHKiw@mail.gmail.com \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=j-keerthy@ti.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=lokeshvutla@ti.com \
    --cc=nm@ti.com \
    --cc=t-kristo@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).