From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFF2BC2D0F1 for ; Tue, 31 Mar 2020 14:39:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B6EF820848 for ; Tue, 31 Mar 2020 14:39:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585665554; bh=VQTYjDLJpBPL64v+KHcwfSavLEUmQ5VPbYuKeDQvfh4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=lQD5llSVIOtg4GBJ6sNx/NULIUb2QXFtaKHmJ5TF30sFGSuNEfvBtxl7fx9uibFlr UbNWY56Mdr7RGgsKWuSF3WyiBp2sNMDwVTIfD/nH1fqNFmFaADId4M66U7g2uLCWcK 5rr9mVPAxjbgFmedsSbNcvLYneAHJAFkbBENyWrk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730935AbgCaOjO (ORCPT ); Tue, 31 Mar 2020 10:39:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:52704 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726194AbgCaOjN (ORCPT ); Tue, 31 Mar 2020 10:39:13 -0400 Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B4A0F214D8; Tue, 31 Mar 2020 14:39:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585665552; bh=VQTYjDLJpBPL64v+KHcwfSavLEUmQ5VPbYuKeDQvfh4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=w9kKXD8z4sqI86PU33XbHmfq5R7o1rl1Yc6oUOAz42cwHppv6UAYyiBVNzHr/8rGq fiuijzJ4syHgX49+YFivKcsWhdJV6fv/bOG69I3vdo0Lq1npTDVuNQt+ItarZp4b9G a/bP28cpaoxY9yg7N1tSpyTZfOjD00o0nNDF4FO0= Received: by mail-qk1-f175.google.com with SMTP id l25so23220051qki.7; Tue, 31 Mar 2020 07:39:12 -0700 (PDT) X-Gm-Message-State: ANhLgQ1Yn4A9Q6+UE+Fanv4lnS9wOsS2mOqlYHd34dkABj36/5Rng+QK 5l9WpzStfcaqEjMA1sRPag/9oA3L9MsbAp5F3A== X-Google-Smtp-Source: ADFU+vs96kIPVk/bUhQUvXuwHTzxBhEjf4smiGd+iZOn7jyc5rfIytLi140jinW+le6E+iSeEnGKe3qbfJEIB3it89g= X-Received: by 2002:a37:aa92:: with SMTP id t140mr4802134qke.119.1585665551704; Tue, 31 Mar 2020 07:39:11 -0700 (PDT) MIME-Version: 1.0 References: <20200325220542.19189-1-robh@kernel.org> <20200325220542.19189-5-robh@kernel.org> In-Reply-To: From: Rob Herring Date: Tue, 31 Mar 2020 08:39:00 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 4/4] dt-bindings: Add missing 'additionalProperties: false' To: Masahiro Yamada Cc: DTML , Linux Kernel Mailing List , Bartosz Golaszewski , Bjorn Andersson , Brian Masney , Daniel Lezcano , "David S. Miller" , Guillaume La Roque , Hartmut Knaack , Jonathan Cameron , Kevin Hilman , Lars-Peter Clausen , Lee Jones , Liam Girdwood , Linus Walleij , Mark Brown , Mauro Carvalho Chehab , Michael Hennerich , Neil Armstrong , Peter Meerwald-Stadler , Stephen Boyd , Thomas Gleixner , Zhang Rui , dri-devel , "open list:ARM/Amlogic Meson..." , linux-arm-kernel , linux-arm-msm , linux-clk , "open list:GPIO SUBSYSTEM" , "open list:IIO SUBSYSTEM AND DRIVERS" , Linux Media Mailing List , Linux PM mailing list , Networking Content-Type: text/plain; charset="UTF-8" Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, Mar 30, 2020 at 2:38 AM Masahiro Yamada wrote: > > Hi Rob, > > On Mon, Mar 30, 2020 at 4:09 PM Masahiro Yamada wrote: > > > > On Thu, Mar 26, 2020 at 7:06 AM Rob Herring wrote: > > > > > > Setting 'additionalProperties: false' is frequently omitted, but is > > > important in order to check that there aren't extra undocumented > > > properties in a binding. > > > > > > Ideally, we'd just add this automatically and make this the default, but > > > there's some cases where it doesn't work. For example, if a common > > > schema is referenced, then properties in the common schema aren't part > > > of what's considered for 'additionalProperties'. Also, sometimes there > > > are bus specific properties such as 'spi-max-frequency' that go into > > > bus child nodes, but aren't defined in the child node's schema. > > > > > > So let's stick with the json-schema defined default and add > > > 'additionalProperties: false' where needed. This will be a continual > > > review comment and game of wack-a-mole. > > > > > > Signed-off-by: Rob Herring > > > --- > > > > > > > .../devicetree/bindings/gpio/socionext,uniphier-gpio.yaml | 2 ++ > > > > > > You may have already queue this up, but just in case. > > > > Acked-by: Masahiro Yamada > > > > I take back Ack for socionext,uniphier-gpio.yaml > > > > Now "make dt_binding_check" produces a new warning. > > gpio@55000000: 'interrupt-parent' does not match any of the regexes: > 'pinctrl-[0-9]+' > > > This binding uses 'interrupt-parent' > without 'interrupts'. > > Instead, the mapping of the interrupt numbers > is specified by the vendor-specific property > socionext,interrupt-ranges > > > > I cannot add "interrupt-parent: true" because > dt-schema/meta-schemas/interrupts.yaml > has "interrupt-parent: false". > > > Is there any solution? I'd meant to just drop socionext,uniphier-gpio.yaml. Rob