Re: [PATCH 07/14] arm64: dts: qcom: sa8775p: add the Power On device node

From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
	Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH 07/14] arm64: dts: qcom: sa8775p: add the Power On device node
Date: Mon, 20 Mar 2023 11:50:41 +0100	[thread overview]
Message-ID: <CAMRc=McQK+DNZF--wphWp0-vtb_mny5SVMvhUXABubJwCL=vqQ@mail.gmail.com> (raw)
In-Reply-To: <0fc9ba28-cb78-67fb-4cef-f786c345bc19@linaro.org>

On Tue, Mar 14, 2023 at 9:25 PM Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>
>
>
> On 14.03.2023 19:30, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >
> > Add the PON node to PMIC #0 for sa8775p platforms.
> >
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > ---
> >  arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
> > index 77e2515a7ab9..5d73212fbd16 100644
> > --- a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
> > @@ -12,6 +12,13 @@ pmk8775_0: pmic@0 {
> >               reg = <0x0 SPMI_USID>;
> >               #address-cells = <1>;
> >               #size-cells = <0>;
> > +
> > +             pmk8775_0_pon: pon@1200 {
> > +                     compatible = "qcom,pmk8350-pon";
> > +                     reg = <0x1200>, <0x800>;
> reg-names = "hlos", "pbs"
>
> Also, are you sure hlos shouldn't be @1300?
>

Nope, that's the right one here.

Bart

> Konrad
> > +                     mode-recovery = <0x1>;
> > +                     mode-bootloader = <0x2>;
> > +             };
> >       };
> >
> >       pmk8775_1: pmic@2 {