From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
"Joel Becker" <jlbec@evilplan.org>,
"Christoph Hellwig" <hch@lst.de>,
"Jonathan Corbet" <corbet@lwn.net>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Kent Gibson" <warthog618@gmail.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
linux-doc <linux-doc@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Bartosz Golaszewski" <bgolaszewski@baylibre.com>
Subject: Re: [PATCH 5/8] lib: bitmap: remove the 'extern' keyword from function declarations
Date: Sat, 30 Jan 2021 21:25:08 +0100 [thread overview]
Message-ID: <CAMRc=Md74KunuEvVsofn9cqcoKEqprepKadPdZA+JV_GMH7X7g@mail.gmail.com> (raw)
In-Reply-To: <YBQw3+K/6GDPK5xa@smile.fi.intel.com>
On Fri, Jan 29, 2021 at 4:59 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Fri, Jan 29, 2021 at 02:46:21PM +0100, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> >
> > The 'extern' keyword doesn't have any benefits in header files. Remove it.
>
> > +int __bitmap_equal(const unsigned long *bitmap1,
> > + const unsigned long *bitmap2, unsigned int nbits);
>
> Why not
>
> int __bitmap_equal(const unsigned long *bitmap1, const unsigned long *bitmap2,
> unsigned int nbits);
>
> and so on?
>
> It's even in 80 limit.
>
I feel like this is purely a matter of taste. No rules define exactly
how the lines should be broken. I prefer the longer part to be below,
it just looks better to my eyes.
Bart
next parent reply other threads:[~2021-01-30 20:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210129134624.9247-1-brgl@bgdev.pl>
[not found] ` <20210129134624.9247-6-brgl@bgdev.pl>
[not found] ` <YBQw3+K/6GDPK5xa@smile.fi.intel.com>
2021-01-30 20:25 ` Bartosz Golaszewski [this message]
2021-02-01 10:19 ` [PATCH 5/8] lib: bitmap: remove the 'extern' keyword from function declarations Andy Shevchenko
[not found] ` <20210129134624.9247-9-brgl@bgdev.pl>
[not found] ` <YBQwUkQz3LrG5G4i@smile.fi.intel.com>
2021-01-30 20:37 ` [PATCH 8/8] gpio: sim: new testing module Bartosz Golaszewski
2021-01-31 0:43 ` Kent Gibson
2021-02-01 8:37 ` Bartosz Golaszewski
2021-02-01 10:28 ` Andy Shevchenko
2021-02-01 10:59 ` Bartosz Golaszewski
2021-02-01 12:49 ` Andy Shevchenko
2021-02-01 12:53 ` Bartosz Golaszewski
2021-02-01 13:30 ` Andy Shevchenko
2021-01-30 21:20 ` [PATCH 0/8] gpio: implement the configfs " Uwe Kleine-König
2021-02-01 8:37 ` Bartosz Golaszewski
2021-02-01 9:24 ` Uwe Kleine-König
2021-02-01 12:50 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMRc=Md74KunuEvVsofn9cqcoKEqprepKadPdZA+JV_GMH7X7g@mail.gmail.com' \
--to=brgl@bgdev.pl \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=corbet@lwn.net \
--cc=geert@linux-m68k.org \
--cc=hch@lst.de \
--cc=jlbec@evilplan.org \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).