linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v1 1/1] gpiolib: Split property name from the warning message
Date: Wed, 29 Mar 2023 13:37:16 +0200	[thread overview]
Message-ID: <CAMRc=MeBbdHYV-_2utMBVy-31GzGbWM8GUD9RRV8vYQ3OzHWrA@mail.gmail.com> (raw)
In-Reply-To: <20230321135310.73153-1-andriy.shevchenko@linux.intel.com>

On Tue, Mar 21, 2023 at 2:52 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> Split property name from the warning message to make object file
> shorter. The linker will use the single copy of it. It's fine
> to pass a pointer to the printing function since it's a slow path
> anyway.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/gpio/gpiolib.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index 51a19cbe39a4..112d99a5eec4 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -403,8 +403,8 @@ static int gpiochip_set_names(struct gpio_chip *chip)
>          * gpiochips.
>          */
>         if (count <= chip->offset) {
> -               dev_warn(dev, "gpio-line-names too short (length %d), cannot map names for the gpiochip at offset %u\n",
> -                        count, chip->offset);
> +               dev_warn(dev, "%s too short (length %d), cannot map names for the gpiochip at offset %u\n",
> +                        "gpio-line-names", count, chip->offset);
>                 return 0;
>         }
>
> --
> 2.40.0.1.gaa8946217a0b
>

I'd say being able to grep the code easily for messages is more
important than saving a couple bytes here?

Bart

  reply	other threads:[~2023-03-29 11:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-21 13:53 [PATCH v1 1/1] gpiolib: Split property name from the warning message Andy Shevchenko
2023-03-29 11:37 ` Bartosz Golaszewski [this message]
2023-03-29 13:55   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMRc=MeBbdHYV-_2utMBVy-31GzGbWM8GUD9RRV8vYQ3OzHWrA@mail.gmail.com' \
    --to=brgl@bgdev.pl \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).