From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C35EC433EF for ; Mon, 20 Sep 2021 14:14:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D8B6610F9 for ; Mon, 20 Sep 2021 14:14:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232720AbhITOPr (ORCPT ); Mon, 20 Sep 2021 10:15:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230079AbhITOPq (ORCPT ); Mon, 20 Sep 2021 10:15:46 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6D27C061574 for ; Mon, 20 Sep 2021 07:14:19 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id dj4so6123055edb.5 for ; Mon, 20 Sep 2021 07:14:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=w+1mwWxzK4KqPX143QbpAuBXZDwVj/xzhRskL9OvgsI=; b=4wd6xFMuLjiLqQAnPS2s8hoBkL9vGmwNlV/Y0ODuU+VWqUrY4jEaw3vzHDW13gkzJ9 DeNHwp9zzF8fyt5cnxlTH1+d3ewGO3iP+XtkW3vr9xzjlSU5e38FXBx3A+5vo8xrIlcB 2eg1jrsnsjn91FP7ca0vsHYHnE+4l6l6AySKRif3x5Cs9+pFkCfy7ADLACZrFXmr4ctM hGnQ1xrzW1RMdVKdu0DUuFjZswJ+xT0Z8LC2nqh8zkmFl/xlfJ9Wt1+8MQadEaTeWx8D lmFl+THd0d58GFedVtD1kA66JSines9gaAYpP7CHBAWQderneilKLEwgaD7fIQeooeYY OgOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=w+1mwWxzK4KqPX143QbpAuBXZDwVj/xzhRskL9OvgsI=; b=tImAZMns/eKK/AR4p2eOldJUMzTc0yfGjXa//v6DXR5iNEBnFHPqV1A3vOBS4uVRhx 8EyCWnceB0j54B0k7j/nKJbkRs1hoy75w6zDosTftlTamn7n3YkKvp7qfKFLQrNVjIXt QWLQqE96rHDlgAgp4yQhWBMvCsiQofbZvIlSJy1pZXkFXFe3HDPn+XZyMCeVmsXmOJl7 nfOwFW8mEq2OVGs9hHY3754IBhm5gY3mfpi3MaVp8g7JPDX8fgu1TmnVyioQnBl5sJ+r RnlYIVgs+a8wWKexScW+xBRZWjMX2ud1oB+u47WMewDqoHeGa9BiPNRKqf5PFGVtC1M9 EjdA== X-Gm-Message-State: AOAM533AHSa56ht/Mks8OoUIuQnBbPg1G7f0JH1Gms1N66hzlVxoB8N9 mwVzueCmAthFecpAQG6bWeJnk258wX3PUNE5ao6HBg== X-Google-Smtp-Source: ABdhPJyvsPKS0QY3MEdCKvEQgKrTrMJswAzQzJZL0FUD0kOibwdcAyHh6tj0cjLX2srirSQtTI28RQcRU6LEDqsX020= X-Received: by 2002:a17:906:5586:: with SMTP id y6mr28613764ejp.189.1632147227890; Mon, 20 Sep 2021 07:13:47 -0700 (PDT) MIME-Version: 1.0 References: <20210920140509.5177-1-brgl@bgdev.pl> <20210920140509.5177-3-brgl@bgdev.pl> <20210920140938.GA24424@lst.de> In-Reply-To: <20210920140938.GA24424@lst.de> From: Bartosz Golaszewski Date: Mon, 20 Sep 2021 16:13:37 +0200 Message-ID: Subject: Re: [PATCH v5 2/8] configfs: use BIT() for internal flags To: Christoph Hellwig Cc: Joel Becker , Shuah Khan , Linus Walleij , Andy Shevchenko , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Geert Uytterhoeven , Kent Gibson , Jonathan Corbet , Greg Kroah-Hartman , Al Viro , Jack Winch , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , linux-doc Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, Sep 20, 2021 at 4:09 PM Christoph Hellwig wrote: > > On Mon, Sep 20, 2021 at 04:05:03PM +0200, Bartosz Golaszewski wrote: > > For better readability and maintenance: use the BIT() macro for flag > > definitions. > > NAK. BIT() is the stupidest macro in the kernel and shall not be used > ever. And I'm pretty sure we had this discussion a few times. Yep and the general consensus among the kernel developers still is to use the BIT() macro. Even for this patch there were three separate comments from high-profile developers to use BIT(). Also: this really is bikeshedding at this point, given that the core subject of this series is elsewhere. Bart