From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A677FC2D0BF for ; Thu, 5 Dec 2019 09:23:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 780AB24654 for ; Thu, 5 Dec 2019 09:23:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="MMlHVQzj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729068AbfLEJXG (ORCPT ); Thu, 5 Dec 2019 04:23:06 -0500 Received: from mail-oi1-f194.google.com ([209.85.167.194]:36579 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726177AbfLEJXF (ORCPT ); Thu, 5 Dec 2019 04:23:05 -0500 Received: by mail-oi1-f194.google.com with SMTP id c16so2119503oic.3 for ; Thu, 05 Dec 2019 01:23:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=2+ymVaiKpxCGbb6mLFBeFKK14AzTNra8/JGSC81CVMs=; b=MMlHVQzjz8BNYnpFpiDs0UZPUGaTU2TrVR0oiTh126oHkRd3AnBTqVTxB0eqFevSHE uvkikS9S3YhLrdQrYkkl/bCSUrtcejYVB3JJO2XbcQ7MYu8m4AZYS0lSmxxNiTPbLzMn nXUU7sP4YagfcJmxGE4f0bEubpdanZ3jz3gV3eEQ4PcyE5jQqaG75Ey955ZOAMymako3 9ONlwtVwrX9v02HlpHDiU8pdZQmbEK9nRiAFFVkR4ZHNB9/8UccCXy9m56Mjfc0jRXD/ b6kgwNvw5Mmif95Df/GoIY23DCIg3D8iLnKaQUL6k2xqJhZDk5BgkfBggDGe2BBVH+KB Ez3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=2+ymVaiKpxCGbb6mLFBeFKK14AzTNra8/JGSC81CVMs=; b=spoXm0pLUIorNWeGQXJ3wtyeVsz9W+foxUOOS1ho8p7z3qXxwXN8pOWN8lTlG8I8rH IEriIsNEuS+pqcvo2r95MX6T+F51nE2Eh3tx0GfLQ1Ltb/kNp6KY3hMFT3UDcI2b3ku3 7EMg4oR2dcRfEbuVzX5GoEMb8wxuLYAsZWZ9SEvTXx+kLDj+wzu555q63M3Avo1iaNrQ wTrJig+OPdvx78sfU9qZHo4g9Q5jTHTJ14YrrL1oEmtOiNX5mpR+I2v/ImrEL9UWW7RF 4U5SsppFAQ/xZBMT3N1M1DS19rGg9ej2AsZYDDoW0V3Eba6prqxu2xqcZOjmjUX3d365 HaWg== X-Gm-Message-State: APjAAAWDfNb+QVG+J06EeA6rotKPMaTQTLMfQL4acXP2UqrHa08nhsNj NaINHy1qUwgSIyNAotp8UPzxyundDCKuMK/3oB7oQQ== X-Google-Smtp-Source: APXvYqzluMSEyFEWEKRhdKW5xwVBPzAcJZFuTB7zoWh9ETQZ9ypQXyOujHC2HKRdnKfUdK5vQuhu+X0cBR17KlbGyAQ= X-Received: by 2002:aca:4e90:: with SMTP id c138mr6418889oib.147.1575537784750; Thu, 05 Dec 2019 01:23:04 -0800 (PST) MIME-Version: 1.0 References: <1575433106-16171-1-git-send-email-peng.fan@nxp.com> <20191204072422.vfo3mrrcaav75jv4@pengutronix.de> <20191204184754.5oj2xoem2v3544rx@pengutronix.de> In-Reply-To: <20191204184754.5oj2xoem2v3544rx@pengutronix.de> From: Bartosz Golaszewski Date: Thu, 5 Dec 2019 10:22:53 +0100 Message-ID: Subject: Re: [PATCH v2 1/2] gpio: mvebu: use platform_irq_count To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= Cc: Peng Fan , "rjui@broadcom.com" , "linus.walleij@linaro.org" , "f.fainelli@gmail.com" , "sbranden@broadcom.com" , "thierry.reding@gmail.com" , "robh@kernel.org" , "bcm-kernel-feedback-list@broadcom.com" , dl-linux-imx , "linux-gpio@vger.kernel.org" , "linux-pwm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Alice Guo , Sascha Hauer Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org =C5=9Br., 4 gru 2019 o 19:47 Uwe Kleine-K=C3=B6nig napisa=C5=82(a): > > On Wed, Dec 04, 2019 at 05:33:04PM +0100, Bartosz Golaszewski wrote: > > =C5=9Br., 4 gru 2019 o 08:24 Uwe Kleine-K=C3=B6nig > > napisa=C5=82(a): > > > > > > On Wed, Dec 04, 2019 at 04:20:41AM +0000, Peng Fan wrote: > > > > From: Peng Fan > > > > > > > > platform_irq_count() is the more generic way (independent of > > > > device trees) to determine the count of available interrupts. So > > > > use this instead. > > > > > > > > As platform_irq_count() might return an error code (which > > > > of_irq_count doesn't) some additional handling is necessary. > > > > > > > > Signed-off-by: Peng Fan > > > Reviewed-and-Commit-Log-Provided-by: Uwe Kleine-K=C3=B6nig > > > > This is not a valid tag, but I take it as Suggested-by and Reviewed-by.= :) > > If you care about the validity of such tags, I suggest you take a look > at the output of > > $ git rev-list v4.0..v5.4 | while read rev; do git cat-file commi= t $rev; done | sed -n 's/ *\(.*-by\):.*/\1/p' | sort | uniq -c | sort -n > > (which finds all tags used between 4.0 and 5.4 with its usage count). > > A few of the tags (admittedly with low usage count :-) included there are= : > > Badly-reviewed-by > Bonus-points-awarded-by > Compile-tested and Reviewed-by > Enthusiastically-Acked-by > Mea-culpa-by > \o/-by > Brown-paper-bag-by > > Best regards > Uwe I am well aware of this and there has been a discussion on LKML some time ago (I can no longer find it though) about introducing stricter rules for tags. I don't remember the outcome either though. Bart