From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: Navid Emamdoost <navid.emamdoost@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-gpio <linux-gpio@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Navid Emamdoost <emamd001@umn.edu>, Qiushi Wu <wu000273@umn.edu>,
Kangjie Lu <kjlu@umn.edu>,
smccaman@umn.edu
Subject: Re: [PATCH] gpio: rcar: handle pm_runtime_get_sync failure case
Date: Tue, 23 Jun 2020 10:50:24 +0200 [thread overview]
Message-ID: <CAMpxmJU3aivxkjpWQDExnnW_AOF4Unefrb6xgF2fqrzaw-hi0w@mail.gmail.com> (raw)
In-Reply-To: <20200605024919.56177-1-navid.emamdoost@gmail.com>
pt., 5 cze 2020 o 04:49 Navid Emamdoost <navid.emamdoost@gmail.com> napisał(a):
>
> Calling pm_runtime_get_sync increments the counter even in case of
> failure, causing incorrect ref count. Call pm_runtime_put if
> pm_runtime_get_sync fails.
>
> Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
> ---
> drivers/gpio/gpio-rcar.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c
> index 7284473c9fe3..eac1582c70da 100644
> --- a/drivers/gpio/gpio-rcar.c
> +++ b/drivers/gpio/gpio-rcar.c
> @@ -250,8 +250,10 @@ static int gpio_rcar_request(struct gpio_chip *chip, unsigned offset)
> int error;
>
> error = pm_runtime_get_sync(p->dev);
> - if (error < 0)
> + if (error < 0) {
> + pm_runtime_put(p->dev);
> return error;
> + }
>
> error = pinctrl_gpio_request(chip->base + offset);
> if (error)
> --
> 2.17.1
>
Hi Navid!
This doesn't apply to current master. I think the previous version got
applied. Could you please rebase?
Bart
prev parent reply other threads:[~2020-06-23 8:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 2:49 [PATCH] gpio: rcar: handle pm_runtime_get_sync failure case Navid Emamdoost
2020-06-10 8:52 ` Linus Walleij
2020-06-10 12:04 ` Geert Uytterhoeven
2020-06-17 7:26 ` Geert Uytterhoeven
2020-06-17 7:40 ` [PATCH v2] " Navid Emamdoost
2020-06-17 7:43 ` Geert Uytterhoeven
2020-06-22 16:54 ` Bartosz Golaszewski
2020-06-22 19:00 ` Geert Uytterhoeven
2020-06-17 7:41 ` [PATCH] " Navid Emamdoost
2020-06-23 8:50 ` Bartosz Golaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMpxmJU3aivxkjpWQDExnnW_AOF4Unefrb6xgF2fqrzaw-hi0w@mail.gmail.com \
--to=bgolaszewski@baylibre.com \
--cc=emamd001@umn.edu \
--cc=kjlu@umn.edu \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=navid.emamdoost@gmail.com \
--cc=smccaman@umn.edu \
--cc=wu000273@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).