From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1151BC433E9 for ; Mon, 4 Jan 2021 15:00:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E11CA2250F for ; Mon, 4 Jan 2021 15:00:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727170AbhADPAd (ORCPT ); Mon, 4 Jan 2021 10:00:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726692AbhADPAd (ORCPT ); Mon, 4 Jan 2021 10:00:33 -0500 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51FE1C061795 for ; Mon, 4 Jan 2021 06:59:53 -0800 (PST) Received: by mail-ej1-x62e.google.com with SMTP id g20so37206041ejb.1 for ; Mon, 04 Jan 2021 06:59:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Y1GDTPXFza3htMu5VSeDCpCXqmyO9V6AlVTJM1pcQqE=; b=BHcfEm1NmH48lFrueHkUvZCdPGmAbtG4nX8bUdBWK4kYRC+fmKonryjnONBPngR3QG KATLbWKnOzri7uNBERQNj/BWmkdiYfIPBlauI2zXZ55OtiuPHDb7laagpxAuDLG19icr Pkbqgd7l4RTUtMTFfamT2/NrN1M0dWDjBYecPnw8UPuneIW1vHevQvSxxzl0bGp8CIdi yM+6GMnrK+DPz49aXK88M+xDcky9vtdgkzpC7wxaCPU6jh9clwvrJrBTZ/bql+G1iLTq CwOs9XZ3RuwtSD/N53xQDYC+vQihAt/0+N8NKEvO4+xRxKTy4vgwKCnGErmhSwTgrF+o z6lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Y1GDTPXFza3htMu5VSeDCpCXqmyO9V6AlVTJM1pcQqE=; b=PZB6artzd/9RrstQitNUpANoREYneaL+OFtMIUIgid8MWFXNqw54Tg3/yo25J9pN0r Rs1Zpv//qaFfkzHCYY/iPM4ZgHORRfwots1/Vj92s3ANheC5c4GiFUm37tyUCDR6uW7e JteNCwYWcG34AzBf9gl4S8v1B1kYXYAlDkXkCfBzuoBpc7q3ZGsLEWU4oAv9MkUbCx0g 6aFgmq0jEh/ZydeIl5d8goxffcSgg2e5Dj3U6LgRm1ZMIfppmE4ums0RH/icORKZ2IoV GtOmD3cYJPRJcrpbt+C+bcMqvVdpvkwja/aj1So673KiafoA9A6PJ8lChs9RfNKWqy+h gsQQ== X-Gm-Message-State: AOAM5308o5QeiuD5PmD6XUuVej5uuCWJ+TK2OfLOAGvXfV6+fIRvi0np oo1AcN8HjuRmQbZP9wiYHUhkr0d7TVpJH13ZjTGlDA== X-Google-Smtp-Source: ABdhPJzMVwvlAMPxcRJluuJeDXEOdW/jUGVJODxXJnzChF5bKgC96F8d2YHfrgZopHuMY7o7SZUgr9JxF6sWVvgAdEw= X-Received: by 2002:a17:906:3a55:: with SMTP id a21mr67806851ejf.516.1609772392127; Mon, 04 Jan 2021 06:59:52 -0800 (PST) MIME-Version: 1.0 References: <20201228200618.58716-1-andriy.shevchenko@linux.intel.com> <20210104143302.GZ4077@smile.fi.intel.com> In-Reply-To: <20210104143302.GZ4077@smile.fi.intel.com> From: Bartosz Golaszewski Date: Mon, 4 Jan 2021 15:59:41 +0100 Message-ID: Subject: Re: [PATCH v1 1/3] gpiolib: Follow usual pattern for gpiod_remove_lookup_table() call To: Andy Shevchenko Cc: Linus Walleij , linux-gpio , Jean Delvare , Wolfram Sang , linux-i2c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, Jan 4, 2021 at 3:32 PM Andy Shevchenko wrote: > > On Mon, Jan 04, 2021 at 03:24:47PM +0100, Bartosz Golaszewski wrote: > > On Mon, Dec 28, 2020 at 9:06 PM Andy Shevchenko > > wrote: > > > > > > The usual pattern for the remove calls, like gpiod_remove_lookup_tabl= e(), > > > is to be NULL-aware, i.o.w. become a no-op whenever parameter is NULL= . > > > Update gpiod_remove_lookup_table() call to follow this pattern. > > > > > > Signed-off-by: Andy Shevchenko > > > --- > > > drivers/gpio/gpiolib.c | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c > > > index b02cc2abd3b6..611d6ea82d75 100644 > > > --- a/drivers/gpio/gpiolib.c > > > +++ b/drivers/gpio/gpiolib.c > > > @@ -3460,6 +3460,10 @@ EXPORT_SYMBOL_GPL(gpiod_add_lookup_table); > > > */ > > > void gpiod_remove_lookup_table(struct gpiod_lookup_table *table) > > > { > > > + /* Nothing to remove */ > > > + if (!table) > > > + return; > > > + > > > mutex_lock(&gpio_lookup_lock); > > > > > > list_del(&table->list); > > > -- > > > 2.29.2 > > > > > > > Applied, thanks! > > Thanks. Though I think it can be also applied to I=E6=B6=8E tree since de= pendency? > Any tags / immutable branch for Wolfram? > > -- > With Best Regards, > Andy Shevchenko > > Oops I assumed this is independent. In that case: Acked-by: Bartosz Golaszewski Wolfram, please take it through the i2c tree. Bartosz