From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A24DC433F5 for ; Wed, 22 Sep 2021 10:14:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7155E611C9 for ; Wed, 22 Sep 2021 10:14:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234855AbhIVKPq (ORCPT ); Wed, 22 Sep 2021 06:15:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234606AbhIVKPc (ORCPT ); Wed, 22 Sep 2021 06:15:32 -0400 Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [IPv6:2607:f8b0:4864:20::729]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02055C0613E3 for ; Wed, 22 Sep 2021 03:13:19 -0700 (PDT) Received: by mail-qk1-x729.google.com with SMTP id f130so7777009qke.6 for ; Wed, 22 Sep 2021 03:13:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/8yX95pvcRtgj3+l1Dvc2BnLTTvMZgpjXa7orH/cvhg=; b=etHqq3yE5G1MARQ1NlzqfwXJlqqEhqQoEABGLp+av+czxO4aLVAZMw8yaWnCbCvUxU 8LqlB7xjt3zf+LpRUwpIpyxAyB7N+KCXHUr4j+9+YP5qSON4qpZD2EqEoShlIYXM+cdI DkmR+pibfCSMPKZ+9pYdTLT9f9qtE3bsDpZYg1CFGDuUly2EVYv1ZYB7B2KWPE4OGx16 epZBiX4Dqr8NCDcGym4MGZPOYk07tfphc4fTNEvZ6w0d0voC8yAW7IbNFrfGcckEO4Gz fDdIzdOUptQp/9jIFSb/qGngTTGaMhKCoQkMP2afUVT11A2qmV37sjQyT3OGMIGjkku6 TkgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/8yX95pvcRtgj3+l1Dvc2BnLTTvMZgpjXa7orH/cvhg=; b=TVCJjpftqBS28IqnPGhRQ1VKG8F6tgAvvw9POqd0F+kykQ4YBy2s6qobbSmSfho9sY GWq2PkRYyHB1hvf9fVfvVG4W+9xVQ2CpcPWrDn6eowWLbyE7nxqD3H8pIurXpYXeghbL /zPcQfq+P7K0kMGgq7as0b8f+zHpmB6ELGoKgl6VcdMc8zDS8GCRfHp2B2e1AD8gNnZ/ w4u0vmK7a4SQOxFhS7efrO/JVe8iySxu2I/Z2tdKrEz2aLZIGjDq8oQI4I7T0ZTWiR20 o+1PdRkkmSrd2plaLqRiSRji36SJU6P6GFe72Pif7r1sM+awWea8Ylp/h9SseqBT2GDF kTnw== X-Gm-Message-State: AOAM5335EL7VwrB0QDbdOZOLJcYQGNQsLV+SDqaR8iP1Ne4BdDqu9hDA KMnlWDBGVIWP8E5ZO6lR6oVnldal79V6/HDG9hqUExvtFMsMHg== X-Google-Smtp-Source: ABdhPJyeXorOUs+PriO6Ij8JtFcEvm0woYrm0FGYBDFtCr3yp19a55RbDGTKLsev+CLR25fXYJd2n2dDEfcHqDZJLDc= X-Received: by 2002:a25:cbc3:: with SMTP id b186mr42825883ybg.199.1632305598057; Wed, 22 Sep 2021 03:13:18 -0700 (PDT) MIME-Version: 1.0 References: <20210916164641.135008-1-krzysztof.kozlowski@canonical.com> <20210916164641.135008-2-krzysztof.kozlowski@canonical.com> In-Reply-To: <20210916164641.135008-2-krzysztof.kozlowski@canonical.com> From: Bartosz Golaszewski Date: Wed, 22 Sep 2021 12:13:07 +0200 Message-ID: Subject: Re: [PATCH 2/2] gpio: tps65218: drop unneeded MODULE_ALIAS To: Krzysztof Kozlowski Cc: Linus Walleij , linux-gpio , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, Sep 16, 2021 at 6:46 PM Krzysztof Kozlowski wrote: > > The MODULE_DEVICE_TABLE already creates proper alias for platform > driver. Having another MODULE_ALIAS causes the alias to be duplicated. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/gpio/gpio-tps65218.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpio/gpio-tps65218.c b/drivers/gpio/gpio-tps65218.c > index 3517debe2b0b..912382be48e1 100644 > --- a/drivers/gpio/gpio-tps65218.c > +++ b/drivers/gpio/gpio-tps65218.c > @@ -230,4 +230,3 @@ module_platform_driver(tps65218_gpio_driver); > MODULE_AUTHOR("Nicolas Saenz Julienne "); > MODULE_DESCRIPTION("GPO interface for TPS65218 PMICs"); > MODULE_LICENSE("GPL v2"); > -MODULE_ALIAS("platform:tps65218-gpio"); > -- > 2.30.2 > Applied, thanks! Bart