From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A8BCC00307 for ; Mon, 9 Sep 2019 08:08:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EA2642086D for ; Mon, 9 Sep 2019 08:08:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="tV4CHDh5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388563AbfIIIIv (ORCPT ); Mon, 9 Sep 2019 04:08:51 -0400 Received: from mail-ot1-f65.google.com ([209.85.210.65]:39229 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727079AbfIIIIv (ORCPT ); Mon, 9 Sep 2019 04:08:51 -0400 Received: by mail-ot1-f65.google.com with SMTP id n7so11590191otk.6 for ; Mon, 09 Sep 2019 01:08:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=gJqsNk537Ee698eaMI/WoUOzxOSMBJRuyaZH39TduDU=; b=tV4CHDh5/x14CjSLzPXNjSrr+KO5ZwGNjsO+eJCUJDD55ojKGrvIW0WwrwhhnPM/Uc M9W7qCVu2FfrQezi90405Ev7XmnTRT0jU/Srfeta7Em2TjWMZ5+DVbFQ5mY5CsF9MkgO 8sZCeSi/jr3WgU3CfycmGdJJuxo/BZIHDR07YGaybbOf/DbBMrK1qgSuMT1ha8gxzcmm n9LV0Nf+cK21w/c5ljuBJYA0pSdgQDFuuVP6lVRnqZb3GeQRJjNVdgurG6XLX14Ydf/E xN+Sda6Fh9zifoRjwGCOsgckLP23ivlvAt51xQ+fWcrSyqbWnRPl1/QBQNWMnJZ9xWmW TLHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=gJqsNk537Ee698eaMI/WoUOzxOSMBJRuyaZH39TduDU=; b=SprFBqYp46oZ7A2ckMr+tCYYlD7ceh+KbaAzePmMdcHHrxUZgt8RJtrLewn7JKVeqG /5PJVD1rkhD+E/VOWL7UyK0fVmB096Sd22A+Laofif6Ng2sPyhvzpZlS3e+dHIrRflap Qsr1cirn5vHHlWmq9tznIfhQ/YZSQS0Wr+crvWwu5tGcXUJUtrvVEKCxlKc0KvtkQgMM RB0gXpKJVOJhpLYh07yFKzwRXmr9Ya6EgyAAiv/I0b6d81QYex2JH/+6A8LmSW5POt2a oEAHwOvO2ICmSbVYoGAzYXIzXNexinWVV60SlaLZHOxlLzZeXiIeNmQUlmAQo2ntfSMz 69bQ== X-Gm-Message-State: APjAAAXIjP1gaux9EUjYyn7/b2vtGP0c93sZnNoht17MCgGdmyHZ3vNi /JkDUhhlijvSjzYT3+Gku1uRF6DuDPP3s4b4wFZptw== X-Google-Smtp-Source: APXvYqxE+jEqaxY/ZswNBiISMkKeCPo7b4iQVVMhabwK63I4ZoYPjGGjobrNUVzpsqIa33svZwabA4fI7Ba4C4w6eBQ= X-Received: by 2002:a9d:5a06:: with SMTP id v6mr17519979oth.250.1568016530212; Mon, 09 Sep 2019 01:08:50 -0700 (PDT) MIME-Version: 1.0 References: <20190904141834.195294-1-weiyongjun1@huawei.com> In-Reply-To: From: Bartosz Golaszewski Date: Mon, 9 Sep 2019 10:08:39 +0200 Message-ID: Subject: Re: [PATCH] gpio: mockup: add missing single_release() To: Linus Walleij Cc: Wei Yongjun , Bamvor Jian Zhang , linux-gpio , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org =C5=9Br., 4 wrz 2019 o 16:54 Bartosz Golaszewski napisa=C5=82(a): > > =C5=9Br., 4 wrz 2019 o 16:00 Wei Yongjun napisa= =C5=82(a): > > > > When using single_open() for opening, single_release() should be > > used instead of seq_release(), otherwise there is a memory leak. > > > > Fixes: 2a9e27408e12 ("gpio: mockup: rework debugfs interface") > > Signed-off-by: Wei Yongjun > > --- > > drivers/gpio/gpio-mockup.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c > > index f1a9c0544e3f..213aedc97dc2 100644 > > --- a/drivers/gpio/gpio-mockup.c > > +++ b/drivers/gpio/gpio-mockup.c > > @@ -309,6 +309,7 @@ static const struct file_operations gpio_mockup_deb= ugfs_ops =3D { > > .read =3D gpio_mockup_debugfs_read, > > .write =3D gpio_mockup_debugfs_write, > > .llseek =3D no_llseek, > > + .release =3D single_release, > > }; > > > > static void gpio_mockup_debugfs_setup(struct device *dev, > > > > > > > > Good catch! > > Reviewed-by: Bartosz Golaszewski > > Linus: can you pick it up for your last pull-requests with fixes for v5.3= ? > > Bart Nevermind - I applied it to my tree and will send it with two other fixes in a PR. Bart