From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF749C433DF for ; Tue, 30 Jun 2020 09:03:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB429206C3 for ; Tue, 30 Jun 2020 09:03:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="HD4AHzV/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731591AbgF3JDR (ORCPT ); Tue, 30 Jun 2020 05:03:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731781AbgF3JDQ (ORCPT ); Tue, 30 Jun 2020 05:03:16 -0400 Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50F97C03E979 for ; Tue, 30 Jun 2020 02:03:16 -0700 (PDT) Received: by mail-qk1-x743.google.com with SMTP id b185so7275055qkg.1 for ; Tue, 30 Jun 2020 02:03:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=csyHqi1dgCFTiTLH92m1pa/01f6/WL6cXgwUlzD9rQs=; b=HD4AHzV/G4h+Qg4Jf13PqCiiixOihB5TxcT0bF1y6ewEADJ9V2spVuaQRlP9dBzy69 5bkx4da1YWTJ8uwLkfjy8PvpO1sydpdbB06U9g6vQz5OXIsN4TdfnWkYqvfrBDxYwkmn GUI8+bmuFxhwVbfF1a7rLPuh6GIbbyUsQ71u6QMWTzEtPC0+K2qOR+LiuX4CruoT8wh9 0isjNHlHsRje9C/Lz2ZcHKbPnlsXC6wSB8e4j1gJaiYKuho9dEg/tk8PBwrSXQsBUzmU euQ7o0Ri3f35NR3vaPCUQMZvv6bTa99Iu1x9WxROMITca1tDD8qVKuHyD9812y0+B0De J+Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=csyHqi1dgCFTiTLH92m1pa/01f6/WL6cXgwUlzD9rQs=; b=AT/TO1vci5HLc5lVynyYvTEE3v3kQn1APCQvaMYIrkpTh/0FMJpOow5aR2N1W/4/by itO/0E+XAD2g/s4B10n97vY+nC2DovrLW48apSQU+nxuvBXl0grZ1028EL+IbPbGqbmM VFtrF8Mrdt9BUJPAEaTDb9U3H7GWqW3uyaIJKEYlzxMjKmkJOunpZgNiTMF9c+Mh68zU ybjRGEEI7tKf6jrIFz1fRsZpDrHwfGGXr1K3FewX395JVWi3/4qOT45pfe6o4wLR6QzR qD0zCIYpAhWCgIbidfB+F1uLFNOY3b2MXURKOTrudGA0kJ0ZWrFxQpsMIQA/uSNbpSc6 nQSg== X-Gm-Message-State: AOAM532lwdrvcb/3/JMb6+jma0gCei+h50xakAKq1HHccXsJvlJ5aZ6k NwbdxEPVAfCmtG28Ih9tzmVVjn4ShLoBQjxI7bDHzw== X-Google-Smtp-Source: ABdhPJyjaXiWK6XZ9b/I9+BjA4tksSscWU+OFzjp2Ia0HC38A3dnw6Cm+HFUohMblrOwECY7vvWo8ub3+608Ayf5mZY= X-Received: by 2002:a37:9c81:: with SMTP id f123mr17606293qke.21.1593507795079; Tue, 30 Jun 2020 02:03:15 -0700 (PDT) MIME-Version: 1.0 References: <20200629164114.1186-1-tony@atomide.com> In-Reply-To: <20200629164114.1186-1-tony@atomide.com> From: Bartosz Golaszewski Date: Tue, 30 Jun 2020 11:03:04 +0200 Message-ID: Subject: Re: [PATCH] gpio: omap: Add missing PM ops for suspend To: Tony Lindgren Cc: Linus Walleij , Grygorii Strashko , linux-gpio , Linux-OMAP , arm-soc Content-Type: text/plain; charset="UTF-8" Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, Jun 29, 2020 at 6:41 PM Tony Lindgren wrote: > > We've had the legacy platform code take care of suspend for us but > this no longer is the case when probed without legacy mode with > ti-sysc. We need to configure PM ops like standard Linux device > drivers do. > > As we still have some SoCs booting also the legacy mode, we need to > add omap_gpio_suspend() and omap_gpio_resume(), and check for the > is_suspended flag to avoid legacy _od_suspend_noirq() calling them > on an already suspended GPIO instance. > > Once we have no SoCs booting in legacy mode, we can just switch to > using the standard PM ops with pm_runtime_force_suspend() and > pm_runtime_force_resume(). > > Signed-off-by: Tony Lindgren > --- Applied, thanks! Bartosz