From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6ED30C54E4B for ; Mon, 11 May 2020 11:39:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 57C4E2075E for ; Mon, 11 May 2020 11:39:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727873AbgEKLjy (ORCPT ); Mon, 11 May 2020 07:39:54 -0400 Received: from mail-ot1-f65.google.com ([209.85.210.65]:40548 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726068AbgEKLjy (ORCPT ); Mon, 11 May 2020 07:39:54 -0400 Received: by mail-ot1-f65.google.com with SMTP id i27so7225334ota.7; Mon, 11 May 2020 04:39:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WLUOC8UJtO/NjO7jiCbMn0+abT8VbX9GMM13gDXbPSM=; b=HeiMwQPkzeBn7vSgjUle7Bv9yYDYBSeaziS+Wvbnl2vC8oCxN0qt+8yVQeNvkDUyOD TQXNOU/Fv5Fed069WzA7aK0G9JFJaugu1aTkIHVbYR2e0eTbZ2sV+TqpqRO2O/Vh1rQr Eq/4/e/dP8rcBRz2qTlRsr4r/P+K9NQg03j1aSuapD/rbXxvvIVGuaqMo3dZ02botNAC A9hi3ayThk2rF703/KR3Xe7XrKvkccUGZJIRIFBTbb6MvrerCC1LncPUcLkP9YjMRR0c /JbptXy/3j0gVajrXUXUHBhGLqohf6O/ur3tPogt8K6tswyO3RKONIqWxLn/jRB8Og1o kt0A== X-Gm-Message-State: AGi0PubTmLISwErXaAE7+6E56kZphQyL671eY9Ngik5hNbW5ft1sg+qq NAtX7ZW1q3U7drbG+L7MCH6ZPxD63gqLFrkOLmJH1VJK X-Google-Smtp-Source: APiQypI7OWPgVuW6m0ngwmi9gtZLTpiyJk4yRoGAPiyKtr+sovjh7Rguf1Ts5KFE8r6j7uAJSv0hAQqGIjU+3q32Mz4= X-Received: by 2002:a9d:564:: with SMTP id 91mr12303807otw.250.1589197193822; Mon, 11 May 2020 04:39:53 -0700 (PDT) MIME-Version: 1.0 References: <20200507114015.24461-1-geert+renesas@glider.be> <20200507114525.GE34497@piout.net> <87ftccorqd.fsf@soft-dev15.microsemi.net> <20200507124419.GG34497@piout.net> In-Reply-To: <20200507124419.GG34497@piout.net> From: Geert Uytterhoeven Date: Mon, 11 May 2020 13:39:42 +0200 Message-ID: Subject: Re: [PATCH] pinctrl: ocelot: Add platform dependency To: Alexandre Belloni Cc: Lars Povlsen , Linus Walleij , Arnd Bergmann , Microchip Linux Driver Support , "open list:GPIO SUBSYSTEM" , "open list:BROADCOM NVRAM DRIVER" Content-Type: text/plain; charset="UTF-8" Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi Alexandre, On Thu, May 7, 2020 at 2:47 PM Alexandre Belloni wrote: > On 07/05/2020 14:27:06+0200, Lars Povlsen wrote: > > Alexandre Belloni writes: > > > On 07/05/2020 13:40:15+0200, Geert Uytterhoeven wrote: > > >> The Microsemi Ocelot pin controller is only present on Microsemi Ocelot > > >> and Jaguar2 SoCs. Add a platform dependency to the PINCTRL_OCELOT > > >> config symbol, to avoid asking the user about it when configuring a > > >> kernel without Ocelot or Jaguar2 support. > > >> > > > > > > I have to NAK here because there are upcoming (hopefully this cycle) > > > SoCs using this driver. > > > > Not only because of that, but also an arbitrary system connecting to > > ocelot by PCI could be using the driver. > > Right, and that was why I removed the dependency when adding jaguar2 That is far from obvious from the description of commit da801ab56ad87489 ("pinctrl: ocelot: add MSCC Jaguar2 support").... BTW, probably PINCTRL_OCELOT should have got "default y if MSCC_OCELOT", to avoid breaking old configs? > support I never booted the mips core of jaguar2, I used it using PCIe. Ah, you're using it as a PCIe endpoint. So what about ... > > >> Signed-off-by: Geert Uytterhoeven > > >> --- > > >> drivers/pinctrl/Kconfig | 4 ++-- > > >> 1 file changed, 2 insertions(+), 2 deletions(-) > > >> > > >> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > > >> index f0ce4ce3e0f52456..bed67c08a0892240 100644 > > >> --- a/drivers/pinctrl/Kconfig > > >> +++ b/drivers/pinctrl/Kconfig > > >> @@ -394,8 +394,8 @@ config PINCTRL_RK805 > > >> > > >> config PINCTRL_OCELOT > > >> bool "Pinctrl driver for the Microsemi Ocelot and Jaguar2 SoCs" > > >> - depends on OF > > >> - depends on HAS_IOMEM > > >> + depends on OF && HAS_IOMEM > > >> + depends on MSCC_OCELOT || COMPILE_TEST ... "depends on MSCC_OCELOT || PCI || COMPILE_TEST" instead? If other SoCs gain support, the dependency list can be extended. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds