From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] pinctrl: sh-pfc: Do not use platform_get_irq() to count interrupts
Date: Fri, 1 Nov 2019 13:45:53 +0100 [thread overview]
Message-ID: <CAMuHMdVxCEAdxj4xfnU2DEr0UkL5-xNzVdUFkvFgpzr28a7Vfw@mail.gmail.com> (raw)
In-Reply-To: <CAMuHMdVQaCtWR9ZO7N-HKOZS1ivBNWssjqzV1B0XwSBkMFp8Ow@mail.gmail.com>
Hi Linus,
On Thu, Oct 24, 2019 at 2:35 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Thu, Oct 24, 2019 at 2:07 PM Linus Walleij <linus.walleij@linaro.org> wrote:
> > On Wed, Oct 16, 2019 at 4:26 PM Geert Uytterhoeven
> > <geert+renesas@glider.be> wrote:
> > > As platform_get_irq() now prints an error when the interrupt does not
> > > exist, counting interrupts by looping until failure causes the printing
> > > of scary messages like:
> > >
> > > sh-pfc e6060000.pin-controller: IRQ index 0 not found
> > >
> > > Fix this by using the platform_irq_count() helper instead.
> > >
> > > Fixes: 7723f4c5ecdb8d83 ("driver core: platform: Add an error message to platform_get_irq*()")
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> > > Reviewed-by: Stephen Boyd <swboyd@chromium.org>
> > > Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> > > Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> > > ---
> > > v2:
> > > - Add Reviewed-by, Tested-by.
> > >
> > > Linus: Can you please take this one, as it is a fix for v5.4? Thx!
> >
> > I'm not sure the little error message counts as
> > a regression, certainly users can live with it.
>
> Several similar fixes have already made it upstream.
> But the decision is up to you.
>
> > Can't you just put it in your queue for the next kernel?
>
> Sure, will do (after ELC-E), if you prefer.
Queuing in sh-pfc-for-v5.5.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
prev parent reply other threads:[~2019-11-01 12:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 14:26 [PATCH v2] pinctrl: sh-pfc: Do not use platform_get_irq() to count interrupts Geert Uytterhoeven
2019-10-24 12:06 ` Linus Walleij
2019-10-24 12:35 ` Geert Uytterhoeven
2019-11-01 12:45 ` Geert Uytterhoeven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdVxCEAdxj4xfnU2DEr0UkL5-xNzVdUFkvFgpzr28a7Vfw@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=geert+renesas@glider.be \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).