From: Baolin Wang <baolin.wang@linaro.org>
To: Nishka Dasgupta <nishkadg.linux@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Orson Zhai <orsonzhai@gmail.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: sprd: Add of_node_put() before return to prevent memory leak
Date: Thu, 8 Aug 2019 15:55:07 +0800 [thread overview]
Message-ID: <CAMz4kuL=bLa4QMhy82Cffpn9fDk-H1MZYCrybZiVn+nZQyBmdQ@mail.gmail.com> (raw)
In-Reply-To: <20190808074329.15579-1-nishkadg.linux@gmail.com>
On Thu, 8 Aug 2019 at 15:43, Nishka Dasgupta <nishkadg.linux@gmail.com> wrote:
>
> Each iteration of for_each_child_of_node puts the previous node, but in
> the case of a return from the middle of the loop, there is no put, thus
> causing a memory leak. Hence add an of_node_put before the return in
> two places.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Yes, thanks for your fix.
Reviewed-by: Baolin Wang <baolin.wang@linaro.org>
> ---
> drivers/pinctrl/sprd/pinctrl-sprd.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/sprd/pinctrl-sprd.c b/drivers/pinctrl/sprd/pinctrl-sprd.c
> index c31b58168772..5abb64da2c0d 100644
> --- a/drivers/pinctrl/sprd/pinctrl-sprd.c
> +++ b/drivers/pinctrl/sprd/pinctrl-sprd.c
> @@ -940,8 +940,10 @@ static int sprd_pinctrl_parse_dt(struct sprd_pinctrl *sprd_pctl)
>
> for_each_child_of_node(np, child) {
> ret = sprd_pinctrl_parse_groups(child, sprd_pctl, grp);
> - if (ret)
> + if (ret) {
> + of_node_put(child);
> return ret;
> + }
>
> *temp++ = grp->name;
> grp++;
> @@ -950,8 +952,11 @@ static int sprd_pinctrl_parse_dt(struct sprd_pinctrl *sprd_pctl)
> for_each_child_of_node(child, sub_child) {
> ret = sprd_pinctrl_parse_groups(sub_child,
> sprd_pctl, grp);
> - if (ret)
> + if (ret) {
> + of_node_put(sub_child);
> + of_node_put(child);
> return ret;
> + }
>
> *temp++ = grp->name;
> grp++;
> --
> 2.19.1
>
--
Baolin Wang
Best Regards
next prev parent reply other threads:[~2019-08-08 7:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 7:43 [PATCH] pinctrl: sprd: Add of_node_put() before return to prevent memory leak Nishka Dasgupta
2019-08-08 7:55 ` Baolin Wang [this message]
2019-08-10 8:23 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMz4kuL=bLa4QMhy82Cffpn9fDk-H1MZYCrybZiVn+nZQyBmdQ@mail.gmail.com' \
--to=baolin.wang@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=nishkadg.linux@gmail.com \
--cc=orsonzhai@gmail.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).