* [PATCH] pinctrl: freescale: Add helper dependency on COMPILE_TEST
@ 2021-08-25 8:22 Cai Huoqing
2021-09-16 22:07 ` Linus Walleij
2021-09-17 11:50 ` Fabio Estevam
0 siblings, 2 replies; 6+ messages in thread
From: Cai Huoqing @ 2021-08-25 8:22 UTC (permalink / raw)
To: aisheng.dong, festevam, shawnguo, stefan, linus.walleij
Cc: linux-gpio, linux-kernel, Cai Huoqing
it's helpful for complie test in other platform(e.g.X86)
Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
drivers/pinctrl/freescale/Kconfig | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/pinctrl/freescale/Kconfig b/drivers/pinctrl/freescale/Kconfig
index 21fa21c6547b..defc1f38efc7 100644
--- a/drivers/pinctrl/freescale/Kconfig
+++ b/drivers/pinctrl/freescale/Kconfig
@@ -119,28 +119,28 @@ config PINCTRL_IMX7ULP
config PINCTRL_IMX8MM
tristate "IMX8MM pinctrl driver"
- depends on ARCH_MXC
+ depends on ARCH_MXC || (COMPILE_TEST && OF)
select PINCTRL_IMX
help
Say Y here to enable the imx8mm pinctrl driver
config PINCTRL_IMX8MN
tristate "IMX8MN pinctrl driver"
- depends on ARCH_MXC
+ depends on ARCH_MXC || (COMPILE_TEST && OF)
select PINCTRL_IMX
help
Say Y here to enable the imx8mn pinctrl driver
config PINCTRL_IMX8MP
tristate "IMX8MP pinctrl driver"
- depends on ARCH_MXC
+ depends on ARCH_MXC || (COMPILE_TEST && OF)
select PINCTRL_IMX
help
Say Y here to enable the imx8mp pinctrl driver
config PINCTRL_IMX8MQ
tristate "IMX8MQ pinctrl driver"
- depends on ARCH_MXC
+ depends on ARCH_MXC || (COMPILE_TEST && OF)
select PINCTRL_IMX
help
Say Y here to enable the imx8mq pinctrl driver
@@ -168,7 +168,7 @@ config PINCTRL_IMX8DXL
config PINCTRL_IMX8ULP
tristate "IMX8ULP pinctrl driver"
- depends on ARCH_MXC
+ depends on ARCH_MXC || (COMPILE_TEST && OF)
select PINCTRL_IMX
help
Say Y here to enable the imx8ulp pinctrl driver
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] pinctrl: freescale: Add helper dependency on COMPILE_TEST
2021-08-25 8:22 [PATCH] pinctrl: freescale: Add helper dependency on COMPILE_TEST Cai Huoqing
@ 2021-09-16 22:07 ` Linus Walleij
2021-09-17 1:54 ` Cai Huoqing
2021-09-17 11:50 ` Fabio Estevam
1 sibling, 1 reply; 6+ messages in thread
From: Linus Walleij @ 2021-09-16 22:07 UTC (permalink / raw)
To: Cai Huoqing
Cc: Dong Aisheng, Fabio Estevam, Shawn Guo, Stefan Agner,
open list:GPIO SUBSYSTEM, linux-kernel
On Wed, Aug 25, 2021 at 10:23 AM Cai Huoqing <caihuoqing@baidu.com> wrote:
> it's helpful for complie test in other platform(e.g.X86)
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
It seems weird to only enable this on a few select subdrivers rather
than all of the Freescale drivers?
(Also: the Freescale maintainers are very silent, some feedback
would be helpful.)
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] pinctrl: freescale: Add helper dependency on COMPILE_TEST
2021-09-16 22:07 ` Linus Walleij
@ 2021-09-17 1:54 ` Cai Huoqing
0 siblings, 0 replies; 6+ messages in thread
From: Cai Huoqing @ 2021-09-17 1:54 UTC (permalink / raw)
To: Linus Walleij
Cc: Dong Aisheng, Fabio Estevam, Shawn Guo, Stefan Agner, GPIO SUBSYSTEM,
On 17 9月 21 00:07:32, Linus Walleij wrote:
> On Wed, Aug 25, 2021 at 10:23 AM Cai Huoqing <caihuoqing@baidu.com> wrote:
>
> > it's helpful for complie test in other platform(e.g.X86)
> >
> > Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
>
> It seems weird to only enable this on a few select subdrivers rather
> than all of the Freescale drivers?
The others seem to depend on SOC_IMX arch related headers
but it's ok for ARCH_IMX related to use COMPILE_TEST.
>
> (Also: the Freescale maintainers are very silent, some feedback
> would be helpful.)
>
> Yours,
> Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] pinctrl: freescale: Add helper dependency on COMPILE_TEST
2021-08-25 8:22 [PATCH] pinctrl: freescale: Add helper dependency on COMPILE_TEST Cai Huoqing
2021-09-16 22:07 ` Linus Walleij
@ 2021-09-17 11:50 ` Fabio Estevam
2021-09-18 2:26 ` Cai Huoqing
1 sibling, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2021-09-17 11:50 UTC (permalink / raw)
To: Cai Huoqing
Cc: Dong Aisheng, Shawn Guo, Stefan Agner, Linus Walleij,
open list:GPIO SUBSYSTEM, linux-kernel
Hi Cai,
On Wed, Aug 25, 2021 at 5:23 AM Cai Huoqing <caihuoqing@baidu.com> wrote:
>
> it's helpful for complie test in other platform(e.g.X86)
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
> drivers/pinctrl/freescale/Kconfig | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/pinctrl/freescale/Kconfig b/drivers/pinctrl/freescale/Kconfig
> index 21fa21c6547b..defc1f38efc7 100644
> --- a/drivers/pinctrl/freescale/Kconfig
> +++ b/drivers/pinctrl/freescale/Kconfig
> @@ -119,28 +119,28 @@ config PINCTRL_IMX7ULP
>
> config PINCTRL_IMX8MM
> tristate "IMX8MM pinctrl driver"
> - depends on ARCH_MXC
> + depends on ARCH_MXC || (COMPILE_TEST && OF)
> select PINCTRL_IMX
I am not sure why you need the && OF, as we have a "select PINCTRL_IMX",
that already depends on OF.
Also, why was PINCTRL_IMX8DXL not updated?
Thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] pinctrl: freescale: Add helper dependency on COMPILE_TEST
2021-09-17 11:50 ` Fabio Estevam
@ 2021-09-18 2:26 ` Cai Huoqing
2021-09-23 22:17 ` Fabio Estevam
0 siblings, 1 reply; 6+ messages in thread
From: Cai Huoqing @ 2021-09-18 2:26 UTC (permalink / raw)
To: Fabio Estevam
Cc: Dong Aisheng, Shawn Guo, Stefan Agner, Linus Walleij, GPIO SUBSYSTEM,
On 17 9月 21 08:50:55, Fabio Estevam wrote:
> Hi Cai,
>
> On Wed, Aug 25, 2021 at 5:23 AM Cai Huoqing <caihuoqing@baidu.com> wrote:
> >
> > it's helpful for complie test in other platform(e.g.X86)
> >
> > Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> > ---
> > drivers/pinctrl/freescale/Kconfig | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/pinctrl/freescale/Kconfig b/drivers/pinctrl/freescale/Kconfig
> > index 21fa21c6547b..defc1f38efc7 100644
> > --- a/drivers/pinctrl/freescale/Kconfig
> > +++ b/drivers/pinctrl/freescale/Kconfig
> > @@ -119,28 +119,28 @@ config PINCTRL_IMX7ULP
> >
> > config PINCTRL_IMX8MM
> > tristate "IMX8MM pinctrl driver"
> > - depends on ARCH_MXC
> > + depends on ARCH_MXC || (COMPILE_TEST && OF)
> > select PINCTRL_IMX
>
> I am not sure why you need the && OF, as we have a "select PINCTRL_IMX",
> that already depends on OF.
No, it's just an invalid dependency. PINCTRL_IMX can be selected without OF
opened.
>
> Also, why was PINCTRL_IMX8DXL not updated?
Ok, I'll update all pinctrl IMX.
>
> Thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] pinctrl: freescale: Add helper dependency on COMPILE_TEST
2021-09-18 2:26 ` Cai Huoqing
@ 2021-09-23 22:17 ` Fabio Estevam
0 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2021-09-23 22:17 UTC (permalink / raw)
To: Cai Huoqing
Cc: Dong Aisheng, Shawn Guo, Stefan Agner, Linus Walleij,
GPIO SUBSYSTEM, linux-kernel
Hi Cai,
On Fri, Sep 17, 2021 at 11:26 PM Cai Huoqing <caihuoqing@baidu.com> wrote:
> > I am not sure why you need the && OF, as we have a "select PINCTRL_IMX",
> > that already depends on OF.
> No, it's just an invalid dependency. PINCTRL_IMX can be selected without OF
I don't understand your statement.
From drivers/pinctrl/freescale/Kconfig:
config PINCTRL_IMX
tristate
depends on OF
So PINCTRL_IMX depends on OF, which means that it can only be selected
when CONFIG_OF=y.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-09-23 22:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-25 8:22 [PATCH] pinctrl: freescale: Add helper dependency on COMPILE_TEST Cai Huoqing
2021-09-16 22:07 ` Linus Walleij
2021-09-17 1:54 ` Cai Huoqing
2021-09-17 11:50 ` Fabio Estevam
2021-09-18 2:26 ` Cai Huoqing
2021-09-23 22:17 ` Fabio Estevam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).