From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26F13C43603 for ; Mon, 16 Dec 2019 12:09:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EE3FE206CB for ; Mon, 16 Dec 2019 12:09:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jXT0lsCm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727467AbfLPMJh (ORCPT ); Mon, 16 Dec 2019 07:09:37 -0500 Received: from mail-vs1-f65.google.com ([209.85.217.65]:45527 "EHLO mail-vs1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727443AbfLPMJh (ORCPT ); Mon, 16 Dec 2019 07:09:37 -0500 Received: by mail-vs1-f65.google.com with SMTP id l24so3908318vsr.12 for ; Mon, 16 Dec 2019 04:09:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6A9SmGG2+bj/pD1xuwTAZLvQwqgF83kKhw0ox6vXN3k=; b=jXT0lsCmRjPWBk1LGcpwql6bN+AbiN/lB+TY+O8wUE+pb1tql/TyWIpWSF+vqslejo eR+ps1L7Mq8pvKmT52XDBnWGXcLw9eqJ/p3NhY/CFYbuaVDQferDt/vJ2rexIYb6hKuO x0wPI6PEh96ejB2U9AzGcdP5SxpASQXQHBXIHCmxuiFyJqPGBp0ozDIz3B8pkSLHEo0l Y7BHqC5etKHr970u+ZS+vL8HZcvj5/88LDJH1lIdIa0TrM+Zv2ZWiEchTa3g6l50BJXB XCLNUPErLHUsn7jsv40n9fvbiq/MtGlk2h3dxFg2JJSPwHVQlyM2CqaLjd0LYYgnLt9z 840w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6A9SmGG2+bj/pD1xuwTAZLvQwqgF83kKhw0ox6vXN3k=; b=st9a2FqRVXWtcJQCbtkKhYiF4CyXB33qCvGpdklx3scox+RjymYyvoDi8k6sfZgppm dWvfciGCNEUF4vXLxsXeaoc4u+q70QDyXk8/D4nTegBaIoANMKm5g4L63gfTjbpeRQ7p V/Gp7BJGzas36HftoqCElNJp6j5w2RFSBiTYQB+ix2lkj7+Sfngh8FAqjzlW4V+c8VUN twE8mXrMbh8PvrPQjv5IxAWV8GlqpZC1ssbEgYPxzdySJxtfOKn3RSpoga23bb/khxKh D4cS7S7EJjkNoQkKfiWc4c00uD7eicFNkSOc3xBktmLeU2y8U+BqQW59oYBiG4LtcYTL mLoQ== X-Gm-Message-State: APjAAAUzDxXlfZ+XuxCW+t1mZYdMI5nvoQk1wdSDhd6TCxXJTVJmj0GZ +aAquQY4mknR0JUCYtKOZIR1gHe76EKR8EPXpQqi5A== X-Google-Smtp-Source: APXvYqzXtD2dx+U34J2BlasQ73Om+g2qJaDU3dKObl0ufgdGzbHbhXxROItuw34IjZX3c1dnx1+spYkCWWPl4hbvSfE= X-Received: by 2002:a67:db8f:: with SMTP id f15mr6614165vsk.191.1576498176274; Mon, 16 Dec 2019 04:09:36 -0800 (PST) MIME-Version: 1.0 References: <20191206170821.29711-1-ulf.hansson@linaro.org> <20191206170821.29711-2-ulf.hansson@linaro.org> In-Reply-To: From: Ulf Hansson Date: Mon, 16 Dec 2019 13:09:00 +0100 Message-ID: Subject: Re: [PATCH 1/9] pinctrl: core: Add pinctrl_select_default_state() and export it To: Linus Walleij Cc: "open list:GPIO SUBSYSTEM" , linux-mmc Content-Type: text/plain; charset="UTF-8" Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, 16 Dec 2019 at 09:02, Linus Walleij wrote: > > On Fri, Dec 6, 2019 at 6:08 PM Ulf Hansson wrote: > > > It has turned out that some mmc host drivers, but perhaps also others > > drivers, needs to reset the pinctrl into the default state > > (PINCTRL_STATE_DEFAULT). However, they can't use the existing > > pinctrl_pm_select_default_state(), as that requires CONFIG_PM to be set. > > This leads to open coding, as they need to look up the default state > > themselves and then select it. > > > > To avoid the open coding, let's introduce pinctrl_select_default_state() > > and make it available independently of CONFIG_PM. As a matter of fact, this > > makes it more consistent with the behaviour of the driver core, as it > > already tries to looks up the default state during probe. > > > > Going forward, users of pinctrl_pm_select_default_state() are encouraged to > > move to pinctrl_select_default_state(), so the old API can be removed. > > > > Signed-off-by: Ulf Hansson > > I have put this patch on an immutable branch so that you can pull it into your > tree: > https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/log/?h=ib-pinctrl-default-state > > I also pulled this immutable branch into my "devel" branch for v5.6. > > I think other subsystems may need the same kind of stuff and I might need > to change code around here so I need to apply it to my tree. Thanks! I have pulled in the branch into my tree - and applied the mmc patches with your ack on top. Kind regards Uffe