From: Paul Cercueil <paul@crapouillou.net>
To: Siarhei Volkau <lis8215@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>, kernel test robot <lkp@intel.com>,
kbuild-all@lists.01.org,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Vinod Koul <vkoul@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Linus Walleij <linus.walleij@linaro.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
linux-serial@vger.kernel.org, linux-mips@vger.kernel.org,
GPIO SUBSYSTEM <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH 7/8] serial: 8250/ingenic: Add support for the JZ4750/JZ4755 SoCs
Date: Thu, 13 Oct 2022 10:17:04 +0100 [thread overview]
Message-ID: <GSPOJR.M4XZ4D03G60F@crapouillou.net> (raw)
In-Reply-To: <bb9f79d4-82a9-4790-b849-d517333ea2d4@app.fastmail.com>
Hi,
Le jeu., oct. 13 2022 at 08:46:39 +0200, Arnd Bergmann <arnd@arndb.de>
a écrit :
> On Thu, Oct 13, 2022, at 8:37 AM, Siarhei Volkau wrote:
>> пн, 10 окт. 2022 г. в 01:29, kernel test robot
>> <lkp@intel.com>:
>>> config: ia64-allyesconfig
>>> config: arm64-randconfig-r035-20221010
>>
>>> > 142 #define CGU_REG_CPCCR ((void *)CKSEG1ADDR(0x10000000))
>>
>>> 0-DAY CI Kernel Test Service
>>
>> I know CKSEG1ADDR is MIPS specific, might be it needed to disable
>> COMPILE_TEST
>> on the driver?
>> Since early syscon isn't mainlined yet I don't see any other way at
>> the moment.
>>
>> Any suggestions on that, folks?
>
> This looks like some setup that belongs into the bootloader. If you
> are
> handing over the console from bootloader to kernel, the hardware
> should
> already be in a working state, with no need to touch it during early
> boot.
>
> If you are dealing with broken bootloaders that are not under your
> control,
> having this code in the architecture specific early boot as a fixup
> would be better than putting it into the driver.
Agreed. I am not fond of having a driver poking into an unrelated
subsystem's memory area.
Just disable the divider in ingenic_fixup_fdt() in
arch/mips/generic/board-ingenic.c.
Cheers,
-Paul
next prev parent reply other threads:[~2022-10-13 9:17 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-09 18:13 [PATCH 0/8] MIPS: ingenic: Add support for the JZ4755 SoC Siarhei Volkau
2022-10-09 18:13 ` [PATCH 1/8] dt-bindings: " Siarhei Volkau
2022-10-10 14:53 ` Krzysztof Kozlowski
2022-10-10 20:18 ` Siarhei Volkau
2022-10-11 12:08 ` Krzysztof Kozlowski
2022-10-13 9:03 ` Paul Cercueil
2022-10-09 18:13 ` [PATCH 2/8] MIPS: ingenic: add new machine type MACH_JZ4755 Siarhei Volkau
2022-10-09 18:13 ` [PATCH 3/8] dt-bindings: clock: Add Ingenic JZ4755 CGU header Siarhei Volkau
2022-10-10 13:05 ` Rob Herring
2022-10-09 18:13 ` [PATCH 4/8] clk: Add Ingenic JZ4755 CGU driver Siarhei Volkau
2022-10-10 19:24 ` kernel test robot
2022-10-09 18:13 ` [PATCH 5/8] pinctrl: ingenic: JZ4755 minor bug fixes Siarhei Volkau
2022-10-17 9:46 ` Linus Walleij
2022-10-09 18:13 ` [PATCH 6/8] dmaengine: JZ4780: Add support for the JZ4755 Siarhei Volkau
2022-10-09 18:13 ` [PATCH 7/8] serial: 8250/ingenic: Add support for the JZ4750/JZ4755 SoCs Siarhei Volkau
2022-10-09 22:28 ` kernel test robot
2022-10-13 6:37 ` Siarhei Volkau
2022-10-13 6:46 ` Arnd Bergmann
2022-10-13 9:17 ` Paul Cercueil [this message]
2022-10-13 18:56 ` Siarhei Volkau
2022-10-16 18:39 ` Siarhei Volkau
2022-10-17 9:31 ` Paul Cercueil
2022-10-19 15:19 ` Siarhei Volkau
2022-10-10 16:12 ` kernel test robot
2022-10-10 20:20 ` Greg Kroah-Hartman
2022-10-11 18:38 ` Siarhei Volkau
2022-10-10 21:39 ` kernel test robot
2022-10-09 18:13 ` [PATCH 8/8] MIPS: DTS: Ingenic: Add support for the JZ4755 SoC Siarhei Volkau
2022-10-10 14:54 ` Krzysztof Kozlowski
2022-10-10 20:00 ` Siarhei Volkau
2022-10-11 12:09 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=GSPOJR.M4XZ4D03G60F@crapouillou.net \
--to=paul@crapouillou.net \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=krzk@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lis8215@gmail.com \
--cc=lkp@intel.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).