From: Kent Gibson <warthog618@gmail.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Vincent Guittot" <vincent.guittot@linaro.org>,
linux-gpio@vger.kernel.org,
"Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com>,
"Wedson Almeida Filho" <wedsonaf@google.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
stratos-dev@op-lists.linaro.org,
"Gerard Ryan" <g.m0n3y.2503@gmail.com>
Subject: Re: [PATCH V7 7/8] libgpiod: Add rust tests
Date: Thu, 20 Oct 2022 19:02:14 +0800 [thread overview]
Message-ID: <Y1Eqtso+7MQhNmMe@sol> (raw)
In-Reply-To: <20221020103741.vdo5xwrjgqmfizbx@vireshk-i7>
On Thu, Oct 20, 2022 at 04:07:41PM +0530, Viresh Kumar wrote:
> On 17-10-22, 21:00, Kent Gibson wrote:
> > I was surprised to find HTE tests passing on a kernel without CONFIG_HTE.
> > I take that as being a kernel bug (GPIO_V2_LINE_VALID_FLAGS includes the
> > HTE flag unconditionally - which is wrong IMHO).
> >
> > You probably shouldn't assume HTE works - unless you have a system that
> > supports HTE.
>
> Should I drop them ? Or run them conditionally ? How ?
>
The Rust test framework is pretty simple, so there is no way to
conditionally skip tests, AFAIAA. And the only generic way to tell if
your kernel supports HTE without probing it, which makes testing it
pointless.
So I don't see any alternative but to drop them.
Though I would be happy to learn otherwise.
Cheers,
Kent.
next prev parent reply other threads:[~2022-10-20 11:02 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 10:47 [PATCH V7 0/8] libgpiod: Add Rust bindings Viresh Kumar
2022-10-14 10:47 ` [PATCH V7 1/8] libgpiod: Add libgpiod-sys rust crate Viresh Kumar
2022-10-17 12:59 ` Kent Gibson
2022-10-18 11:22 ` Viresh Kumar
2022-10-18 11:42 ` Miguel Ojeda
2022-10-18 11:49 ` Kent Gibson
2022-10-19 6:46 ` Viresh Kumar
2022-10-19 7:21 ` Kent Gibson
2022-10-19 11:22 ` Viresh Kumar
2022-10-19 12:01 ` Kent Gibson
2022-10-20 5:34 ` Viresh Kumar
2022-10-27 12:18 ` Bartosz Golaszewski
2022-10-14 10:47 ` [PATCH V7 2/8] libgpiod-sys: Add pre generated rust bindings Viresh Kumar
2022-10-14 10:47 ` [PATCH V7 3/8] libgpiod: Add rust wrapper crate Viresh Kumar
2022-10-17 12:59 ` Kent Gibson
2022-10-21 11:22 ` Viresh Kumar
2022-10-21 12:39 ` Kent Gibson
2022-10-27 12:09 ` Bartosz Golaszewski
2022-10-31 12:33 ` Kent Gibson
2022-10-31 12:45 ` Bartosz Golaszewski
2022-11-02 4:00 ` Viresh Kumar
2022-11-02 12:47 ` Bartosz Golaszewski
2022-11-02 13:08 ` Kent Gibson
2022-11-02 16:34 ` Bartosz Golaszewski
2022-11-03 0:38 ` Kent Gibson
2022-11-03 8:35 ` Bartosz Golaszewski
2022-11-03 12:29 ` Kent Gibson
2022-11-04 15:51 ` Bartosz Golaszewski
2022-10-18 3:27 ` Kent Gibson
2022-10-21 11:25 ` Viresh Kumar
2022-10-14 10:47 ` [PATCH V7 4/8] libgpiod: Add rust examples Viresh Kumar
2022-10-17 13:00 ` Kent Gibson
2022-10-14 10:47 ` [PATCH V7 5/8] libgpiod: Add gpiosim rust crate Viresh Kumar
2022-10-17 13:00 ` Kent Gibson
2022-10-21 9:56 ` Viresh Kumar
2022-10-14 10:47 ` [PATCH V7 6/8] gpiosim: Add pre generated rust bindings Viresh Kumar
2022-10-14 10:47 ` [PATCH V7 7/8] libgpiod: Add rust tests Viresh Kumar
2022-10-17 13:00 ` Kent Gibson
2022-10-17 14:30 ` Kent Gibson
2022-10-20 10:37 ` Viresh Kumar
2022-10-20 11:02 ` Kent Gibson [this message]
2022-10-20 12:40 ` Bartosz Golaszewski
2022-10-20 15:16 ` Miguel Ojeda
2022-10-14 10:47 ` [PATCH V7 8/8] libgpiod: Integrate building of rust bindings with make Viresh Kumar
2022-10-14 17:03 ` [PATCH V7 0/8] libgpiod: Add Rust bindings Miguel Ojeda
2022-10-20 13:29 ` Björn Roy Baron
2022-10-21 9:39 ` Viresh Kumar
2022-10-21 14:34 ` Björn Roy Baron
2022-10-25 6:42 ` Viresh Kumar
2022-10-29 17:46 ` Björn Roy Baron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1Eqtso+7MQhNmMe@sol \
--to=warthog618@gmail.com \
--cc=alex.bennee@linaro.org \
--cc=brgl@bgdev.pl \
--cc=g.m0n3y.2503@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=stratos-dev@op-lists.linaro.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=wedsonaf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).