From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Xiang Yang <xiangyang3@huawei.com>,
mika.westerberg@linux.intel.com, linus.walleij@linaro.org,
linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] gpiolib: acpi: Use METHOD_NAME__AEI macro for acpi_walk_resources
Date: Thu, 20 Oct 2022 16:51:00 +0300 [thread overview]
Message-ID: <Y1FSRJC9s+7cvJI3@smile.fi.intel.com> (raw)
In-Reply-To: <CAMRc=Md6nseghBwfiRCL0KQ1BJ0WE7MH9QENf=HdJdnC1Xz1Fg@mail.gmail.com>
On Thu, Oct 20, 2022 at 03:23:27PM +0200, Bartosz Golaszewski wrote:
> On Thu, Oct 20, 2022 at 3:48 AM Xiang Yang <xiangyang3@huawei.com> wrote:
> >
> > Using the METHOD_NAME__AEI macro instead of using "_AEI" directly.
> >
> > Signed-off-by: Xiang Yang <xiangyang3@huawei.com>
> > ---
> > drivers/gpio/gpiolib-acpi.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
> > index a7d2358736fe..064ba5150fd4 100644
> > --- a/drivers/gpio/gpiolib-acpi.c
> > +++ b/drivers/gpio/gpiolib-acpi.c
> > @@ -512,7 +512,7 @@ void acpi_gpiochip_request_interrupts(struct gpio_chip *chip)
> > if (ACPI_FAILURE(status))
> > return;
> >
> > - acpi_walk_resources(handle, "_AEI",
> > + acpi_walk_resources(handle, METHOD_NAME__AEI,
> > acpi_gpiochip_alloc_event, acpi_gpio);
>
> This line dates back to 2018 so why -next in your PATCH tag?
This means "for Linux next cycle". It has roots in the net subsystem where
it's a requirement to mark each patch either net or net-next, because they
have a huge traffic of patches.
> That being said - patch applied (unless Andy wants to take it directly).
I think I will take it. Care to provide your tag?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-10-20 13:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 1:44 [PATCH -next] gpiolib: acpi: Use METHOD_NAME__AEI macro for acpi_walk_resources Xiang Yang
2022-10-20 13:23 ` Bartosz Golaszewski
2022-10-20 13:51 ` Andy Shevchenko [this message]
2022-10-20 14:30 ` Bartosz Golaszewski
2022-10-25 16:47 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1FSRJC9s+7cvJI3@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=xiangyang3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).