From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Syed Nayyar Waris <syednwaris@gmail.com>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
William Breathitt Gray <vilhelm.gray@gmail.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Arnd Bergmann <arnd@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v2 3/3] gpio: xilinx: Utilize generic bitmap_get_value and _set_value
Date: Mon, 15 Feb 2021 17:51:36 +0200 [thread overview]
Message-ID: <YCqYiIIhKk004Js8@smile.fi.intel.com> (raw)
In-Reply-To: <CACG_h5qbeSty16A6zmxAV=Pi=BQ=Su7U7Sb=j1t5_2qZ3ExO_Q@mail.gmail.com>
On Mon, Feb 15, 2021 at 07:23:10PM +0530, Syed Nayyar Waris wrote:
> On Mon, Feb 15, 2021 at 7:16 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Mon, Feb 15, 2021 at 06:56:10PM +0530, Syed Nayyar Waris wrote:
> > > On Sun, Feb 14, 2021 at 10:11 AM kernel test robot <lkp@intel.com> wrote:
> > > > >> ERROR: modpost: "bitmap_get_value" [drivers/gpio/gpio-xilinx.ko] undefined!
> > > > >> ERROR: modpost: "bitmap_set_value" [drivers/gpio/gpio-xilinx.ko] undefined!
> > > >
> > >
> > > Dear All,
> > >
> > > I was able to reproduce the above 2 build errors with the config file
> > > provided and the build command mentioned in the above mail. But I need
> > > help to fix the build errors.
> > >
> > > Scenario:
> > > Function 'bitmap_get_value()' is declared in 'gpiolib.h'. It is
> > > defined in 'gpiolib.c'. Function 'bitmap_get_value()' is then being
> > > used in gpio-xilinx.c and the build error is thrown. Similar situation
> > > holds for the other function 'bitmap_set_value'.
> > >
> > > How do I resolve the above build error?. Kindly illuminate. The full
> > > patchset can be found at:
> > > https://lore.kernel.org/patchwork/cover/1380056/
> >
> > Missed EXPORT_SYMBOL_GPL() or so?
>
> It has EXPORT_SYMBOL_GPL(). But the build errors still persist.
Okay, I don't see an email with configuration file, so you need to dig it up to
understand what combination of options brought this.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-02-15 16:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 13:19 [PATCH v2 0/3] Introduce the for_each_set_clump macro Syed Nayyar Waris
2021-02-12 13:20 ` [PATCH v2 1/3] gpiolib: " Syed Nayyar Waris
2021-02-14 6:44 ` William Breathitt Gray
2021-02-12 13:21 ` [PATCH v2 2/3] gpio: thunderx: Utilize " Syed Nayyar Waris
2021-02-14 6:46 ` William Breathitt Gray
2021-02-12 13:22 ` [PATCH v2 3/3] gpio: xilinx: Utilize generic bitmap_get_value and _set_value Syed Nayyar Waris
2021-02-14 6:51 ` William Breathitt Gray
[not found] ` <202102141226.pmNlFRSx-lkp@intel.com>
2021-02-15 13:26 ` Syed Nayyar Waris
2021-02-15 13:46 ` Andy Shevchenko
2021-02-15 13:53 ` Syed Nayyar Waris
2021-02-15 15:51 ` Andy Shevchenko [this message]
2021-03-03 14:43 ` [PATCH v2 0/3] Introduce the for_each_set_clump macro Bartosz Golaszewski
2021-03-06 13:39 ` Syed Nayyar Waris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCqYiIIhKk004Js8@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=arnd@kernel.org \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=syednwaris@gmail.com \
--cc=vilhelm.gray@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).