From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E5CDC433B4 for ; Sat, 1 May 2021 07:19:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 68844613E7 for ; Sat, 1 May 2021 07:19:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231236AbhEAHT7 (ORCPT ); Sat, 1 May 2021 03:19:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229510AbhEAHT7 (ORCPT ); Sat, 1 May 2021 03:19:59 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E51EBC06138B for ; Sat, 1 May 2021 00:19:08 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id j10so475493lfb.12 for ; Sat, 01 May 2021 00:19:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech-se.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=HpRAh0AKr1YDJaa0KEpbsEbW9xmFbeMhwVrzvKzXJx0=; b=Nb1J9iTPaupIu47FDL7UQYumq6kbOgLe8SvlsPOxiyYo/jIgLezGneWjtdrZtuGSdG XqmBemOQv8A6N4Rbt2YiHcLUIt8qlXLagWxL6aG6mMm7yzRiJaclNc+anJrkXGCVlWwQ zxvQyHXhL9QjVxi98D9xdW8WW29imnDvn4TeMpvNnekm7OsSQGE2d+bpOKFxpX4FHc4b Zmn35NE9NYHmwmajhCbm9oIBtdgyBlId7xwBLE4ga7vg1yL6Akj7Hjsz6dGsOknv3sC/ K2WygbrZkOTrTA2+h1TDQ1AJ97EIYC1zFyn1VcC0SzRI0FyWLIwd7TMKbNGqlRl6K/iX Y9lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=HpRAh0AKr1YDJaa0KEpbsEbW9xmFbeMhwVrzvKzXJx0=; b=szZuKsCXQ50Rj4tWecP2arSsaW2PgdBGR3NCbswdRRG1HFySR71yy6n0LkNhRQ93ks mns+S9QKAXWK24erWPDFHv/B0lJKGKzRW+PWitb9ac6MPAUm3BKA2BvrFdso7DrfHDS0 oxbX6t5Q7+wYpcMH5oiNE6ORE7EGM95AoeazuTHFSSsHDuXBdZk2AnI9YiddD5rQkI/C utL82BDf0tH+y47KedhMt7Ew/vhrmae+no7agABWi7lC6qUP1U0QVIMWKIx7bUqpIRyv 2pooB0HkvY1/+L1AKHqnqgUykJ6RkiPw8GfpBnre80+glrzdSe9a5ROZLPdEKLTC0UXs UjZQ== X-Gm-Message-State: AOAM530BEsx/jDvscVFiCnieOHaEZ20KAEIuKSA7keDsOzFFE+ShQ9sJ P+nxYMAmdmKOIHv/BxKLIgJNqw== X-Google-Smtp-Source: ABdhPJz/htm2R2SlOuTkn9+pj3//7ImcHUBGYra66Vij+YA02Pc6ejc2l5G4FT3g6Iswnpou4eCb0w== X-Received: by 2002:ac2:5049:: with SMTP id a9mr6035770lfm.662.1619853547243; Sat, 01 May 2021 00:19:07 -0700 (PDT) Received: from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203]) by smtp.gmail.com with ESMTPSA id l14sm500592lfc.58.2021.05.01.00.19.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 May 2021 00:19:06 -0700 (PDT) Date: Sat, 1 May 2021 09:19:06 +0200 From: Niklas =?iso-8859-1?Q?S=F6derlund?= To: Geert Uytterhoeven Cc: Linus Walleij , linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH 02/12] pinctrl: renesas: r8a77990: JTAG pins do not have pull-down capabilities Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi Geert, Thanks for your work. On 2021-04-30 14:31:01 +0200, Geert Uytterhoeven wrote: > Hence remove the SH_PFC_PIN_CFG_PULL_DOWN flags from their pin > descriptions. > > Fixes: 83f6941a42a5e773 ("pinctrl: sh-pfc: r8a77990: Add bias pinconf support") > Signed-off-by: Geert Uytterhoeven Reviewed-by: Niklas Söderlund > --- > drivers/pinctrl/renesas/pfc-r8a77990.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/pinctrl/renesas/pfc-r8a77990.c b/drivers/pinctrl/renesas/pfc-r8a77990.c > index d040eb3e305daf40..eeebbab4dd811f9c 100644 > --- a/drivers/pinctrl/renesas/pfc-r8a77990.c > +++ b/drivers/pinctrl/renesas/pfc-r8a77990.c > @@ -53,10 +53,10 @@ > PIN_NOGP_CFG(FSCLKST_N, "FSCLKST_N", fn, CFG_FLAGS), \ > PIN_NOGP_CFG(MLB_REF, "MLB_REF", fn, CFG_FLAGS), \ > PIN_NOGP_CFG(PRESETOUT_N, "PRESETOUT_N", fn, CFG_FLAGS), \ > - PIN_NOGP_CFG(TCK, "TCK", fn, CFG_FLAGS), \ > - PIN_NOGP_CFG(TDI, "TDI", fn, CFG_FLAGS), \ > - PIN_NOGP_CFG(TMS, "TMS", fn, CFG_FLAGS), \ > - PIN_NOGP_CFG(TRST_N, "TRST_N", fn, CFG_FLAGS) > + PIN_NOGP_CFG(TCK, "TCK", fn, SH_PFC_PIN_CFG_PULL_UP), \ > + PIN_NOGP_CFG(TDI, "TDI", fn, SH_PFC_PIN_CFG_PULL_UP), \ > + PIN_NOGP_CFG(TMS, "TMS", fn, SH_PFC_PIN_CFG_PULL_UP), \ > + PIN_NOGP_CFG(TRST_N, "TRST_N", fn, SH_PFC_PIN_CFG_PULL_UP) > > /* > * F_() : just information > -- > 2.25.1 > -- Regards, Niklas Söderlund