From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 942A1C6FA86 for ; Thu, 8 Sep 2022 16:47:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229943AbiIHQrB (ORCPT ); Thu, 8 Sep 2022 12:47:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229449AbiIHQrA (ORCPT ); Thu, 8 Sep 2022 12:47:00 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 235A9B4E9B; Thu, 8 Sep 2022 09:46:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=qtQp5tdiILv0tGhvoMFeR9PrV87mSTbmJDKlZd+2Xwo=; b=HtKhJIlDKAJ/7ZH7a225FlpstI pLSoQwRGmhUTbEa9FpxQXUgJ8KKyQnjZSl2+gbWF163qf4Kp+/TBap7U+CpunKE/9z1RhKN+MJqCP x7mNm5EUPwoLf9yh/ILb/bp9T7s6WCO74zW9J4enwNCDdQ2jM40ofiq0th8YG6v17yHYf0o+9MUcG 7rCkXOcIvvXmwIqTtz79cwHCarB8Qm8W7iDAATF/jy1o5tEWjXk0ugQ1fR9IJzlb0OjGDVqO07xU4 u1rr9gaYFjNALrBWMs3VOfLFYWGDRM3Tae/Hpg4BxdvZMjZrSmBotW/dGxOclBz0bYf5IacabWd9G 3XmNmVmQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:34206) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oWKfv-0006nM-Gm; Thu, 08 Sep 2022 17:46:47 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1oWKfq-0002DO-Ck; Thu, 08 Sep 2022 17:46:42 +0100 Date: Thu, 8 Sep 2022 17:46:42 +0100 From: "Russell King (Oracle)" To: Sven Peter Cc: Arnd Bergmann , Lee Jones , Linus Walleij , Alyssa Rosenzweig , Andy Shevchenko , asahi@lists.linux.dev, Bartosz Golaszewski , devicetree@vger.kernel.org, Hector Martin , Jonathan Corbet , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, "open list:GPIO SUBSYSTEM" , Petr Mladek , Rasmus Villemoes , Rob Herring , Sergey Senozhatsky , Steven Rostedt Subject: Re: [PATCH 7/7] arm64: dts: apple: Add SMC node to t8103/t6001 devicetrees Message-ID: References: <8a94f2e6-f537-4e29-8375-e79b84524582@www.fastmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8a94f2e6-f537-4e29-8375-e79b84524582@www.fastmail.com> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Tue, Sep 06, 2022 at 03:42:47PM +0200, Sven Peter wrote: > > > On Tue, Sep 6, 2022, at 15:20, Russell King wrote: > > From: Hector Martin > > > > Signed-off-by: Hector Martin > > Signed-off-by: Russell King (Oracle) > > --- > > arch/arm64/boot/dts/apple/t8103.dtsi | 26 ++++++++++++++++++++++++++ > > 1 file changed, 26 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/apple/t8103.dtsi > > b/arch/arm64/boot/dts/apple/t8103.dtsi > > index 51a63b29d404..15c6023cf612 100644 > > --- a/arch/arm64/boot/dts/apple/t8103.dtsi > > +++ b/arch/arm64/boot/dts/apple/t8103.dtsi > > @@ -336,6 +336,32 @@ wdt: watchdog@23d2b0000 { > > interrupts = ; > > }; > > > > + smc_mbox: mbox@23e408000 { > > + compatible = "apple,t8103-asc-mailbox", "apple,asc-mailbox-v4"; > > + reg = <0x2 0x3e408000 0x0 0x4000>; > > + interrupt-parent = <&aic>; > > + interrupts = , > > + , > > + , > > + ; > > + interrupt-names = "send-empty", "send-not-empty", > > + "recv-empty", "recv-not-empty"; > > + #mbox-cells = <0>; > > + }; > > + > > + smc: smc@23e400000 { > > Usually we sort these nodes by their address to prevent merge conflicts. > I guess it doesn't really matter here though since nothing will be between > these two nodes. > Either way, If that's how the nodes should be sorted, let's do it now so we don't end up with another patch that re-ordering this - I've made the change. > Reviewed-by: Sven Peter Thanks! -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!