From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50584C74A5B for ; Wed, 29 Mar 2023 13:55:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229909AbjC2Nzm (ORCPT ); Wed, 29 Mar 2023 09:55:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229708AbjC2Nzm (ORCPT ); Wed, 29 Mar 2023 09:55:42 -0400 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63401C2; Wed, 29 Mar 2023 06:55:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680098141; x=1711634141; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=5I9tE2hnLEdY1WTTcTTJ/HOFXe45bbkHF5No/mcsq4c=; b=eUwYjnuRM+UbCwIIpJvUV09VjfWsMptLUbiAJ0QEKKlW0bmQaG7CAyLY Jibjj5V7zpL8JrAgg+r+7/MQaWCG0fS/+hKZIVdM0JOe6m9mNhXSvDaQG hMySUnWgGWdqBjm4M2rVKyC/bq7Qx/AjQfvGjKz9epmjybCw87u9G/2cG UDf/2aHg0yxBTVOa80T8vY/Sosy96FdmzvWOxFo2x61YD0MxEBsSaLSut CLcKVC6bO4Elo8eTsWGqTiTBZa7bCu8LFgr97+GV5quSc4r03+r7mPxro FgZb1/5fcADUp20n6ZPWVMwYFPm/fpi+gaj+0TIRq1tEJJy6iyP4OLCpf w==; X-IronPort-AV: E=McAfee;i="6600,9927,10664"; a="405824659" X-IronPort-AV: E=Sophos;i="5.98,301,1673942400"; d="scan'208";a="405824659" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2023 06:55:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10664"; a="684271112" X-IronPort-AV: E=Sophos;i="5.98,300,1673942400"; d="scan'208";a="684271112" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga002.jf.intel.com with ESMTP; 29 Mar 2023 06:55:32 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1phWGw-00A38s-2P; Wed, 29 Mar 2023 16:55:30 +0300 Date: Wed, 29 Mar 2023 16:55:30 +0300 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Walleij Subject: Re: [PATCH v1 1/1] gpiolib: Split property name from the warning message Message-ID: References: <20230321135310.73153-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, Mar 29, 2023 at 01:37:16PM +0200, Bartosz Golaszewski wrote: > On Tue, Mar 21, 2023 at 2:52 PM Andy Shevchenko > wrote: ... > > - dev_warn(dev, "gpio-line-names too short (length %d), cannot map names for the gpiochip at offset %u\n", > > - count, chip->offset); > > + dev_warn(dev, "%s too short (length %d), cannot map names for the gpiochip at offset %u\n", > > + "gpio-line-names", count, chip->offset); > > return 0; > > } > > I'd say being able to grep the code easily for messages is more > important than saving a couple bytes here? We still grep by the rest of the message. But anyway, up to you, I've no hard feelings to this patch. -- With Best Regards, Andy Shevchenko