From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 842CDC7618A for ; Mon, 20 Mar 2023 11:07:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229774AbjCTLG7 (ORCPT ); Mon, 20 Mar 2023 07:06:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229877AbjCTLGb (ORCPT ); Mon, 20 Mar 2023 07:06:31 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AEA20252AA for ; Mon, 20 Mar 2023 04:01:37 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id k37so1404419lfv.0 for ; Mon, 20 Mar 2023 04:01:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679310094; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KV3kkcZfdeiVUi9v9t89pEf4D/a17ZWSTdxw83QbO4w=; b=x2wH4rX8OQawmcsvI25abb6SUD3Ez/ROJb7xcQ0KSWKQNMBKkBBxL9xYqw4WGJtRFr 5zt8LL7y8o2hcgLZgkbnMyk9tjEpBJlsMVpgHZUshCqwWAHhC4RXaYe1beFN460bpRSv 6C42OCeQeRGL93W4mroZmtmFT5CUaI4VTd38BgMjjbt6Z9S/Gllx3ZiPQsdBub6zBuKe uyTttcchDGuo+263vaA8vr7zxP0rKPxUMLJhWpSiC3r7VFw56cDlWRwD/Djo06e/4aeb g6ywhB9sUF476sLwro3szKIOiNr/ce/zeTABsw99BdqGgVKl9kDqslK2DosBuwab6liv 7BCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679310094; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KV3kkcZfdeiVUi9v9t89pEf4D/a17ZWSTdxw83QbO4w=; b=3Cd4d10Pibp9kvMFuEBT06OQUsmCTp+CLMJsPW8J9DRyJT/G8MDy6pF+yOndVHgPa1 8mcvTsxXaJlvlwDzsyM6rgVtXSaPOhme411HwmFD6S3+6hwhwlEhWZkjMaWxJ37uIgiV 0glHTJzox7iTZuyrwGISh9OiErcgCm/yonwdP5qvtsjO/QoZy4ynrPupJxPT5kMDWhXm ADVnPD833+w20h+5F2A9TpTKy7p2ed/CufxkkVSWczJN4ZD8uo/n26/pwMNv5CvWRBGZ beLLX8O3PMkWBPciCO4L2x4JD3bwrVmGuFHsxI6nhaQxWfImdte7i9b/crrIvoUCTzAh d77A== X-Gm-Message-State: AO0yUKUHEh87GXErv9mAFV19WIBYUlfKNWDi1eNzukNzYt/BqFvuWsku 6J4YTUiiaMJcTbd2KnR3Xlpa8g== X-Google-Smtp-Source: AK7set9bIwd0efybryR+Sa+q7avGV4AtAky6AdRGrX0WmP9KUmOK/yXt6JEyMlQLo7vek6dyh/lHDQ== X-Received: by 2002:a19:ac08:0:b0:4ea:4793:facf with SMTP id g8-20020a19ac08000000b004ea4793facfmr553439lfc.13.1679310094482; Mon, 20 Mar 2023 04:01:34 -0700 (PDT) Received: from [192.168.1.101] (abym238.neoplus.adsl.tpnet.pl. [83.9.32.238]) by smtp.gmail.com with ESMTPSA id n7-20020ac24907000000b004e85f7ec749sm1648310lfi.117.2023.03.20.04.01.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Mar 2023 04:01:34 -0700 (PDT) Message-ID: Date: Mon, 20 Mar 2023 12:01:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 08/14] arm64: dts: qcom: sa8775p: pmic: add the power key Content-Language: en-US To: Bartosz Golaszewski Cc: Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski References: <20230314183043.619997-1-brgl@bgdev.pl> <20230314183043.619997-9-brgl@bgdev.pl> <8ed14d64-f75b-b129-ad7b-0d3290de7738@linaro.org> From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 20.03.2023 11:52, Bartosz Golaszewski wrote: > On Tue, Mar 14, 2023 at 9:26 PM Konrad Dybcio wrote: >> >> >> >> On 14.03.2023 19:30, Bartosz Golaszewski wrote: >>> From: Bartosz Golaszewski >>> >>> Add the power key node under the PON node for PMIC #0 on sa8775p. >>> >>> Signed-off-by: Bartosz Golaszewski >>> --- >>> arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi | 7 +++++++ >>> 1 file changed, 7 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi >>> index 5d73212fbd16..874460d087db 100644 >>> --- a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi >>> @@ -18,6 +18,13 @@ pmk8775_0_pon: pon@1200 { >>> reg = <0x1200>, <0x800>; >>> mode-recovery = <0x1>; >>> mode-bootloader = <0x2>; >>> + >>> + pmk8775_0_pon_pwrkey: pwrkey { >>> + compatible = "qcom,pmk8350-pwrkey"; >>> + interrupts-extended = <&spmi_bus 0x0 0x12 0x7 IRQ_TYPE_EDGE_BOTH>; >>> + linux,code = ; >>> + status = "disabled"; >> Does it make any sense to disable the power button? >> > > Since this is an automotive platform, I'd say yes - you wouldn't > normally have physical access to the board or even be sure for it to > have a power button? On Qualcomm platforms there's little different ways to turn on the device short of giving it DC power (though that may also be config dependent), so I'd expect *something* would be connected to PON_PWR.. >But if you prefer it the other way, I won't be > dying on this hill. Yeah if you could, please leave it on (unless somebody has strong arguments against that) Konrad > > Bart > >> Konrad >>> + }; >>> }; >>> }; >>>