Linux-GPIO Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH -next] gpiolib: of: Make of_gpio_spi_cs_get_count static
@ 2019-11-29  8:53 YueHaibing
  2019-11-29  9:46 ` Linus Walleij
  0 siblings, 1 reply; 5+ messages in thread
From: YueHaibing @ 2019-11-29  8:53 UTC (permalink / raw)
  To: linus.walleij, bgolaszewski; +Cc: linux-gpio, linux-kernel, YueHaibing

Fix sparse warning:

drivers/gpio/gpiolib-of.c:35:5: warning: symbol 'of_gpio_spi_cs_get_count' was not declared. Should it be static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/gpio/gpiolib-of.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
index 610c6622f62d..b696e4598a24 100644
--- a/drivers/gpio/gpiolib-of.c
+++ b/drivers/gpio/gpiolib-of.c
@@ -32,7 +32,7 @@
  * the counting of "cs-gpios" to count "gpios" transparent to the
  * driver.
  */
-int of_gpio_spi_cs_get_count(struct device *dev, const char *con_id)
+static int of_gpio_spi_cs_get_count(struct device *dev, const char *con_id)
 {
 	struct device_node *np = dev->of_node;
 
-- 
2.20.1



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH -next] gpiolib: of: Make of_gpio_spi_cs_get_count static
  2019-11-29  8:53 [PATCH -next] gpiolib: of: Make of_gpio_spi_cs_get_count static YueHaibing
@ 2019-11-29  9:46 ` Linus Walleij
  2019-11-29  9:53   ` Yuehaibing
  2019-11-30  1:28   ` [PATCH v2 " YueHaibing
  0 siblings, 2 replies; 5+ messages in thread
From: Linus Walleij @ 2019-11-29  9:46 UTC (permalink / raw)
  To: YueHaibing, Mark Brown
  Cc: Bartosz Golaszewski, open list:GPIO SUBSYSTEM, linux-kernel

On Fri, Nov 29, 2019 at 9:53 AM YueHaibing <yuehaibing@huawei.com> wrote:

> Fix sparse warning:
>
> drivers/gpio/gpiolib-of.c:35:5: warning: symbol 'of_gpio_spi_cs_get_count' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Mark merged my patch causing this warning into the SPI tree,
would you mind resending it to him including my Reviewed-by tag
and a note to apply it to the SPI tree?

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH -next] gpiolib: of: Make of_gpio_spi_cs_get_count static
  2019-11-29  9:46 ` Linus Walleij
@ 2019-11-29  9:53   ` Yuehaibing
  2019-11-30  1:28   ` [PATCH v2 " YueHaibing
  1 sibling, 0 replies; 5+ messages in thread
From: Yuehaibing @ 2019-11-29  9:53 UTC (permalink / raw)
  To: Linus Walleij, Mark Brown
  Cc: Bartosz Golaszewski, open list:GPIO SUBSYSTEM, linux-kernel

On 2019/11/29 17:46, Linus Walleij wrote:
> On Fri, Nov 29, 2019 at 9:53 AM YueHaibing <yuehaibing@huawei.com> wrote:
> 
>> Fix sparse warning:
>>
>> drivers/gpio/gpiolib-of.c:35:5: warning: symbol 'of_gpio_spi_cs_get_count' was not declared. Should it be static?
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> 
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> 
> Mark merged my patch causing this warning into the SPI tree,
> would you mind resending it to him including my Reviewed-by tag
> and a note to apply it to the SPI tree?

Ok, will resend it.
> 
> Yours,
> Linus Walleij
> 
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v2 -next] gpiolib: of: Make of_gpio_spi_cs_get_count static
  2019-11-29  9:46 ` Linus Walleij
  2019-11-29  9:53   ` Yuehaibing
@ 2019-11-30  1:28   ` " YueHaibing
  2019-12-03 13:59     ` Applied "gpiolib: of: Make of_gpio_spi_cs_get_count static" to the spi tree Mark Brown
  1 sibling, 1 reply; 5+ messages in thread
From: YueHaibing @ 2019-11-30  1:28 UTC (permalink / raw)
  To: linus.walleij, bgolaszewski, broonie
  Cc: linux-gpio, linux-kernel, linux-spi, YueHaibing

Fix sparse warning:

drivers/gpio/gpiolib-of.c:35:5: warning:
 symbol 'of_gpio_spi_cs_get_count' was not declared. Should it be static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
---
v2: This is caused by commit 71b8f600b034 ("gpio: Handle counting of Freescale chipselects"),
	should be applied to spi tree.
---
 drivers/gpio/gpiolib-of.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
index 610c6622f62d..b696e4598a24 100644
--- a/drivers/gpio/gpiolib-of.c
+++ b/drivers/gpio/gpiolib-of.c
@@ -32,7 +32,7 @@
  * the counting of "cs-gpios" to count "gpios" transparent to the
  * driver.
  */
-int of_gpio_spi_cs_get_count(struct device *dev, const char *con_id)
+static int of_gpio_spi_cs_get_count(struct device *dev, const char *con_id)
 {
 	struct device_node *np = dev->of_node;
 
-- 
2.20.1



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Applied "gpiolib: of: Make of_gpio_spi_cs_get_count static" to the spi tree
  2019-11-30  1:28   ` [PATCH v2 " YueHaibing
@ 2019-12-03 13:59     ` Mark Brown
  0 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2019-12-03 13:59 UTC (permalink / raw)
  To: YueHaibing
  Cc: bgolaszewski, broonie, Hulk Robot, linus.walleij, linux-gpio,
	linux-kernel, linux-spi, Mark Brown

The patch

   gpiolib: of: Make of_gpio_spi_cs_get_count static

has been applied to the spi tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.5

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

From a1f4c96b799b80118b50bd47320deb9013b7ff40 Mon Sep 17 00:00:00 2001
From: YueHaibing <yuehaibing@huawei.com>
Date: Sat, 30 Nov 2019 09:28:28 +0800
Subject: [PATCH] gpiolib: of: Make of_gpio_spi_cs_get_count static

Fix sparse warning:

drivers/gpio/gpiolib-of.c:35:5: warning:
 symbol 'of_gpio_spi_cs_get_count' was not declared. Should it be static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20191130012828.14504-1-yuehaibing@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/gpio/gpiolib-of.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
index 4b19e7e26b90..f90a161ca97a 100644
--- a/drivers/gpio/gpiolib-of.c
+++ b/drivers/gpio/gpiolib-of.c
@@ -32,7 +32,7 @@
  * the counting of "cs-gpios" to count "gpios" transparent to the
  * driver.
  */
-int of_gpio_spi_cs_get_count(struct device *dev, const char *con_id)
+static int of_gpio_spi_cs_get_count(struct device *dev, const char *con_id)
 {
 	struct device_node *np = dev->of_node;
 
-- 
2.20.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-29  8:53 [PATCH -next] gpiolib: of: Make of_gpio_spi_cs_get_count static YueHaibing
2019-11-29  9:46 ` Linus Walleij
2019-11-29  9:53   ` Yuehaibing
2019-11-30  1:28   ` [PATCH v2 " YueHaibing
2019-12-03 13:59     ` Applied "gpiolib: of: Make of_gpio_spi_cs_get_count static" to the spi tree Mark Brown

Linux-GPIO Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-gpio/0 linux-gpio/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-gpio linux-gpio/ https://lore.kernel.org/linux-gpio \
		linux-gpio@vger.kernel.org
	public-inbox-index linux-gpio

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-gpio


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git