Linux-GPIO Archive on lore.kernel.org
 help / color / Atom feed
From: Sungbo Eo <mans0n@gorani.run>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-gpio <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] gpio: add GPO driver for PCA9570
Date: Wed, 1 Jul 2020 01:11:16 +0900
Message-ID: <c7fd2365-0f47-b2c8-4085-020928c79254@gorani.run> (raw)
In-Reply-To: <CAHp75VdNh8nFNqZxSD0g7ADD8GvY+Dmbfg8xc6LW94hw_Brwew@mail.gmail.com>

Thanks for all the reviews! I've updated the patch, please have a look.

And I have something to ask.

# echo 1 > gpio408/value
# cat gpio408/value
cat: read error: I/O error
# cat gpio408/direction
out
# echo out > gpio408/direction
# echo in > gpio408/direction
[   91.006691] gpio-408 (sysfs): gpiod_direction_input: missing get() 
but have direction_input()
ash: write error: I/O error

I've never dealt with GPO expander before, so this seems a bit odd to me.
Is it perfectly okay to leave get() and direction_input() unimplemented?

Thanks.

On 2020-06-30 18:53, Andy Shevchenko wrote:
> On Tue, Jun 30, 2020 at 12:28 PM Bartosz Golaszewski
> <bgolaszewski@baylibre.com> wrote:
>> On Thu, Jun 25, 2020 at 9:58 AM Sungbo Eo <mans0n@gorani.run> wrote:
> 
>>> +static const struct of_device_id pca9570_of_match_table[] = {
>>> +       { .compatible = "nxp,pca9570" },
>>> +       { /* sentinel */ }
>>> +};
>>> +MODULE_DEVICE_TABLE(of, pca9570_of_match_table);
>>
>> If you're not using it in probe than maybe move it next to the I2C device table?
> 
> (Side note)
> ...and even if so it can be assessed via a struct device pointer:
> dev->driver->id_table (don't remember by heart, but you have an idea).
> 

  reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-25  7:58 Sungbo Eo
2020-06-25  8:59 ` Andy Shevchenko
2020-06-25 14:43 ` kernel test robot
2020-06-25 16:38 ` kernel test robot
2020-06-30  9:18 ` Bartosz Golaszewski
2020-06-30  9:53   ` Andy Shevchenko
2020-06-30 16:11     ` Sungbo Eo [this message]
2020-06-30 21:23       ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c7fd2365-0f47-b2c8-4085-020928c79254@gorani.run \
    --to=mans0n@gorani.run \
    --cc=andy.shevchenko@gmail.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-GPIO Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-gpio/0 linux-gpio/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-gpio linux-gpio/ https://lore.kernel.org/linux-gpio \
		linux-gpio@vger.kernel.org
	public-inbox-index linux-gpio

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-gpio


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git