From: Robert Hancock <hancock@sedsystems.ca>
To: Linus Walleij <linus.walleij@linaro.org>,
Michal Simek <michal.simek@xilinx.com>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Srinivas Neeli <srinivas.neeli@xilinx.com>
Subject: Re: [PATCH v2] gpio: xilinx: Add interrupt support
Date: Tue, 7 Jul 2020 10:16:31 -0600 [thread overview]
Message-ID: <d7313b79-1fcd-d04d-fdae-cae1c8c5c233@sedsystems.ca> (raw)
In-Reply-To: <CACRpkda0MOXHgD6KNAzzDNTFSc2f1_Nng8-UFuOGo-dm+6VS0g@mail.gmail.com>
On 2020-07-07 5:09 a.m., Linus Walleij wrote:
> On Thu, Jun 11, 2020 at 6:51 PM Robert Hancock <hancock@sedsystems.ca> wrote:
>
>> Adds interrupt support to the Xilinx GPIO driver so that rising and
>> falling edge line events can be supported. Since interrupt support is
>> an optional feature in the Xilinx IP, the driver continues to support
>> devices which have no interrupt provided.
>>
>> These changes are based on a patch in the Xilinx Linux Git tree,
>> "gpio: xilinx: Add irq support to the driver" from Srinivas Neeli, but
>> include a number of fixes and improvements such as supporting both
>> rising and falling edge events.
>>
>> Signed-off-by: Robert Hancock <hancock@sedsystems.ca>
>> ---
>>
>> Changes from v1: Changed platform_get_irq to platform_get_irq_optional
>
> Looks good to me, two questions:
>
> - Can you make sure that this applies to the GPIO "devel" branch
> that has the previous changes from Srinivas.
I confirmed it applies without conflicts and builds on that branch - it
doesn't appear that it has any changes to this driver that were not in
the version I submitted against.
>
> - Can we get a Tested-by or at least ACK from Srinivas?
>
> This driver currently lacks a maintainer. I would be very happy if
> Srinivas or Robert or both would send a patch to add you as
> maintainer(s) in the MAINTAINERS file, and would also like
> Michal to to ACK that so everyone is happy.
Probably Srinivas or someone from Xilinx should be the primary
maintainer of this driver, but I could add myself in if they don't..
>
> Yours,
> Linus Walleij
>
--
Robert Hancock
Senior Hardware Designer
SED Systems, a division of Calian Ltd.
Email: hancock@sedsystems.ca
next prev parent reply other threads:[~2020-07-07 16:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 16:49 [PATCH v2] gpio: xilinx: Add interrupt support Robert Hancock
2020-06-18 16:56 ` Srinivas Neeli
2020-07-07 11:09 ` Linus Walleij
2020-07-07 16:16 ` Robert Hancock [this message]
2020-07-08 11:20 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7313b79-1fcd-d04d-fdae-cae1c8c5c233@sedsystems.ca \
--to=hancock@sedsystems.ca \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=srinivas.neeli@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).