Linux-GPIO Archive on lore.kernel.org
 help / color / Atom feed
From: Maulik Shah <mkshah@codeaurora.org>
To: Marc Zyngier <maz@kernel.org>
Cc: bjorn.andersson@linaro.org, linus.walleij@linaro.org,
	swboyd@chromium.org, evgreen@chromium.org, mka@chromium.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-gpio@vger.kernel.org, agross@kernel.org,
	tglx@linutronix.de, jason@lakedaemon.net, dianders@chromium.org,
	rnayak@codeaurora.org, ilina@codeaurora.org,
	lsrao@codeaurora.org
Subject: Re: [PATCH 1/4] gpio: gpiolib: Allow GPIO IRQs to lazy disable
Date: Sat, 23 May 2020 22:36:51 +0530
Message-ID: <e08c9f6e-0e84-5f2a-766d-7a1c45bd977a@codeaurora.org> (raw)
In-Reply-To: <5888fc645d26b4780e9d9c6fd582374f@kernel.org>

Hi,

On 5/23/2020 3:12 PM, Marc Zyngier wrote:
> On 2020-05-22 14:19, Maulik Shah wrote:
>> With 'commit 461c1a7d4733 ("gpiolib: override irq_enable/disable")' 
>> gpiolib
>> overrides irqchip's irq_enable and irq_disable callbacks. If irq_disable
>> callback is implemented then genirq takes unlazy path to disable irq.
>>
>> Underlying irqchip may not want to implement irq_disable callback to 
>> lazy
>> disable irq when client drivers invokes disable_irq(). By overriding
>> irq_disable callback, gpiolib ends up always unlazy disabling IRQ.
>>
>> Allow gpiolib to lazy disable IRQs by overriding irq_disable callback 
>> only
>> if irqchip implemented irq_disable. In cases where irq_disable is not
>> implemented irq_mask is overridden. Similarly override irq_enable 
>> callback
>> only if irqchip implemented irq_enable otherwise irq_unmask is 
>> overridden.
>>
>> Fixes: 461c1a7d47 (gpiolib: override irq_enable/disable)
>> Signed-off-by: Maulik Shah <mkshah@codeaurora.org>
>> ---
>>  drivers/gpio/gpiolib.c      | 59 
>> +++++++++++++++++++++++++++++----------------
>>  include/linux/gpio/driver.h | 13 ++++++++++
>>  2 files changed, 51 insertions(+), 21 deletions(-)
>>
>> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
>> index eaa0e20..a8fdc74 100644
>> --- a/drivers/gpio/gpiolib.c
>> +++ b/drivers/gpio/gpiolib.c
>> @@ -2465,33 +2465,38 @@ static void gpiochip_irq_relres(struct 
>> irq_data *d)
>>      gpiochip_relres_irq(gc, d->hwirq);
>>  }
>>
>> +static void gpiochip_irq_mask(struct irq_data *d)
>> +{
>> +    struct gpio_chip *chip = irq_data_get_irq_chip_data(d);
>> +
>> +    if (chip->irq.irq_mask)
>> +        chip->irq.irq_mask(d);
>> +    gpiochip_disable_irq(chip, d->hwirq);
>> +}
>> +
>> +static void gpiochip_irq_unmask(struct irq_data *d)
>> +{
>> +    struct gpio_chip *chip = irq_data_get_irq_chip_data(d);
>> +
>> +    gpiochip_enable_irq(chip, d->hwirq);
>> +    if (chip->irq.irq_unmask)
>> +        chip->irq.irq_unmask(d);
>> +}
>> +
>>  static void gpiochip_irq_enable(struct irq_data *d)
>>  {
>>      struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
>>
>> -    gpiochip_enable_irq(gc, d->hwirq);
>> -    if (gc->irq.irq_enable)
>> -        gc->irq.irq_enable(d);
>> -    else
>> -        gc->irq.chip->irq_unmask(d);
>> +    gpiochip_enable_irq(chip, d->hwirq);
>
> You really never compiled this, did you?
>
> I've stopped looking at this. Please send something that you will have 
> actually tested.
>
>         M.

Apologies.

I did tested out on internal devices based on kernel 5.4 as well as 
linux-next with sc7180.

While posting i somehow taken patch from kernel 5.4 and messed up this 
patch during merge conflicts.

I fixed this in v2 and posted out changes that cleanly applies on latest 
linux-next tag (next-20200521).

Thanks,
Maulik

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation


  reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-22 13:19 [PATCH 0/4] irqchip: qcom: pdc: Introduce irq_set_wake call Maulik Shah
2020-05-22 13:19 ` [PATCH 1/4] gpio: gpiolib: Allow GPIO IRQs to lazy disable Maulik Shah
2020-05-23  9:42   ` Marc Zyngier
2020-05-23 17:06     ` Maulik Shah [this message]
2020-05-23 12:30   ` kbuild test robot
2020-05-22 13:19 ` [PATCH 2/4] pinctrl: qcom: Remove irq_disable callback from msmgpio irqchip Maulik Shah
2020-05-22 13:19 ` [PATCH 3/4] pinctrl: qcom: Add msmgpio irqchip flags Maulik Shah
2020-05-22 13:19 ` [PATCH 4/4] irqchip: qcom-pdc: Introduce irq_set_wake call Maulik Shah
2020-05-25 11:34 ` [PATCH 0/4] irqchip: qcom: pdc: " Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e08c9f6e-0e84-5f2a-766d-7a1c45bd977a@codeaurora.org \
    --to=mkshah@codeaurora.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=dianders@chromium.org \
    --cc=evgreen@chromium.org \
    --cc=ilina@codeaurora.org \
    --cc=jason@lakedaemon.net \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lsrao@codeaurora.org \
    --cc=maz@kernel.org \
    --cc=mka@chromium.org \
    --cc=rnayak@codeaurora.org \
    --cc=swboyd@chromium.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-GPIO Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-gpio/0 linux-gpio/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-gpio linux-gpio/ https://lore.kernel.org/linux-gpio \
		linux-gpio@vger.kernel.org
	public-inbox-index linux-gpio

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-gpio


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git