From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A40C4C0650F for ; Mon, 12 Aug 2019 00:51:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 51D6120663 for ; Mon, 12 Aug 2019 00:51:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=aj.id.au header.i=@aj.id.au header.b="OQek2Bg6"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="l4EgbgtF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726164AbfHLAv4 (ORCPT ); Sun, 11 Aug 2019 20:51:56 -0400 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:58985 "EHLO wout3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726144AbfHLAv4 (ORCPT ); Sun, 11 Aug 2019 20:51:56 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id A1B5321E; Sun, 11 Aug 2019 20:51:54 -0400 (EDT) Received: from imap2 ([10.202.2.52]) by compute4.internal (MEProxy); Sun, 11 Aug 2019 20:51:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm3; bh=/vRZS0DH6BibYTI+jPSXeATx8DCWgvz KB2bf68zgCYQ=; b=OQek2Bg6nPx+MsQpoORrSMQGYewK50sRAfUejX06ZLWlOBG gn7XgbylvKurPPS5ys0R5IVfpXhTFMDXdWyX0mKClfr7T75O5bD3f7IJCU8Gh1s9 YLSS1rsgbUsk6QfhyFv/srD+1BbDXgAD/89Y6r5vMCbhP9aHbxgE3KuY82EDN/lr ZvhX5WsHp78jWXRxsr1DhvuTJ+Kwk7Fe9op7n1PpfNiGdGVukF2WR1N6g33Be3Vc bM/HCQrRjmhxp7v/owwpJezKnNwEDyY3ZcYKrLEIXy9CSCRiHnaPJmHKzW+D760P DtNmt1qWG4i9DP9UQQSYbunB5/D26fewO9BxAow== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=/vRZS0 DH6BibYTI+jPSXeATx8DCWgvzKB2bf68zgCYQ=; b=l4EgbgtFwY2Rpc1UyNz2W+ SVRmVfLyLc4sGVwItuaAv9LJ/jyolnlF5S9783mgLebzuLBhoA29b1mfBtjfXlts nt6Qa/vDIhZUFwfSEXXitbVgP54MPr45swxOvFlpy1+X3/48Sn0flYvsdCrocClv MS3KOs2ZS3tyoY8zAwtSmlqSnwXglqStBVKdLy+19+/SJEqTHkK1H2fie7Hp1zmr s/KUU61alWy7z+Exs29OZunIrAoHKqq2YxK/idCRFkgRJ9dDk7/GeUA6L/jk0Y2V rtlWVclnKR7Ik144F39sFM0Y3e3Uk4/gh97MJmSnTUM/2RfPfMPFeW61hPmPH+9A == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddruddvfedggeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesthdtredtreerjeenucfhrhhomhepfdetnhgu rhgvficulfgvfhhfvghrhidfuceorghnughrvgifsegrjhdrihgurdgruheqnecuffhomh grihhnpehgihhthhhusgdrtghomhenucfrrghrrghmpehmrghilhhfrhhomheprghnughr vgifsegrjhdrihgurdgruhenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 0A5CCE00A2; Sun, 11 Aug 2019 20:51:52 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.1.6-809-g8e5c451-fmstable-20190809v1 Mime-Version: 1.0 Message-Id: In-Reply-To: References: <20190807003037.48457-1-natechancellor@gmail.com> Date: Mon, 12 Aug 2019 10:21:55 +0930 From: "Andrew Jeffery" To: "Linus Walleij" , "Nathan Chancellor" Cc: "Joel Stanley" , linux-aspeed , "OpenBMC Maillist" , "open list:GPIO SUBSYSTEM" , "Linux ARM" , "linux-kernel@vger.kernel.org" , clang-built-linux@googlegroups.com Subject: =?UTF-8?Q?Re:_[PATCH]_pinctrl:_aspeed:_g6:_Remove_const_specifier_from_a?= =?UTF-8?Q?speed=5Fg6=5Fsig=5Fexpr=5Fset's_ctx_parameter?= Content-Type: text/plain Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Sat, 10 Aug 2019, at 17:43, Linus Walleij wrote: > On Wed, Aug 7, 2019 at 2:32 AM Nathan Chancellor > wrote: > > > clang errors: > > > > drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c:2325:9: error: incompatible > > pointer types initializing 'int (*)(struct aspeed_pinmux_data *, const > > struct aspeed_sig_expr *, bool)' with an expression of type 'int (const > > struct aspeed_pinmux_data *, const struct aspeed_sig_expr *, bool)' > > [-Werror,-Wincompatible-pointer-types] > > .set = aspeed_g6_sig_expr_set, > > ^~~~~~~~~~~~~~~~~~~~~~ > > 1 error generated. > > > > Commit 674fa8daa8c9 ("pinctrl: aspeed-g5: Delay acquisition of regmaps") > > changed the set function pointer declaration and the g6 one wasn't > > updated (I assume because it wasn't merged yet). > > > > Fixes: 2eda1cdec49f ("pinctrl: aspeed: Add AST2600 pinmux support") > > Link: https://github.com/ClangBuiltLinux/linux/issues/632 > > Signed-off-by: Nathan Chancellor > > Patch applied with Andrew's ACK. FYI this fixes pinctrl/for-next which is likely where Nathan ran into the issue, however to fix pinctrl/devel we'll need a back-merge of pinctrl/fixes, or to apply 674fa8daa8c9 ("pinctrl: aspeed-g5: Delay acquisition of regmaps") to pinctrl/devel also. Fixing that bug was unfortunate timing wrt the 2600 driver. Andrew