From: Michael Schmitz <schmitzmic@gmail.com>
To: Stefan Wahren <wahrenst@gmx.net>,
Geert Uytterhoeven <geert@linux-m68k.org>
Cc: kbuild-all@01.org,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
linux-m68k <linux-m68k@lists.linux-m68k.org>
Subject: Re: [pinctrl:devel 16/46] drivers/pinctrl/bcm/pinctrl-bcm2835.c:995:10: error: incompatible types when assigning to type 'volatile struct SHIFTER' from type 'unsigned int'
Date: Mon, 12 Aug 2019 09:13:21 +1200 [thread overview]
Message-ID: <f1032537-aba1-7db2-2651-b9c6f27445ce@gmail.com> (raw)
In-Reply-To: <0ef2d73b-c815-e3e7-a037-db7672bbb413@gmx.net>
Stefan,
considering that such a clash could happen again, it might be prudent to
use a less generic name in your driver as well?
Leaves the matter of who prepares a patch to atarihw.h and users of that
definition ...
Cheers,
Michael
Am 12.08.19 um 09:01 schrieb Stefan Wahren:
> Hi,
>
> Am 07.08.19 um 00:41 schrieb Michael Schmitz:
>> Hi Geert,
>>
>> could be renamed shifter_st, I suppose. Only used in
>> arch/m68k/atari/config.c and drivers/video/fbdev/atafb.c.
> looks like you've come to a solution. Is there any action required from
> my side?
>
> Regards
> Stefan
>
>> Cheers,
>>
>> Michael
next prev parent reply other threads:[~2019-08-11 21:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 2:56 [pinctrl:devel 16/46] drivers/pinctrl/bcm/pinctrl-bcm2835.c:995:10: error: incompatible types when assigning to type 'volatile struct SHIFTER' from type 'unsigned int' kbuild test robot
2019-08-06 7:33 ` Geert Uytterhoeven
2019-08-06 22:41 ` Michael Schmitz
2019-08-07 6:50 ` Geert Uytterhoeven
2019-08-11 21:01 ` Stefan Wahren
2019-08-11 21:13 ` Michael Schmitz [this message]
2019-08-12 7:31 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1032537-aba1-7db2-2651-b9c6f27445ce@gmail.com \
--to=schmitzmic@gmail.com \
--cc=geert@linux-m68k.org \
--cc=kbuild-all@01.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).