linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	Kuppuswamy Sathyanarayanan 
	<sathyanarayanan.kuppuswamy@linux.intel.com>
Subject: Re: [PATCH v2] gpio: crystalcove: Use irqchip template
Date: Wed, 22 Jul 2020 10:56:24 +0200	[thread overview]
Message-ID: <f8c609a2-30cf-dd4b-c956-1d90af9cdf02@redhat.com> (raw)
In-Reply-To: <20200721153936.GL3703480@smile.fi.intel.com>

Hi,

On 7/21/20 5:39 PM, Andy Shevchenko wrote:
> On Tue, Jul 21, 2020 at 04:01:53PM +0200, Linus Walleij wrote:
>> This makes the driver use the irqchip template to assign
>> properties to the gpio_irq_chip instead of using the
>> explicit calls to gpiochip_irqchip_add_nested() and
>> gpiochip_set_nested_irqchip(). The irqchip is instead
>> added while adding the gpiochip.
> 
> Took this version instead.
> 
> I dunno if Hans can come with some comments / testing results, I would like to
> send a PR today or tomorrow.

Sorry for being a bit slow with testing this.

I've given this patch a test-run on a machine with the
PMIC the driver is for and with the caveat that I've not
actually tested the GPIO IRQ functionality, since that
does not seem to be used on any machines, I see no adverse
side effects from this patch, so it is:

Tested-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans


  parent reply	other threads:[~2020-07-22  8:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-21 14:01 [PATCH v2] gpio: crystalcove: Use irqchip template Linus Walleij
2020-07-21 15:39 ` Andy Shevchenko
2020-07-21 15:58   ` Andy Shevchenko
2020-07-22  8:56   ` Hans de Goede [this message]
2020-07-22  8:59     ` Andy Shevchenko
2020-07-22  9:00       ` Andy Shevchenko
2020-07-21 17:08 ` Kuppuswamy, Sathyanarayanan
2020-07-21 21:54   ` Andy Shevchenko
2020-07-21 22:05     ` Kuppuswamy, Sathyanarayanan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f8c609a2-30cf-dd4b-c956-1d90af9cdf02@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=sathyanarayanan.kuppuswamy@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).