From: Alexander Sverdlin <alexander.sverdlin@gmail.com>
To: Nikita Shubin <nikita.shubin@maquefel.me>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 7/7] gpiod: ep93xx: refactor base IRQ number
Date: Thu, 28 Jan 2021 19:30:14 +0100 [thread overview]
Message-ID: <f964e132200b9e952a3ad424c5fa82f9d1bf74f1.camel@gmail.com> (raw)
In-Reply-To: <20210128122123.25341-8-nikita.shubin@maquefel.me>
Hi!
On Thu, 2021-01-28 at 15:21 +0300, Nikita Shubin wrote:
> - use predefined constants instead of plain numbers
> - use provided bank IRQ number instead of defined constant
> for port F
>
> Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
Acked-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
> ---
> drivers/gpio/gpio-ep93xx.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpio/gpio-ep93xx.c b/drivers/gpio/gpio-ep93xx.c
> index df55aa13bd9a..b1501607e8ed 100644
> --- a/drivers/gpio/gpio-ep93xx.c
> +++ b/drivers/gpio/gpio-ep93xx.c
> @@ -28,6 +28,8 @@
> /* Maximum value for irq capable line identifiers */
> #define EP93XX_GPIO_LINE_MAX_IRQ 23
>
> +#define EP93XX_GPIO_A_IRQ_BASE 64
> +#define EP93XX_GPIO_B_IRQ_BASE 72
> /*
> * Static mapping of GPIO bank F IRQS:
> * F0..F7 (16..24) to irq 80..87.
> @@ -311,14 +313,14 @@ struct ep93xx_gpio_bank {
>
> static struct ep93xx_gpio_bank ep93xx_gpio_banks[] = {
> /* Bank A has 8 IRQs */
> - EP93XX_GPIO_BANK("A", 0x00, 0x10, 0, true, false, 64),
> + EP93XX_GPIO_BANK("A", 0x00, 0x10, 0, true, false,
> EP93XX_GPIO_A_IRQ_BASE),
> /* Bank B has 8 IRQs */
> - EP93XX_GPIO_BANK("B", 0x04, 0x14, 8, true, false, 72),
> + EP93XX_GPIO_BANK("B", 0x04, 0x14, 8, true, false,
> EP93XX_GPIO_B_IRQ_BASE),
> EP93XX_GPIO_BANK("C", 0x08, 0x18, 40, false, false, 0),
> EP93XX_GPIO_BANK("D", 0x0c, 0x1c, 24, false, false, 0),
> EP93XX_GPIO_BANK("E", 0x20, 0x24, 32, false, false, 0),
> /* Bank F has 8 IRQs */
> - EP93XX_GPIO_BANK("F", 0x30, 0x34, 16, false, true, 0),
> + EP93XX_GPIO_BANK("F", 0x30, 0x34, 16, false, true,
> EP93XX_GPIO_F_IRQ_BASE),
> EP93XX_GPIO_BANK("G", 0x38, 0x3c, 48, false, false, 0),
> EP93XX_GPIO_BANK("H", 0x40, 0x44, 56, false, false, 0),
> };
> @@ -414,7 +416,7 @@ static int ep93xx_gpio_add_bank(struct gpio_chip
> *gc,
> /* Pick resources 1..8 for these IRQs */
> for (i = 0; i < girq->num_parents; i++) {
> girq->parents[i] = platform_get_irq(pdev, i +
> 1);
> - gpio_irq = EP93XX_GPIO_F_IRQ_BASE + i;
> + gpio_irq = bank->irq_base + i;
> irq_set_chip_data(gpio_irq, &epg->gc[5]);
> irq_set_chip_and_handler(gpio_irq,
>
> &ep93xx_gpio_irq_chip,
> @@ -423,7 +425,7 @@ static int ep93xx_gpio_add_bank(struct gpio_chip
> *gc,
> }
> girq->default_type = IRQ_TYPE_NONE;
> girq->handler = handle_level_irq;
> - girq->first = EP93XX_GPIO_F_IRQ_BASE;
> + girq->first = bank->irq_base;
> }
>
> return devm_gpiochip_add_data(dev, gc, epg);
--
Alexander Sverdlin.
next prev parent reply other threads:[~2021-01-28 18:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 12:21 [PATCH v3 0/7] gpio: ep93xx: fixes series patch Nikita Shubin
2021-01-28 12:21 ` [PATCH v3 1/7] gpio: gpio-ep93xx: fix BUG_ON port F usage Nikita Shubin
2021-01-28 16:11 ` Andy Shevchenko
2021-01-28 16:19 ` Alexander Sverdlin
[not found] ` <28201612442592@mail.yandex.ru>
2021-02-04 13:36 ` Alexander Sverdlin
[not found] ` <639331612446874@mail.yandex.ru>
2021-02-04 14:05 ` Alexander Sverdlin
2021-01-28 12:21 ` [PATCH v3 2/7] gpio: gpio-ep93xx: Fix single irqchip with multi gpiochips Nikita Shubin
2021-01-28 16:14 ` Andy Shevchenko
2021-01-28 12:21 ` [PATCH v3 3/7] gpio: gpio-ep93xx: Fix wrong irq numbers in port F Nikita Shubin
2021-01-28 18:35 ` Alexander Sverdlin
2021-01-28 12:21 ` [PATCH v3 4/7] gpio: ep93xx: drop to_irq binding Nikita Shubin
2021-01-28 18:41 ` Alexander Sverdlin
2021-01-28 12:21 ` [PATCH v3 5/7] gpio: ep93xx: Fix typo s/hierarchial/hierarchical Nikita Shubin
2021-01-28 12:21 ` [PATCH v3 6/7] gpio: ep93xx: refactor ep93xx_gpio_add_bank Nikita Shubin
2021-01-28 16:17 ` Andy Shevchenko
2021-01-28 18:38 ` Alexander Sverdlin
2021-01-28 12:21 ` [PATCH v3 7/7] gpiod: ep93xx: refactor base IRQ number Nikita Shubin
2021-01-28 18:30 ` Alexander Sverdlin [this message]
2021-01-28 16:15 ` [PATCH v3 0/7] gpio: ep93xx: fixes series patch Andy Shevchenko
2021-02-02 19:24 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f964e132200b9e952a3ad424c5fa82f9d1bf74f1.camel@gmail.com \
--to=alexander.sverdlin@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikita.shubin@maquefel.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).