From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-21.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1369CC2D0E4 for ; Fri, 27 Nov 2020 04:43:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A78FC2222F for ; Fri, 27 Nov 2020 04:43:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="xJa59Lc8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389009AbgK0Ene (ORCPT ); Thu, 26 Nov 2020 23:43:34 -0500 Received: from mail.kernel.org ([198.145.29.99]:39938 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388732AbgK0Ene (ORCPT ); Thu, 26 Nov 2020 23:43:34 -0500 Received: from suppilovahvero.lan (83-245-197-237.elisa-laajakaista.fi [83.245.197.237]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 574A222228; Fri, 27 Nov 2020 04:43:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606452213; bh=KCh3+Weqe5EoWf6AM49ei1gCXMTd+SGq55MsrADXfZw=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=xJa59Lc8W/rBYcF/YckZVBxZDJ3h1RH9b8NKOaBy2uTovn6/eTilJdfSbb5gZcrLS 1zjx0cVSA44XgysDbdmGK0gj7Q/uYRRVRKNQtjBEfwggu9DD7oFQMkS2760uR4+Kc2 jMXWt8fk+Zeft8BWaBPe5qIHaC4Gjx/Bc2xu52tI= Message-ID: <00461e52673271f71250398b5f43a9f311f20457.camel@kernel.org> Subject: Re: [PATCH 131/141] tpm: Fix fall-through warnings for Clang From: Jarkko Sakkinen To: "Gustavo A. R. Silva" Cc: Peter Huewe , Jason Gunthorpe , linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Date: Fri, 27 Nov 2020 06:43:29 +0200 In-Reply-To: <20201124144023.GH16084@embeddedor> References: <1804f48dac434541dc60ada5eefcb86f74905671.1605896060.git.gustavoars@kernel.org> <20201123225226.GA17124@kernel.org> <20201123225322.GA19839@kernel.org> <20201124144023.GH16084@embeddedor> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org On Tue, 2020-11-24 at 08:40 -0600, Gustavo A. R. Silva wrote: > On Tue, Nov 24, 2020 at 12:53:22AM +0200, Jarkko Sakkinen wrote: > > On Tue, Nov 24, 2020 at 12:52:31AM +0200, Jarkko Sakkinen wrote: > > > On Fri, Nov 20, 2020 at 12:40:14PM -0600, Gustavo A. R. Silva wrote: > > > > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > > > > by explicitly adding a break statement instead of letting the code fall > > > > through to the next case. > > > > > > > > Link: https://github.com/KSPP/linux/issues/115 > > > > Signed-off-by: Gustavo A. R. Silva > > > > --- > > > >  drivers/char/tpm/eventlog/tpm1.c | 1 + > > > >  1 file changed, 1 insertion(+) > > > > > > > > diff --git a/drivers/char/tpm/eventlog/tpm1.c b/drivers/char/tpm/eventlog/tpm1.c > > > > index 2c96977ad080..8aa9057601d6 100644 > > > > --- a/drivers/char/tpm/eventlog/tpm1.c > > > > +++ b/drivers/char/tpm/eventlog/tpm1.c > > > > @@ -210,6 +210,7 @@ static int get_event_name(char *dest, struct tcpa_event *event, > > > >                 default: > > > >                         break; > > > >                 } > > > > +               break; > > > >         default: > > > >                 break; > > > >         } > > > > -- > > > > 2.27.0 > > > > > > > > > > > > > > Reviewed-by: Jarkko Sakkinen > > > > > > Who is picking these patches? > > I can take it in my tree for 5.11 if people are OK with that. :) > > > > > > > /Jarkko > > > > I mean > > > > Reviewed-by: Jarkko Sakkinen > > Thanks, Jarkko. > -- > Gustavo keyring: https://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git/commit/?id=a49bdffa9db63a54a6ac56cdcdef8cc8f404f4b6 TPM: https://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git/commit/?id=1ce46c91fdfe5ebf27a6d328b108c630406d1c8c Looks good? /Jarkko