From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Len Baker <len.baker@gmx.com>,
Nicolas Pitre <npitre@baylibre.com>,
Boris Brezillon <boris.brezillon@collabora.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i3c@lists.infradead.org, Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] i3c/master/mipi-i3c-hci: Prefer struct_size over open coded arithmetic
Date: Mon, 13 Sep 2021 19:39:45 +0200 [thread overview]
Message-ID: <163155475974.409020.647490102226402116.b4-ty@bootlin.com> (raw)
In-Reply-To: <20210905144054.5124-1-len.baker@gmx.com>
On Sun, 5 Sep 2021 16:40:54 +0200, Len Baker wrote:
> As noted in the "Deprecated Interfaces, Language Features, Attributes,
> and Conventions" documentation [1], size calculations (especially
> multiplication) should not be performed in memory allocator (or similar)
> function arguments due to the risk of them overflowing. This could lead
> to values wrapping around and a smaller allocation being made than the
> caller was expecting. Using those allocations could lead to linear
> overflows of heap memory and other misbehaviors.
>
> [...]
Applied, thanks!
[1/1] i3c/master/mipi-i3c-hci: Prefer struct_size over open coded arithmetic
commit: 605fa23646dd9a86c4300e1719542a865111d1b6
Best regards,
--
Alexandre Belloni <alexandre.belloni@bootlin.com>
prev parent reply other threads:[~2021-09-13 17:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-05 14:40 [PATCH] i3c/master/mipi-i3c-hci: Prefer struct_size over open coded arithmetic Len Baker
2021-09-06 4:30 ` Nicolas Pitre
2021-09-13 17:39 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163155475974.409020.647490102226402116.b4-ty@bootlin.com \
--to=alexandre.belloni@bootlin.com \
--cc=boris.brezillon@collabora.com \
--cc=keescook@chromium.org \
--cc=len.baker@gmx.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=npitre@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).