From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Matthew Wilcox <willy@infradead.org>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Len Baker <len.baker@gmx.com>, Hannes Reinecke <hare@suse.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
linux-hardening@vger.kernel.org,
Kees Cook <keescook@chromium.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] scsi: advansys: Prefer struct_size over open coded arithmetic
Date: Tue, 5 Oct 2021 00:34:38 -0400 [thread overview]
Message-ID: <163340840528.12126.5824818012998288019.b4-ty@oracle.com> (raw)
In-Reply-To: <20210925114205.11377-1-len.baker@gmx.com>
On Sat, 25 Sep 2021 13:42:05 +0200, Len Baker wrote:
> As noted in the "Deprecated Interfaces, Language Features, Attributes,
> and Conventions" documentation [1], size calculations (especially
> multiplication) should not be performed in memory allocator (or similar)
> function arguments due to the risk of them overflowing. This could lead
> to values wrapping around and a smaller allocation being made than the
> caller was expecting. Using those allocations could lead to linear
> overflows of heap memory and other misbehaviors.
>
> [...]
Applied to 5.16/scsi-queue, thanks!
[1/1] scsi: advansys: Prefer struct_size over open coded arithmetic
https://git.kernel.org/mkp/scsi/c/568778f5572a
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2021-10-05 4:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-25 11:42 [PATCH v2] scsi: advansys: Prefer struct_size over open coded arithmetic Len Baker
2021-09-27 14:48 ` Gustavo A. R. Silva
2021-09-29 2:55 ` Martin K. Petersen
2021-10-05 4:34 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163340840528.12126.5824818012998288019.b4-ty@oracle.com \
--to=martin.petersen@oracle.com \
--cc=gustavoars@kernel.org \
--cc=hare@suse.com \
--cc=jejb@linux.ibm.com \
--cc=keescook@chromium.org \
--cc=len.baker@gmx.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).