From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62650C7EE31 for ; Mon, 22 May 2023 19:40:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235121AbjEVTkO (ORCPT ); Mon, 22 May 2023 15:40:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235160AbjEVTj7 (ORCPT ); Mon, 22 May 2023 15:39:59 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 866C813E for ; Mon, 22 May 2023 12:39:52 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id 98e67ed59e1d1-255401f977dso1536880a91.2 for ; Mon, 22 May 2023 12:39:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1684784392; x=1687376392; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XZNUaQE6VKvjsh7xrkuV4v8D0r55eKxWvK+t0uMsFI8=; b=YvKTLXk/IIa+97neDHvl1q9LrImkclAS+7j5d1vJg/hULvqmkzL/+Gq7nFxGecAH4C S6V1QO38N/GeSXFB06FEG2Au6/J5Mytjp5dmRPvcR0YzaAISMnjgVwAIcr6iRSKIxmQN QJFbmzXyfCR8EYdbyUhTYU0Hk0FCh6i56f560= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684784392; x=1687376392; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XZNUaQE6VKvjsh7xrkuV4v8D0r55eKxWvK+t0uMsFI8=; b=WROm+R0Wlwc1gmlyGmnHKpYVLY5X73lpllHgw7J9whfeekof2osxsFbniT30s5EgNH SGrLHUcHv6bgE6YZYImpMVyZDLSv/jCv/C03o8jA0hpwJWPETyk4z51VQzUkzLOYLNl3 G4E7WON5aoWoRsgsvO40YZV29epNDgmxnzLGj2dj+h/dTTvLgfZAinyxddWskW8JoDmL zCciP+QlpHjumfJM+khmATCmMivJlkg/PfIETomQIQdg9qWz5rpaz+nqohyVgSs9Ra6i yvfzjiNkTTRaHk/T7/14ii3Fk0vcqXXmli3aMqRzozOFpaBqY7fAHnUn1nYVwR0NtVd4 kfQw== X-Gm-Message-State: AC+VfDzibnAu28Qm5NqbrPy34PnSltFJtDV290WPF7wCVqrUf1VqrmfG ydFstdg6B3hQylX49j/SSfT4SqkkjvzFmb09GEA= X-Google-Smtp-Source: ACHHUZ4EpKzUa09Hle/pf2yb2NX+DsxU29dtqawxDs+DN3RESUwjEOptlWwRLaHSygNm5bUpfAxKUA== X-Received: by 2002:a17:90a:9f8b:b0:255:6ea7:7041 with SMTP id o11-20020a17090a9f8b00b002556ea77041mr3720184pjp.41.1684784391898; Mon, 22 May 2023 12:39:51 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id gt18-20020a17090af2d200b0024df6bbf5d8sm4484416pjb.30.2023.05.22.12.39.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 May 2023 12:39:49 -0700 (PDT) From: Kees Cook To: hdegoede@redhat.com, azeemshaikh38@gmail.com Cc: Kees Cook , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] vboxsf: Replace all non-returning strlcpy with strscpy Date: Mon, 22 May 2023 12:39:43 -0700 Message-Id: <168478437621.244538.1202856406180337699.b4-ty@chromium.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230510211146.3486600-1-azeemshaikh38@gmail.com> References: <20230510211146.3486600-1-azeemshaikh38@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org On Wed, 10 May 2023 21:11:46 +0000, Azeem Shaikh wrote: > strlcpy() reads the entire source buffer first. > This read may exceed the destination size limit. > This is both inefficient and can lead to linear read > overflows if a source string is not NUL-terminated [1]. > In an effort to remove strlcpy() completely [2], replace > strlcpy() here with strscpy(). > No return values were used, so direct replacement is safe. > > [...] Applied to for-next/hardening, thanks! [1/1] vboxsf: Replace all non-returning strlcpy with strscpy https://git.kernel.org/kees/c/883f8fe87686 -- Kees Cook