From: Kees Cook <keescook@chromium.org>
To: azeemshaikh38@gmail.com, p.zabel@pengutronix.de, chunkuang.hu@kernel.org
Cc: Kees Cook <keescook@chromium.org>,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
matthias.bgg@gmail.com, linux-hardening@vger.kernel.org,
daniel@ffwll.ch, linux-arm-kernel@lists.infradead.org,
dri-devel@lists.freedesktop.org,
angelogioacchino.delregno@collabora.com, airlied@gmail.com
Subject: Re: [PATCH] drm/mediatek: Replace all non-returning strlcpy with strscpy
Date: Tue, 30 May 2023 16:06:03 -0700 [thread overview]
Message-ID: <168548796307.1350188.12826442108899002892.b4-ty@chromium.org> (raw)
In-Reply-To: <20230522155306.2336889-1-azeemshaikh38@gmail.com>
On Mon, 22 May 2023 15:53:06 +0000, Azeem Shaikh wrote:
> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with strscpy().
> No return values were used, so direct replacement is safe.
>
> [...]
Applied to for-next/hardening, thanks!
[1/1] drm/mediatek: Replace all non-returning strlcpy with strscpy
https://git.kernel.org/kees/c/99ae1670e488
--
Kees Cook
prev parent reply other threads:[~2023-05-30 23:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 15:53 [PATCH] drm/mediatek: Replace all non-returning strlcpy with strscpy Azeem Shaikh
2023-05-22 20:16 ` Kees Cook
2023-05-30 23:06 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168548796307.1350188.12826442108899002892.b4-ty@chromium.org \
--to=keescook@chromium.org \
--cc=airlied@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=azeemshaikh38@gmail.com \
--cc=chunkuang.hu@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).