From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09978C2B9F4 for ; Tue, 22 Jun 2021 15:29:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E782A60FEB for ; Tue, 22 Jun 2021 15:29:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232312AbhFVPbT (ORCPT ); Tue, 22 Jun 2021 11:31:19 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:36583 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232343AbhFVPbQ (ORCPT ); Tue, 22 Jun 2021 11:31:16 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1624375740; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=2MYYVM3Za+tUpGkmkno2Ut0CaeSuF4HzPOvfT7sLpL8=; b=YRFGrxBei+YB14q5Gsyphm5VV/IjNH77QOI80AkOx5DNpS9OoMgyj02Szad0q1/iBBeWmfBv 2cfO4knp1mTBFJa2/iU2nwueMZ+kO18woOgkAz5inqdzi+4GQ7Spo0UZTaBxrmKwrFh3iH1q 3xt8CHy65C+dTiSV5zZ/r52dCok= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyIyNzljNCIsICJsaW51eC1oYXJkZW5pbmdAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n07.prod.us-east-1.postgun.com with SMTP id 60d2018e32b73d6b282ba695 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 22 Jun 2021 15:28:14 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 1343DC433D3; Tue, 22 Jun 2021 15:28:14 +0000 (UTC) Received: from tykki.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 97538C4338A; Tue, 22 Jun 2021 15:28:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 97538C4338A Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] ath11k: Avoid memcpy() over-reading of he_cap From: Kalle Valo In-Reply-To: <20210616195410.1232119-1-keescook@chromium.org> References: <20210616195410.1232119-1-keescook@chromium.org> To: Kees Cook Cc: netdev@vger.kernel.org, Kees Cook , "David S. Miller" , Jakub Kicinski , linux-kernel@vger.kernel.org, ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-hardening@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-Id: <20210622152814.1343DC433D3@smtp.codeaurora.org> Date: Tue, 22 Jun 2021 15:28:14 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org Kees Cook wrote: > In preparation for FORTIFY_SOURCE performing compile-time and run-time > field bounds checking for memcpy(), memmove(), and memset(), avoid > intentionally writing across neighboring array fields. > > Since peer_he_cap_{mac,phy}info and he_cap_elem.{mac,phy}_cap_info are not > the same sizes, memcpy() was reading beyond field boundaries. Instead, > correctly cap the copy length and pad out any difference in size > (peer_he_cap_macinfo is 8 bytes whereas mac_cap_info is 6, and > peer_he_cap_phyinfo is 12 bytes whereas phy_cap_info is 11). > > Signed-off-by: Kees Cook > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. c8bcd82a4efd ath11k: Avoid memcpy() over-reading of he_cap -- https://patchwork.kernel.org/project/linux-wireless/patch/20210616195410.1232119-1-keescook@chromium.org/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches