From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A484C4338F for ; Sun, 22 Aug 2021 05:16:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D6A95610FF for ; Sun, 22 Aug 2021 05:16:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231153AbhHVFRD (ORCPT ); Sun, 22 Aug 2021 01:17:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230153AbhHVFRA (ORCPT ); Sun, 22 Aug 2021 01:17:00 -0400 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 881F5C061575 for ; Sat, 21 Aug 2021 22:16:20 -0700 (PDT) Received: by mail-pj1-x102b.google.com with SMTP id qe12-20020a17090b4f8c00b00179321cbae7so9968757pjb.2 for ; Sat, 21 Aug 2021 22:16:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=y8ajL1MXjnm98ftlu2xw9F3LVfgwHRHrIy4fib1NoNg=; b=Y0a8GbxIDGsupMPfALs9c9spCnnTUj10GqcmI81qVhXcdsNXwx3+WXpuFT/OMEwdqV ov72OppMgo1s3fFQNnWub4aPQ3g1ot25/8ftkZ5p3ZUdFTAy3eibMgeUHw1Ncik4DfoH 1fyvWtmEFxySeGpMWW3u1iMK9poENxq7thhvU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=y8ajL1MXjnm98ftlu2xw9F3LVfgwHRHrIy4fib1NoNg=; b=DWN02ygDLRspyRw4NotiAy6Nl/5iPBy850ksOcIVnYSPc2kcK981KT7QeejK3sL682 lHEUnOa7RWPrHvyUOJPnS56gIZJlIGwhwHFSwlgYVnQ4v8EYw400++md3VZSTJQHMM1y xTbOf7fenXhJQ68sWandLBSurt/DRRFgV9yEG2sNmQHyqrEpQa+/hxtTuTgwGA7hjamw nBv9TzPXMCZtepZDT65zbCq1JMrAjyrkKuD3LKYZdVDjxyb7HAEzlqcXw/WtEx3Txdgx EHLepUs22lvhicpLDLu0CopzTgQfwQbR3SyDiLzrKgyAiMICDOj+1McRDSU3nr7osGDh ZxWw== X-Gm-Message-State: AOAM532/zplQEs+vKvJjpqZtazXKAjYWSJeh6sw2DxOtf6BIT9h6+qiX AWzbk6n3cioYcGYIL3dfqDnVpA== X-Google-Smtp-Source: ABdhPJyR+NATVJLBLIhcM5YqAZh+Upqb5pIwMTUuXQGDWIR7A9ZoJQ38xuDUEW6TSdHtuwjl1NIx8w== X-Received: by 2002:a17:90a:5147:: with SMTP id k7mr11682056pjm.73.1629609380131; Sat, 21 Aug 2021 22:16:20 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id m194sm11771124pfd.58.2021.08.21.22.16.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Aug 2021 22:16:19 -0700 (PDT) Date: Sat, 21 Aug 2021 22:16:18 -0700 From: Kees Cook To: Kalle Valo Cc: Jakub Kicinski , Saeed Mahameed , netdev@vger.kernel.org, Stanislav Yakovlev , "David S. Miller" , Leon Romanovsky , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH 0/3] net: Cleanups for FORTIFY_SOURCE Message-ID: <202108212215.35185C924B@keescook> References: <20210819202825.3545692-1-keescook@chromium.org> <20210820100151.25f7ccd4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <87tujjt8d9.fsf@codeaurora.org> <87eean9kby.fsf@tynnyri.adurom.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87eean9kby.fsf@tynnyri.adurom.net> Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org On Sat, Aug 21, 2021 at 01:13:37PM +0300, Kalle Valo wrote: > Kalle Valo writes: > > > Jakub Kicinski writes: > > > >> On Thu, 19 Aug 2021 13:28:22 -0700 Kees Cook wrote: > >>> Hi, > >>> > >>> In preparation for FORTIFY_SOURCE performing compile-time and run-time > >>> field bounds checking for memcpy(), memmove(), and memset(), avoid > >>> intentionally writing across neighboring fields. > >>> > >>> These three changes have been living in my memcpy() series[1], but have > >>> no external dependencies. It's probably better to have these go via > >>> netdev. > >> > >> Thanks. > >> > >> Kalle, Saeed - would you like to take the relevant changes? Presumably > >> they would get into net-next anyway by the time the merge window opens. > > > > Ok, I'll take patch 1 to wireless-drivers-next. > > Correction: I'll take patches 1 and 3 to wireless-drivers-next. Great; thanks! -- Kees Cook