From: Len Baker <len.baker@gmx.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kees Cook <keescook@chromium.org>
Cc: Len Baker <len.baker@gmx.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Michael Straube <straube.linux@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: [PATCH v2 0/3] staging/rtl8192u: Prefer kcalloc over open coded arithmetic
Date: Tue, 24 Aug 2021 09:25:42 +0200 [thread overview]
Message-ID: <20210824072545.7321-1-len.baker@gmx.com> (raw)
The main reason of this patch serie is to avoid size calculations
(especially multiplication) in memory allocator function arguments due
to the risk of them overflowing [1]. This could lead to values wrapping
around and a smaller allocation being made than the caller was
expecting. Using those allocations could lead to linear overflows of
heap memory and other misbehaviors.
At the same time, take the opportunity to refactor the function avoiding
CamelCase in the name of variables and moving some initializations to
the variables definition block.
[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments
Changelog v1 -> v2
- Split the CamelCase refactoring and the moving of initializations in
two separate commits (Kees Cook).
- Link to the documentation to clarify the change in the 3/3 patch (Kees
Cook).
- Modify the commit message to clarify in the 3/3 patch that these
changes are not dynamic sizes but it is best to do the change to keep
the open-coded math idiom out of code (Kees Cook).
Len Baker (3):
staging/rtl8192u: Avoid CamelCase in names of variables
staging/rtl8192u: Initialize variables in the definition block
staging/rtl8192u: Prefer kcalloc over open coded arithmetic
drivers/staging/rtl8192u/r819xU_phy.c | 92 +++++++++++++--------------
1 file changed, 44 insertions(+), 48 deletions(-)
--
2.25.1
next reply other threads:[~2021-08-24 7:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 7:25 Len Baker [this message]
2021-08-24 7:25 ` [PATCH v2 1/3] staging/rtl8192u: Avoid CamelCase in names of variables Len Baker
2021-08-24 8:59 ` [PATCH v2 2/3] staging/rtl8192u: Initialize variables in the definition block Len Baker
2021-08-24 9:00 ` [PATCH v2 3/3] staging/rtl8192u: Prefer kcalloc over open coded arithmetic Len Baker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210824072545.7321-1-len.baker@gmx.com \
--to=len.baker@gmx.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=lee.jones@linaro.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).